From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A8C9143C72; Mon, 11 Nov 2024 09:38:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731317905; cv=none; b=iuJQdDSZeHlhOMGON38xDnj+kve2ZSIjVNt7QLp0d4IDHaeqA8xezmjq65tSZDdO5OlWKrSRRd1v2ok7ZdEdS0yVZh5jTqshFuRwl0IgaBPoffRPc7eSs+L5u193ZbDtlhF+3ntNnU0mn7hudelVYCnLDctjsUUDjxwBcd5VmAM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731317905; c=relaxed/simple; bh=xeAyYEonYfltQhc7TK13Y/TErfyKMLlkw7rNEBEmLZM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CMUoR/BOcz9HkmXezVcfh/XEMNPsy54Q6giEjP749Fqy4/wrAWUYqNjrhqvTY62jhhSQUcNQhlBF3b1CmDyb+1oKan/LFJ36W1x6MpZr8+BkIMDYvFE/8doX3JvO8eVHyARWT1Pa+X2kXWlnRkElExCwn8jYYAnjUdgsTQx01ms= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com; spf=fail smtp.mailfrom=gmail.com; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=gmail.com X-CSE-ConnectionGUID: SHRe0o4mSM2Dbi0HHIojsA== X-CSE-MsgGUID: 7TM6ngcORletU/gd1KwUIQ== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="31283510" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="31283510" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2024 01:38:23 -0800 X-CSE-ConnectionGUID: vKgxvLnxSW2eLqkX5QZQww== X-CSE-MsgGUID: e+5VjbTJS5GlYdx0irgteA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,144,1728975600"; d="scan'208";a="87640065" Received: from smile.fi.intel.com ([10.237.72.154]) by orviesa008.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2024 01:38:20 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1tAQsB-0000000DXr3-2uiO; Mon, 11 Nov 2024 11:38:15 +0200 Date: Mon, 11 Nov 2024 11:38:15 +0200 From: Andy Shevchenko To: Aren Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Kaustabh Chakraborty , =?iso-8859-1?B?QmFybmFi4XMgQ3rpbeFu?= , Ondrej Jirman , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Dragan Simic , phone-devel@vger.kernel.org Subject: Re: [PATCH v4 2/6] iio: light: stk3310: handle all remove logic with devm callbacks Message-ID: References: <20241102195037.3013934-3-aren@peacevolution.org> <20241102195037.3013934-7-aren@peacevolution.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Sun, Nov 10, 2024 at 05:37:56PM -0500, Aren wrote: > On Sun, Nov 10, 2024 at 09:51:04PM +0200, Andy Shevchenko wrote: > > Sun, Nov 10, 2024 at 01:38:39PM -0500, Aren kirjoitti: > > > On Mon, Nov 04, 2024 at 10:32:08AM +0200, Andy Shevchenko wrote: > > > > On Sat, Nov 02, 2024 at 03:50:37PM -0400, Aren Moynihan wrote: ... > > > > > + ret = devm_add_action_or_reset(&client->dev, stk3310_set_state_disable, data); > > > > > > > > Why not simply 'dev' as in below call? > > > > > > I was trying to avoid refactoring the entire function to replace > > > &client->dev with dev, I'll add a patch for that to the next revision. > > > > I'm not talking about refactoring, I'm talking only about the lines that you > > have touched / added. > > Ah right, this one makes sense, my comment should have been on the next > patch in this series which is a little more complex. For that patch it > seemed inconsistent to use dev only in new code and mix it with calls > using &client->dev. It's fine, you can add a new cleanup patch later on. -- With Best Regards, Andy Shevchenko