Re: [PATCH v6 6/7] pinctrl: s32cc: implement GPIO functionality

Markus Elfring
2024-12-11T17:17:07Z

…
> +++ b/drivers/pinctrl/nxp/pinctrl-s32cc.c
…
> +static void s32_gpio_free(struct gpio_chip *gc, unsigned int gpio)
> +{
…
> + spin_lock_irqsave(&ipctl->gpio_configs_lock, flags);
> +
> + list_for_each_entry_safe(gpio_pin, tmp, &ipctl->gpio_configs, list) {
…
> + }
> +
> +unlock:
> + spin_unlock_irqrestore(&ipctl->gpio_configs_lock, flags);
> +}

How do you think about to apply another call “scoped_guard(spinlock_irqsave, &ipctl->gpio_configs_lock)” here?

Regards,
Markus