Re: [PATCH v6 1/7] dt-bindings: mfd: add support for the NXP SIUL2 module

Krzysztof Kozlowski
2024-11-19T13:12:30Z

On Tue, Nov 19, 2024 at 11:44:23AM +0200, Andrei Stefanescu wrote:
> Hi Krzysztof,
>
> Thank you for your review!
>
> On 19/11/2024 11:21, Krzysztof Kozlowski wrote:
> > On 13/11/2024 11:10, Andrei Stefanescu wrote:
> >> +
> >> +properties:
> >> + compatible:
> >> + enum:
> >> + - nxp,s32g2-siul2
> >> + - nxp,s32g3-siul2
> >
> > Not much improved. See other NXP bindings how they do this.
> >
>
> Do you mean to have the "nxp,s32g3-siul2" compatible fall back to the g2 one?

Yes, compatibility between devices means fallback.

>
> >> +
> >> + gpio-reserved-ranges:
> >> + maxItems: 2
> >
> > That's odd to always require two reserved ranges. Does this mean all
> > devices have exactly the same reserved GPIOs? Then the driver should not
> > export them.
>
> Yes, the driver exports GPIOs from two hardware modules because they are
> tightly coupled. I export two gpio-ranges, each one corresponding to a
> hardware module. If I were to export more gpio-ranges, thus avoiding
> gpio-reserved-ranges, it would be hard to know to which hardware module
> a gpio-range belongs. I would like to keep the current implementation
> regarding this problem. Would that be ok?

I don't understand why this is needed then. If you always export same
set of GPIOs, why do you export something which is unusable/reserved?

Best regards,
Krzysztof