From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CDE01B3955 for ; Fri, 15 Nov 2024 10:53:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731668027; cv=none; b=H/zn4fvp+yaBqow29DYJnDzugPMLBjrjmIXMd7E9+yqxTR1L/wUQ9Wd/VQbqjlvkL1bO1rTb0QaDN94gW6q0eMC1UaKOn+fPNPiUniznKHCq23DfUG4zJXRaWxNGz0fkwM4BdfVJ5Y4dxldlpeixaB2IBDK+ObRj4fQ8aNuQ+M4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731668027; c=relaxed/simple; bh=Aze8ubsJfw20CCAheENnV0TxOaVpLIudKLyqB1mUmWs=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ki8INDZGV3q+Mff1mRFvB/8zLJ2eENjRj+jdym2aV2rLgvN92ox7SUOY2ubJiUZIm0zQsl0vPIr+wwKbnWbge6FiI4ES2tZKpnmsDqcBYTBY+SqugNL4mUUbTLSJrn2hqRn86llgNWZ/wA2Jy/F9qxUcl/UBbuWN5vgyquFNMdA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=LxD2iVQS; arc=none smtp.client-ip=209.85.208.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="LxD2iVQS" Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2fb49510250so5450531fa.0 for ; Fri, 15 Nov 2024 02:53:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1731668023; x=1732272823; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=kqEZZaXWIaNRK9OLE5Wx827F0bUtvaOZcgVtTnimPxg=; b=LxD2iVQSWDliHa7Qm3U3T/EF+DEPxdk9Ry8F7GTgz3VvaNne5Bk1xmuxG6LqbmMXDz 5rlp5x3XY53Lq88fHFqXPax4sm/eWCl63dMf8NDRiPHsqBmsRNFtnIaJS9g7oygJahmr yOXnNQlESkzsmaTIhRvy97jxtpiq4j8KaBGB/cREmFctrM/vwQzXRsKMoMV9q46oy8gz miY6W2t5FL5k1Xzc6cQ1NVZEzOOn17TiwTYFlTubfSdjVbzgWUPzhfMeXCOLE2ULq2HA WyCXiqEGTDgOU277xMcpAN87RLgbLg5KBgZ6NI90hAMsIuBXhXrWI9+t7wkIVZ9nBY0y sgZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731668023; x=1732272823; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kqEZZaXWIaNRK9OLE5Wx827F0bUtvaOZcgVtTnimPxg=; b=vx3U6S5AlYqHWbdu5n3d7nb3VvnWmKmSbHeCQIib7MGhUDTO/ha93VALIVfjoH8ZXc g2qjCK2xlO+Vk5y84Ynef/b9Z8Ub7J87lmDI5NKPcGd/yHB2zukA7+Xc3DbxPM+X+Y5h V1wDhZ9LP7h9VWU7APRwstNQN37cc3MH9Hyv6UbhJR4+sHMP/HW+R1Zpl+qPIAy6ya2V nLkdqd5eYjQ+P/v69kG/GYNPpiZSCwdf4rV/IB8vkccVIx6NM4K+TcvDcdhvpK4agioI CTlucV8dDZuOaZcpzs8O5PZjBWdyuvHr4suHktes6k8Y7spAurA+mYTwTFHe8047OaPZ fBKw== X-Forwarded-Encrypted: i=1; AJvYcCVhSPg14qjxIwX3nKewi0xekP0OaS1y8h5ICzh4HOaG5cXcVyTpw7XmK6SIZ31H1HDgfStzvLbi4qGH@vger.kernel.org X-Gm-Message-State: AOJu0Yx9Hhe4KsVQCuP8hn4+UyyVwHqmFA+ew/OU5OB32ohGgV3LPq81 Ahnbu8lduxqcpWJpwYpiJBMxvpoRamSBebwWaJ72504sjiGgr+lLJjkXe9Xc5g0= X-Google-Smtp-Source: AGHT+IFHVLZ9JHkGOvekL5vmiZxKEfDLHTUYv8vjzg0FSLM0sIjZA/dYE3eiUJZBbLbHkNSDwDDmVw== X-Received: by 2002:a05:651c:245:b0:2fa:c59d:1af3 with SMTP id 38308e7fff4ca-2ff606933a3mr12846531fa.20.1731668023447; Fri, 15 Nov 2024 02:53:43 -0800 (PST) Received: from localhost (host-79-19-144-50.retail.telecomitalia.it. [79.19.144.50]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5cf9010b12bsm531260a12.41.2024.11.15.02.53.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Nov 2024 02:53:43 -0800 (PST) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Fri, 15 Nov 2024 11:54:11 +0100 To: Bjorn Helgaas Cc: Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Stefan Wahren , Herve Codina , Luca Ceresoli , Thomas Petazzoni , Andrew Lunn , stable@vger.kernel.org Subject: Re: [PATCH 2/2] of: address: Preserve the flags portion on 1:1 dma-ranges mapping Message-ID: References: <20241108165654.GA1665761@bhelgaas> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241108165654.GA1665761@bhelgaas> Hi Bjorn, On 10:56 Fri 08 Nov , Bjorn Helgaas wrote: > On Fri, Nov 08, 2024 at 11:39:21AM +0100, Andrea della Porta wrote: > > A missing or empty dma-ranges in a DT node implies a 1:1 mapping for dma > > translations. In this specific case, the current behaviour is to zero out > > the entire specifier so that the translation could be carried on as an > > offset from zero. This includes address specifier that has flags (e.g. > > PCI ranges). > > Once the flags portion has been zeroed, the translation chain is broken > > since the mapping functions will check the upcoming address specifier > > against mismatching flags, always failing the 1:1 mapping and its entire > > purpose of always succeeding. > > Set to zero only the address portion while passing the flags through. > > Add blank lines between paragraphs. Ack. > > > Fixes: dbbdee94734b ("of/address: Merge all of the bus translation code") > > Cc: stable@vger.kernel.org > > Signed-off-by: Andrea della Porta > > Tested-by: Herve Codina > > --- > > drivers/of/address.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/of/address.c b/drivers/of/address.c > > index 286f0c161e33..72b6accff21c 100644 > > --- a/drivers/of/address.c > > +++ b/drivers/of/address.c > > @@ -455,7 +455,8 @@ static int of_translate_one(struct device_node *parent, struct of_bus *bus, > > } > > if (ranges == NULL || rlen == 0) { > > offset = of_read_number(addr, na); > > - memset(addr, 0, pna * 4); > > + /* copy the address while preserving the flags */ > > Not knowing the surrounding code, it seems strange to say "copy the > address" when the memset() fills with zero and does no copying. > > The commit log says "set address to zero, pass flags through," and I > could believe *that* matches the memset(). Ack. Many thanks, Andrea > > > + memset(addr + pbus->flag_cells, 0, (pna - pbus->flag_cells) * 4); > > pr_debug("empty ranges; 1:1 translation\n"); > > goto finish; > > } > > -- > > 2.35.3 > >