Re: [PATCH 2/2] libfdt: Remove extra semi-colons outside functions

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 2116 bytes --]

On Sat, Nov 16, 2024 at 06:12:28PM +0800, Bingwu Zhang wrote:
> From: Bingwu Zhang <xtexchooser@duck.com>
> 
> When compiling with -Werror -Wpedantic, both GCC and Clang fails, saying
> that these semi-colons are redundant, so remove them.
> 
> Signed-off-by: Bingwu Zhang <xtexchooser@duck.com>

Applied, thanks.

> ---
>  libfdt/fdt_overlay.c |  2 +-
>  libfdt/libfdt.h      | 20 ++++++++++----------
>  2 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/libfdt/fdt_overlay.c b/libfdt/fdt_overlay.c
> index f9be13865807..1b098e61c270 100644
> --- a/libfdt/fdt_overlay.c
> +++ b/libfdt/fdt_overlay.c
> @@ -352,7 +352,7 @@ static int overlay_fixup_one_phandle(void *fdt, void *fdto,
>  						   name, name_len, poffset,
>  						   &phandle_prop,
>  						   sizeof(phandle_prop));
> -};
> +}
>  
>  /**
>   * overlay_fixup_phandle - Set an overlay phandle to the base one
> diff --git a/libfdt/libfdt.h b/libfdt/libfdt.h
> index 96782bc57b84..2e182ea3314d 100644
> --- a/libfdt/libfdt.h
> +++ b/libfdt/libfdt.h
> @@ -263,16 +263,16 @@ int fdt_next_subnode(const void *fdt, int offset);
>  		struct fdt_header *fdth = (struct fdt_header *)fdt; \
>  		fdth->name = cpu_to_fdt32(val); \
>  	}
> -fdt_set_hdr_(magic);
> -fdt_set_hdr_(totalsize);
> -fdt_set_hdr_(off_dt_struct);
> -fdt_set_hdr_(off_dt_strings);
> -fdt_set_hdr_(off_mem_rsvmap);
> -fdt_set_hdr_(version);
> -fdt_set_hdr_(last_comp_version);
> -fdt_set_hdr_(boot_cpuid_phys);
> -fdt_set_hdr_(size_dt_strings);
> -fdt_set_hdr_(size_dt_struct);
> +fdt_set_hdr_(magic)
> +fdt_set_hdr_(totalsize)
> +fdt_set_hdr_(off_dt_struct)
> +fdt_set_hdr_(off_dt_strings)
> +fdt_set_hdr_(off_mem_rsvmap)
> +fdt_set_hdr_(version)
> +fdt_set_hdr_(last_comp_version)
> +fdt_set_hdr_(boot_cpuid_phys)
> +fdt_set_hdr_(size_dt_strings)
> +fdt_set_hdr_(size_dt_struct)
>  #undef fdt_set_hdr_
>  
>  /**

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]