Devicetree
 help / color / mirror / Atom feed
From: Vignesh Viswanathan <vignesh.viswanathan@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Saravanan Sekar <sravanhome@gmail.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: regulator: mps,mp8899: Add binding for MP8899 PMIC
Date: Tue, 26 May 2026 13:09:43 +0530	[thread overview]
Message-ID: <a00286c4-3caa-465c-b174-928cae3ca3b8@oss.qualcomm.com> (raw)
In-Reply-To: <20260520-calculating-ruby-pudu-1b6ac6@quoll>



On 5/20/2026 3:58 PM, Krzysztof Kozlowski wrote:
> On Tue, May 19, 2026 at 11:51:05PM +0530, Vignesh Viswanathan wrote:
>> Add devicetree binding documentation for the Monolithic Power Systems
>> MP8899 PMIC, which provides four synchronous buck converters controlled
>> over I2C.
> 
> Ah, and one more, standard comment (so you could have avoided that
> easily):
> 
> Drop second/last, redundant "binding for". The
> "dt-bindings" prefix is already stating that these are bindings.
> See also:
> https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Sure, will drop the redundant text.

Thanks,
Vignesh
> 
> Best regards,
> Krzysztof
> 


  reply	other threads:[~2026-05-26  7:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19 18:21 [PATCH 0/2] Add regulator driver for MPS MP8899 PMIC Vignesh Viswanathan
2026-05-19 18:21 ` [PATCH 1/2] dt-bindings: regulator: mps,mp8899: Add binding for " Vignesh Viswanathan
2026-05-20 10:27   ` Krzysztof Kozlowski
2026-05-26  7:39     ` Vignesh Viswanathan
2026-05-20 10:28   ` Krzysztof Kozlowski
2026-05-26  7:39     ` Vignesh Viswanathan [this message]
2026-05-19 18:21 ` [PATCH 2/2] regulator: mp8899: Add MPS MP8899 PMIC regulator driver Vignesh Viswanathan
2026-05-19 18:54   ` sashiko-bot
2026-05-20 10:39   ` Krzysztof Kozlowski
2026-05-26  7:39     ` Vignesh Viswanathan
2026-05-26  9:28       ` Krzysztof Kozlowski
2026-05-26  9:38         ` Vignesh Viswanathan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a00286c4-3caa-465c-b174-928cae3ca3b8@oss.qualcomm.com \
    --to=vignesh.viswanathan@oss.qualcomm.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sravanhome@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox