From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dietmar Eggemann Subject: Re: [PATCH 4/4] arm: dts: r8a7790: add cpu capacity-dmips-mhz information Date: Mon, 9 Oct 2017 18:55:07 +0100 Message-ID: References: <20170830144120.9312-1-dietmar.eggemann@arm.com> <20170830144120.9312-5-dietmar.eggemann@arm.com> <20170918073946.GA9156@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20170918073946.GA9156@verge.net.au> Content-Language: en-GB Sender: linux-renesas-soc-owner@vger.kernel.org To: Simon Horman Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Russell King , Rob Herring , Mark Rutland , Kukjin Kim , Krzysztof Kozlowski , Vincent Guittot , Juri Lelli List-Id: devicetree@vger.kernel.org On 18/09/17 08:39, Simon Horman wrote: > On Wed, Aug 30, 2017 at 03:41:20PM +0100, Dietmar Eggemann wrote: >> The following 'capacity-dmips-mhz' dt property values are used: >> >> Cortex-A15: 1024, Cortex-A7: 539 >> >> They have been derived form the cpu_efficiency values: >> >> Cortex-A15: 3891, Cortex-A7: 2048 >> >> by scaling them so that the Cortex-A15s (big cores) use 1024. >> >> The cpu_efficiency values were originally derived from the "Big.LITTLE >> Processing with ARM Cortex™-A15 & Cortex-A7" white paper >> (http://www.cl.cam.ac.uk/~rdm34/big.LITTLE.pdf). Table 1 lists 1.9x >> (3891/2048) as the Cortex-A15 vs Cortex-A7 performance ratio for the >> Dhrystone benchmark. >> >> The following platform is affected once cpu-invariant accounting >> support is re-connected to the task scheduler: > > Thanks, applied for v4.15. > > My understanding from the following comment in the cover letter is that not > currently the case and this there is no behavioural change in applying this > patch. > > For the record I observed the following with and without this patch > applied. I believe this is the expected result. > > v4.14-rc1 > # cat /sys/devices/system/cpu/cpu*/cpu_capacity > 1535 > 1535 > 1535 > 1535 > 1024 > 1024 > 1024 > 1024 > > v4.14-rc1 + patch > # cat /sys/devices/system/cpu/cpu*/cpu_capacity > 1024 > 1024 > 1024 > 1024 > 539 > 539 > 539 > 539 Thanks Simon! Yes, that is the expected behaviour. And sorry for not responding earlier! With exynos542{0,2} and r8a7790 switching to the 'capacity-dmips-mhz' based solution in v4.15, I can push for removal of the cpu_efficency code [patch 1/4].