From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Subject: Re: [PATCH v2 05/13] mmc: mediatek: make hs400_tune_response only for mt8173 Date: Mon, 9 Oct 2017 16:58:54 +0200 Message-ID: References: <1507548926-9555-1-git-send-email-chaotian.jing@mediatek.com> <1507548926-9555-6-git-send-email-chaotian.jing@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1507548926-9555-6-git-send-email-chaotian.jing@mediatek.com> Content-Language: en-US Sender: linux-mmc-owner@vger.kernel.org To: Chaotian Jing , Ulf Hansson Cc: Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , yong mao , Linus Walleij , Javier Martinez Canillas , Heiner Kallweit , Phong LE , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, srv_heupstream@mediatek.com List-Id: devicetree@vger.kernel.org On 10/09/2017 01:35 PM, Chaotian Jing wrote: > the origin design of hs400_tune_response is for mt8173 because of > mt8173 has a special design. for doing that, we add a new member > "compatible", by now it's only for mt8173. > > Signed-off-by: Chaotian Jing > --- > drivers/mmc/host/mtk-sd.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c > index 643c795..e8f8ad9 100644 > --- a/drivers/mmc/host/mtk-sd.c > +++ b/drivers/mmc/host/mtk-sd.c > @@ -317,6 +317,7 @@ struct msdc_delay_phase { > struct msdc_host { > struct device *dev; > const struct mtk_mmc_compatible *dev_comp; > + const char *compatible; > struct mmc_host *mmc; /* mmc structure */ > int cmd_rsp; > > @@ -666,7 +667,8 @@ static void msdc_set_mclk(struct msdc_host *host, unsigned char timing, u32 hz) > host->base + PAD_CMD_TUNE); > } > > - if (timing == MMC_TIMING_MMC_HS400) > + if (timing == MMC_TIMING_MMC_HS400 && > + !strcmp(host->compatible, "mediatek,mt8173-mmc")) You can add another value to mtk_mmc_compatible as you did in all the following patches. Regards, Matthias > sdr_set_field(host->base + PAD_CMD_TUNE, > MSDC_PAD_TUNE_CMDRRDLY, > host->hs400_cmd_int_delay); > @@ -1594,7 +1596,8 @@ static int msdc_execute_tuning(struct mmc_host *mmc, u32 opcode) > struct msdc_host *host = mmc_priv(mmc); > int ret; > > - if (host->hs400_mode) > + if (host->hs400_mode && > + !strcmp(host->compatible, "mediatek,mt8173-mmc")) > ret = hs400_tune_response(mmc, opcode); > else > ret = msdc_tune_response(mmc, opcode); > @@ -1745,6 +1748,7 @@ static int msdc_drv_probe(struct platform_device *pdev) > > host->dev = &pdev->dev; > host->dev_comp = of_id->data; > + host->compatible = of_id->compatible; > host->mmc = mmc; > host->src_clk_freq = clk_get_rate(host->src_clk); > /* Set host parameters to mmc */ >