From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53847248F76 for ; Mon, 14 Jul 2025 13:03:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752498221; cv=none; b=pDL7imVBZNdkmp07g2axSiiPzp+CsuO4X7a9V94jCMkv30nhlXRBgHky0xiM53Qv3aXWvaxLNIqppt1zwbSk3wVECtngaPsyymSbEE5juJP2hGlilleriW4V7JculhKFIx1VhL0NZi9/w3efTKuPLiyv4aapjMzW8gv23v2D3ZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752498221; c=relaxed/simple; bh=hFa5B+vOhUzo10XdA1ePUXEFz1368621t2hx9gZBOfU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZUkYSy5WHp0I00cPVZBm1b1CMFVyfQSGyMrNNBXLk6tTh7hbORTs25mNLPbDCpDFxYe8jCueGromBpczD7VxrDF+IgUNS0xBLZe+Ddr3ta5HvMCPV26o2kg+BlkYkdFDShxXoZSc7frr9LrzV0OkGtJUQR/o91qyvOEqVLkIK3I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=OuNQ6h1S; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OuNQ6h1S" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752498218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ghp/oDHokGFDT4c0GtUH9Qm0zdrYdHDESxRMKCw2J6A=; b=OuNQ6h1SN+kivXvjBNzcBSMMQ4ZSln3VjI9NQBNO+jj8kOV616eIJmvDHjr+4OeSzzm553 HE+2+fECvwtrM4fTVVVUN1xthznupJAVxeX0+iSKAuS68wbIiN908pa/R/WABjUKFnR/Lw 2SJWLK9FpYjMfdq/+nX3bUX4cKfJ/Tc= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-678-cscgtY8XMxeWxjt52ikrYQ-1; Mon, 14 Jul 2025 09:03:36 -0400 X-MC-Unique: cscgtY8XMxeWxjt52ikrYQ-1 X-Mimecast-MFC-AGG-ID: cscgtY8XMxeWxjt52ikrYQ_1752498215 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-ae71c874ff7so158427266b.1 for ; Mon, 14 Jul 2025 06:03:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752498215; x=1753103015; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ghp/oDHokGFDT4c0GtUH9Qm0zdrYdHDESxRMKCw2J6A=; b=Nvi6G9rbG3Jwpwq/JX7EPt7kkKetOQT0wPn95ZchZhTcOXVvfCqSldqSMWxSE+Y2Sn K7aSOpKPdaL+40WGxFF7CCI9PJCJh9uUw7r9fQQyrTvF79n1kU1MLPs2cqlh4HR73b1U RBAFEv5FTw08AxKD73QsFOEAPALry1gSkA4NUACA47oxAHH0VUThgaWn3McaXhZdGjAf E2g3hNPMPpzP2FPOaTlYRqXxjZgMKF5BltSbgUSqHwrcBDYsVh+t6u/80jp+vsE31smU oOxaYAB2MzH6/JdnvuuVkVUl9oK2FfrXs4TbgKF+rHKD1dY1oTzu45X9d8KzVdhMQuJ1 EA9w== X-Forwarded-Encrypted: i=1; AJvYcCXLRIwwlT/SPr6HddTWRbE6dQShszZVJ1qwfDnrvDB1p7WnDFOe+SiJ9kj6VapkHpbEFJ+EgIEwIBCd@vger.kernel.org X-Gm-Message-State: AOJu0Ywim9WU06LN8V/VeFGkrXEbuBE/ogsHDn4kKSYbHFayl0lvZUPr ynfWwtfGH/qVokLnhzgKcs+bZRbG1xcqLOeNuXXndORL/HsU9mEvDNsELnxo6/VKYPJb9BDDwzx hBIyAAVBJRb1wYtM2Sa9W1a0YO71ymrz0YuALI2bnh0L02camwoIVw+Ima/9sEaY= X-Gm-Gg: ASbGnctWvBdR3EPcg9zbOG0dkdIcDm59pFnmqjPpL3PsVzZgRr/4XZLa847C/bC7Hjg GBpSJ2UFBNydK0jG9fZdQ+UNVAdl0tZbBlWmGMIp7EsyPOJ/1aSdGeC1gm20LO1Y/PYkh+T9eXi DBVXTMgc6GyHX2tWMsZFg4KUuPNcuDnznfLZNoLbcVzHpAYLpYvjdoMW+l4gV9/1QKMzoXGbq8e baOs3QoHjpnMwzdxKy09iPDIYPTg/9i7A+XYhA3b/lu1Yaw+I2MvpG9rVsn97TOT0LjlFtAqZ6w 35J4ZVpJMtWyH4LcyhOX9Ccpy+3QjUbnR794VQwTIwSD X-Received: by 2002:a17:907:720e:b0:ae6:df9e:736c with SMTP id a640c23a62f3a-ae6fbc8d8d6mr1350142166b.21.1752498213125; Mon, 14 Jul 2025 06:03:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEmcjs17OWp2mBZdxtCVdScokbQNauUNY8FA5TyZCIo3LHQd4tRBh7KK5QdtcHV7XwRDZxtgA== X-Received: by 2002:a17:907:720e:b0:ae6:df9e:736c with SMTP id a640c23a62f3a-ae6fbc8d8d6mr1350118366b.21.1752498210569; Mon, 14 Jul 2025 06:03:30 -0700 (PDT) Received: from [10.40.98.122] ([78.108.130.194]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e8264fa0sm803554666b.88.2025.07.14.06.03.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Jul 2025 06:03:30 -0700 (PDT) Message-ID: Date: Mon, 14 Jul 2025 15:03:28 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/12] media: v4l: fwnode: Support ACPI's _PLD for v4l2_fwnode_device_parse To: Ricardo Ribalda , Laurent Pinchart , Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bartosz Golaszewski , "Rafael J. Wysocki" , Len Brown Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org References: <20250605-uvc-orientation-v2-0-5710f9d030aa@chromium.org> <20250605-uvc-orientation-v2-2-5710f9d030aa@chromium.org> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <20250605-uvc-orientation-v2-2-5710f9d030aa@chromium.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 5-Jun-25 19:52, Ricardo Ribalda wrote: > Currently v4l2_fwnode_device_parse() obtains the orientation and > rotation via fwnode properties. > > Extend the function to support as well ACPI devices with _PLD info. > > We give a higher priority to fwnode, because it might contain quirks > injected via swnodes. > > Signed-off-by: Ricardo Ribalda > --- > drivers/media/v4l2-core/v4l2-fwnode.c | 85 ++++++++++++++++++++++++++++++++--- > 1 file changed, 79 insertions(+), 6 deletions(-) > > diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-core/v4l2-fwnode.c > index cb153ce42c45d69600a3ec4e59a5584d7e791a2a..379290ab3cfde74c8f663d61837a9a95011b5ae0 100644 > --- a/drivers/media/v4l2-core/v4l2-fwnode.c > +++ b/drivers/media/v4l2-core/v4l2-fwnode.c > @@ -15,6 +15,7 @@ > * Author: Guennadi Liakhovetski > */ > #include > +#include > #include > #include > #include > @@ -807,16 +808,65 @@ int v4l2_fwnode_connector_add_link(struct fwnode_handle *fwnode, > } > EXPORT_SYMBOL_GPL(v4l2_fwnode_connector_add_link); > > -int v4l2_fwnode_device_parse(struct device *dev, > - struct v4l2_fwnode_device_properties *props) > +static int v4l2_fwnode_device_parse_acpi(struct device *dev, > + struct v4l2_fwnode_device_properties *props) > +{ > + struct acpi_pld_info *pld; > + int ret = 0; > + > + if (!is_acpi_device_node(dev_fwnode(dev))) > + return 0; > + > + if (!acpi_get_physical_device_location(ACPI_HANDLE(dev), &pld)) { > + dev_dbg(dev, "acpi _PLD call failed\n"); > + return 0; > + } > + > + if (props->orientation != V4L2_FWNODE_PROPERTY_UNSET) { "!=" should be "==" here. So that we set it when not set already, rather then leaving it unset when not set already. > + switch (pld->panel) { > + case ACPI_PLD_PANEL_FRONT: > + props->orientation = V4L2_FWNODE_ORIENTATION_FRONT; > + break; > + case ACPI_PLD_PANEL_BACK: > + props->orientation = V4L2_FWNODE_ORIENTATION_BACK; > + break; > + case ACPI_PLD_PANEL_TOP: > + case ACPI_PLD_PANEL_LEFT: > + case ACPI_PLD_PANEL_RIGHT: > + case ACPI_PLD_PANEL_UNKNOWN: > + props->orientation = V4L2_FWNODE_ORIENTATION_EXTERNAL; > + break; > + default: > + dev_dbg(dev, "Unknown _PLD panel val %d\n", pld->panel); > + ret = -EINVAL; > + goto done; > + } > + } > + > + if (props->rotation != V4L2_FWNODE_PROPERTY_UNSET) { Same here. > + switch (pld->rotation) { > + case 0 ... 7: > + props->rotation = pld->rotation * 45; > + break; > + default: > + dev_dbg(dev, "Unknown _PLD rotation val %d\n", pld->panel); > + ret = -EINVAL; > + goto done; > + } > + } > + > +done: > + ACPI_FREE(pld); > + return ret; > +} > + > +static int v4l2_fwnode_device_parse_dt(struct device *dev, > + struct v4l2_fwnode_device_properties *props) > { > struct fwnode_handle *fwnode = dev_fwnode(dev); > u32 val; > int ret; > > - memset(props, 0, sizeof(*props)); > - > - props->orientation = V4L2_FWNODE_PROPERTY_UNSET; > ret = fwnode_property_read_u32(fwnode, "orientation", &val); > if (!ret) { > switch (val) { > @@ -833,7 +883,6 @@ int v4l2_fwnode_device_parse(struct device *dev, > dev_dbg(dev, "device orientation: %u\n", val); > } > > - props->rotation = V4L2_FWNODE_PROPERTY_UNSET; > ret = fwnode_property_read_u32(fwnode, "rotation", &val); > if (!ret) { > if (val >= 360) { > @@ -847,6 +896,30 @@ int v4l2_fwnode_device_parse(struct device *dev, > > return 0; > } > + > +int v4l2_fwnode_device_parse(struct device *dev, > + struct v4l2_fwnode_device_properties *props) > +{ > + int ret; > + > + memset(props, 0, sizeof(*props)); > + > + props->orientation = V4L2_FWNODE_PROPERTY_UNSET; > + props->rotation = V4L2_FWNODE_PROPERTY_UNSET; > + > + /* Start by looking into swnodes and dt. */ > + ret = v4l2_fwnode_device_parse_dt(dev, props); > + if (ret) > + return ret; > + > + /* Orientation and rotation found!, we are ready. */ > + if (props->orientation != V4L2_FWNODE_PROPERTY_UNSET && > + props->rotation != V4L2_FWNODE_PROPERTY_UNSET) > + return 0; As Sakari set, this can be dropped, with the 2 checks above fixed to be == v4l2_fwnode_device_parse_acpi() will become a no-op in this case. With these things fixed: Reviewed-by: Hans de Goede Regards, Hans > + > + /* Let's check the acpi table. */ > + return v4l2_fwnode_device_parse_acpi(dev, props); > +} > EXPORT_SYMBOL_GPL(v4l2_fwnode_device_parse); > > /* >