From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cstnet.cn (smtp84.cstnet.cn [159.226.251.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 430801DF26E; Fri, 10 Oct 2025 06:13:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.84 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760076834; cv=none; b=dEjLXIZ675hY8KYSqzm+rqji9thE7wud/bUgNEI2gF3KZMihwfEQtyyL04Qx1Ro9/sVZhwXBFLtBolBkr0BYTEJBO/Tv5qmcnngtbBhLcqbDnMpJBwRPMebJzF36/vVFHJudcx3dESGviYPJnq9pDolFmnU3URYADAEexzjZ5iU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760076834; c=relaxed/simple; bh=8lRFCfq0asVD86BsvSVEeZIEvT5MHwfBVWvl4XWy4Ig=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ohtmWDiF/dNk/N8DdQHqcATVD7y0AaDJrm4ZAdDBJRWAI41zA+SJwP2cA712cCHMMTRFuv8II70rA+TnJT8OaA5jPetDCZ2XgVa56DfApfb1IHTmlqhlchH9r3T06JWA64GRB5eug8JbO5IMMXCL+B0m1numgHx3UYqCCQiah9U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from [192.168.0.104] (unknown [114.241.81.247]) by APP-05 (Coremail) with SMTP id zQCowACnRhALpOho_rxjDQ--.13259S2; Fri, 10 Oct 2025 14:13:31 +0800 (CST) Message-ID: Date: Fri, 10 Oct 2025 14:13:31 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/5] riscv: dts: spacemit: add Ethernet support for MusePi Pro To: Troy Mitchell , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yangyu Chen Cc: devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org References: <20251010-k1-musepi-pro-dts-v2-0-6e1b491f6f3e@linux.spacemit.com> <20251010-k1-musepi-pro-dts-v2-5-6e1b491f6f3e@linux.spacemit.com> Content-Language: en-US From: Vivian Wang In-Reply-To: <20251010-k1-musepi-pro-dts-v2-5-6e1b491f6f3e@linux.spacemit.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CM-TRANSID:zQCowACnRhALpOho_rxjDQ--.13259S2 X-Coremail-Antispam: 1UD129KBjvJXoW7KFy7Wr1rtw13JFy7uw43GFg_yoW8WFy5pF Z7urs3GwnrKr4fKr1ava17u3WfJaykXa1YgasFkr1DJrsxXry5C3s5t3WakF1UZFyrG340 vr18Wa1xur4qqr7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvvb7Iv0xC_Kw4lb4IE77IF4wAFF20E14v26r4j6ryUM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I 8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI 64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8Jw Am72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lFIxGxcIEc7CjxVA2Y2ka0xkIwI1l c7CjxVAaw2AFwI0_Jw0_GFyl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr 1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE 14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7 IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E 87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73Uj IFyTuYvjxUqiFxDUUUU X-CM-SenderInfo: pzdqw2pxlnt03j6l2u1dvotugofq/ On 10/10/25 09:56, Troy Mitchell wrote: > MusePi Pro features a single RGMII Ethernet port with > PHY reset controlled by GPIO. > > Signed-off-by: Troy Mitchell > --- > arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts b/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts > index 89a35914710bfd15c6ad27cd8d0de7ccf62e2309..e9a53dc7a417117c82f3e467677290bdaeffc845 100644 > --- a/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts > +++ b/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts > @@ -47,6 +47,29 @@ &pdma { > status = "okay"; > }; > > +ð0 { For node orders in board DTS for SpacemiT devices, usually we follow node name order because there's no unit address to go off of here, so for what we have here it should be emmc, eth0, pdma, uart. See e.g. arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts and previous discussion [1]. Also, personally I think it would be fine to just add the whole k1-musepi-pro.dts in the same patch instead of splitting it up like this. I feel it would be easier to manage this way. For previous devices these nodes have been added piecemeal mostly because the drivers were being developed in parallel, but if you're going to base this on v6.18-rc1 there shouldn't be dependency problems. Maybe Yixun can chime in about this as well. Thanks, Vivian "dramforever" Wang [1]: https://lore.kernel.org/linux-riscv/CAH1PCMa35n4dnJ94-EHGrJyU3kztQYO8_v2CkD=rid466zv3+A@mail.gmail.com