From: "Nuno Sá" <noname.nuno@gmail.com>
To: Angelo Dureghello <adureghello@baylibre.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Nuno Sa <nuno.sa@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Olivier Moysan <olivier.moysan@foss.st.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, dletchner@baylibre.com,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v5 02/10] iio: dac: adi-axi-dac: update register names
Date: Thu, 10 Oct 2024 14:59:21 +0200 [thread overview]
Message-ID: <a02f256c54089da4faa3ee1807c01b9cb6e70bc6.camel@gmail.com> (raw)
In-Reply-To: <20241008-wip-bl-ad3552r-axi-v0-iio-testing-v5-2-3d410944a63d@baylibre.com>
On Tue, 2024-10-08 at 17:43 +0200, Angelo Dureghello wrote:
> From: Angelo Dureghello <adureghello@baylibre.com>
>
> Non functional, readability change.
>
> Update register names so that register bitfields can be more easily
> linked to the register name.
>
> Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
> ---
I don't fully agree that this is so much better that's worth the churn...
From a quick a look I saw (I think) some defines where _REG seems to be missing.
Those is fine to change for consistency but I don't really seeing the big
benefit in changing them all.
(Sorry for only complaining in v5 about this...)
- Nuno Sá
next prev parent reply other threads:[~2024-10-10 12:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 15:43 [PATCH v5 00/10] iio: add support for the ad3552r AXI DAC IP Angelo Dureghello
2024-10-08 15:43 ` [PATCH v5 01/10] iio: dac: adi-axi-dac: fix wrong register bitfield Angelo Dureghello
2024-10-12 13:45 ` Jonathan Cameron
2024-10-08 15:43 ` [PATCH v5 02/10] iio: dac: adi-axi-dac: update register names Angelo Dureghello
2024-10-10 12:59 ` Nuno Sá [this message]
2024-10-10 17:52 ` Angelo Dureghello
2024-10-11 6:47 ` Nuno Sá
2024-10-12 13:50 ` Jonathan Cameron
2024-10-12 13:46 ` Jonathan Cameron
2024-10-08 15:43 ` [PATCH v5 03/10] dt-bindings: iio: dac: ad3552r: add iio backend support Angelo Dureghello
2024-10-08 15:43 ` [PATCH v5 04/10] dt-bindings: iio: dac: adi-axi-dac: add ad3552r axi variant Angelo Dureghello
2024-10-08 17:22 ` Rob Herring (Arm)
2024-10-12 13:43 ` Jonathan Cameron
2024-10-12 13:49 ` Jonathan Cameron
2024-10-08 15:43 ` [PATCH v5 05/10] iio: backend: extend features Angelo Dureghello
2024-10-10 13:06 ` Nuno Sá
2024-10-08 15:43 ` [PATCH v5 06/10] iio: dac: adi-axi-dac: " Angelo Dureghello
2024-10-10 13:20 ` Nuno Sá
2024-10-11 8:06 ` Angelo Dureghello
2024-10-08 15:43 ` [PATCH v5 07/10] iio: dac: ad3552r: changes to use FIELD_PREP Angelo Dureghello
2024-10-08 15:43 ` [PATCH v5 08/10] iio: dac: ad3552r: extract common code (no changes in behavior intended) Angelo Dureghello
2024-10-08 15:43 ` [PATCH v5 09/10] iio: dac: ad3552r: add high-speed platform driver Angelo Dureghello
2024-10-12 14:07 ` Jonathan Cameron
2024-10-08 15:43 ` [PATCH v5 10/10] iio: dac: adi-axi-dac: add registering of child fdt node Angelo Dureghello
2024-10-10 13:51 ` Nuno Sá
2024-10-11 12:31 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a02f256c54089da4faa3ee1807c01b9cb6e70bc6.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=adureghello@baylibre.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dletchner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).