devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Marek Vasut <marex@denx.de>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: lcdif: Add optional power-domain
Date: Thu, 8 Dec 2022 09:25:31 +0100	[thread overview]
Message-ID: <a033d9a3-4bee-d749-9bd9-24a419398d0b@linaro.org> (raw)
In-Reply-To: <1839665.tdWV9SEqCh@steina-w>

On 08/12/2022 06:59, Alexander Stein wrote:
> Am Mittwoch, 7. Dezember 2022, 17:00:22 CET schrieb Marek Vasut:
>> On 12/7/22 16:14, Alexander Stein wrote:
>>> i.MX8MP requires a power-domain for this peripheral to use. Add it as
>>> an optional property.
>>>
>>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>>> ---
>>>
>>>   Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 3 +++
>>>   1 file changed, 3 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>> b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index
>>> 793e8eccf8b8b..9d9fb5ad587c2 100644
>>> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
>>>
>>> @@ -52,6 +52,9 @@ properties:
>>>     interrupts:
>>>       maxItems: 1
>>>
>>> +  power-domains:
>>> +    maxItems: 1
>>> +
>>>
>>>     port:
>>>       $ref: /schemas/graph.yaml#/properties/port
>>>       description: The LCDIF output port
>>
>> Should this be required on mx8mp then ?
> 
> I'm hesitating to add a required property later on. But I'm okay with both.
> Rob, Krzysztof: Any preference here? Shall power-domains be made required for 
> fsl,imx8mp-lcdif only?

I don't know. That's not the question to us, but to someone who knows
the hardware/datasheet.

Best regards,
Krzysztof


  reply	other threads:[~2022-12-08  8:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-07 15:13 [PATCH 1/2] dt-bindings: lcdif: Fix clock constraints for imx8mp Alexander Stein
2022-12-07 15:14 ` [PATCH 2/2] dt-bindings: lcdif: Add optional power-domain Alexander Stein
2022-12-07 16:00   ` Marek Vasut
2022-12-08  5:59     ` Alexander Stein
2022-12-08  8:25       ` Krzysztof Kozlowski [this message]
2022-12-08  8:50         ` Alexander Stein
2022-12-08  8:57           ` Krzysztof Kozlowski
2022-12-07 17:44   ` Rob Herring
2022-12-07 15:59 ` [PATCH 1/2] dt-bindings: lcdif: Fix clock constraints for imx8mp Marek Vasut
2022-12-08  6:31   ` Alexander Stein
2022-12-08 13:25     ` Marek Vasut
2022-12-07 17:44 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a033d9a3-4bee-d749-9bd9-24a419398d0b@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=airlied@gmail.com \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=marex@denx.de \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).