From: Krzysztof Kozlowski <krzk@kernel.org>
To: weifu wu <wwfu06@163.com>,
andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org
Cc: krzk+dt@kernel.org, conor+dt@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: arm: qcom: add Acer Swift SFA14-11
Date: Wed, 21 Jan 2026 12:48:49 +0100 [thread overview]
Message-ID: <a052cadc-2617-4e8d-b814-7a70bdcb9391@kernel.org> (raw)
In-Reply-To: <20260121112721.2981491-2-wwfu06@163.com>
On 21/01/2026 12:27, weifu wu wrote:
> Add DT binding documentation for Acer Swift SFA14-11 laptop based on Qualcomm X1E78100 SoC.
Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>
> This introduces a new compatible string for the Acer Swift SFA14-11 board.
Nothing here explains why you think this is compatible with Lenovo T14s.
I really doubt that Acer laptop is compatible, but if you have proper
claims please always write them in commit msg.
>
> dt_binding_check and dtbs_check passed without errors
Drop, not relevant. This is obvious. Why git history should store
information that you build your code?
>
> Signed-off-by: weifu wu <wwfu06@163.com>
> ---
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-21 11:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 11:27 [PATCH v3 0/2] arm64: dts: qcom: add Acer Swift SFA14-11 support weifu wu
2026-01-21 11:27 ` [PATCH v3 1/2] dt-bindings: arm: qcom: add Acer Swift SFA14-11 weifu wu
2026-01-21 11:48 ` Krzysztof Kozlowski [this message]
2026-01-28 11:55 ` Konrad Dybcio
2026-01-28 13:19 ` Konrad Dybcio
2026-01-21 11:27 ` [PATCH v3 2/2] arm64: dts: qcom: add Acer Swift SFA14-11 device tree weifu wu
2026-01-21 11:50 ` Krzysztof Kozlowski
2026-01-28 12:25 ` Konrad Dybcio
2026-01-28 14:05 ` wwf
2026-02-03 11:02 ` Konrad Dybcio
2026-02-05 10:13 ` wwf
2026-02-17 15:15 ` Konrad Dybcio
2026-01-21 11:52 ` [PATCH v3 0/2] arm64: dts: qcom: add Acer Swift SFA14-11 support Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a052cadc-2617-4e8d-b814-7a70bdcb9391@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wwfu06@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox