From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 419321DA23; Wed, 15 Apr 2026 15:53:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776268433; cv=none; b=cf86sWlzs29y2R1D2J8EgiVeSN2S57NteMcLnlOm6kr8JIYBN92uhjWG5GPjHJqQ6Snu01QSfw4B8WlitNRMJlBJzTZieW0S/TCqmUdCbpJUx26v0t2B4ZDQdLvHPVrd0w3jYS9NHBXmkTFnfQVpKIkd4sPNv7/z7X5s+YqUC48= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776268433; c=relaxed/simple; bh=Us7yUv36VR/pQ2jT+9Hva+0cXXCK2Pqu3CcrJ7SAPWg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Wrk9uMeLzjeULtglsNXNYq7gifmfHJ5KqqyWmi5FAde+rPzwKPaBFt1JWBaoxKjf7SqxC+J/mdUnCo5OLrpjnpdD5/0Drq/JlG0VdUB6HAuPX1oP65xzGn+2jcI6i8xo2rg3b5XWh0O8FNeIaiHM3gHoArLJEtdi+4bqBDvIowY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DjIbpc+t; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DjIbpc+t" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C8E2C19424; Wed, 15 Apr 2026 15:53:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776268432; bh=Us7yUv36VR/pQ2jT+9Hva+0cXXCK2Pqu3CcrJ7SAPWg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=DjIbpc+tT05ZnG96Uo1tahGpZmjWGE7DLk7/a5R1L8t3v7L3KqoiPNxQbrTzSaCaw +Re1HIH2Qfrf5UBHmdjAU1mLML0jBk1wkXG3hfTFTFfdDOk5/BMNOTxKZd+/oyX1t2 VOeNhfWtSRO7NkPCesaWVvvzpMJiPW3Gvt0LAItU1sHufnLVsTXxgD4Pgzti6syvQb BM+EpmgUnCgmWTIwgYuDCsGqDadn10dYeJLkglEpErZ2V6BJszkcSHm3uncIi/kSbk bINYh5yegwd2Z6VtM0cksuVApTB7ascyWp0CvIsXaqBmzzYse43zE93a8ah/rP4VLr PSPxGkI8/gZbg== Message-ID: Date: Wed, 15 Apr 2026 17:53:47 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v2 00/11] Add support for AUDIN driver in Amlogic GXBB To: Jerome Brunet , Valerio Setti Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org References: <20260411-audin-rfc-v2-0-4c8a6ec5fcab@baylibre.com> <1jh5pcs2gw.fsf@starbuckisacylon.baylibre.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <1jh5pcs2gw.fsf@starbuckisacylon.baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 15/04/2026 16:49, Jerome Brunet wrote: > On sam. 11 avril 2026 at 16:57, Valerio Setti wrote: > >> This series adds support for I2S audio input (AUDIN) on the Amlogic GXBB >> platform. >> >> It has been largely reshaped compared to what proposed in v1. Instead of >> adding an HACK commit to allow AIU to export its clock so that also >> AUDIN can control it, now the design closely follows what was implemented >> in the Meson AXG platform. "aiu-encoder-i2s" becomes the shared interface >> for playback/capture and it controls pins and clocks; data formatting >> is implemented in formatters which are named "aiu-formatter-i2s" and >> "audin-decoder-i2s" [1]. >> Formatters are DAPM widgets which are dynamically attached/detached to >> the streams when the latters starts/stop, respectively. >> >> As of now only I2S input is supported, because it's the only one >> I could physically test in my setup, but other input sources (ex: SPDIF) >> are also allowed according to the SOC's manual and can be added in the >> future. >> This series was tested on an OdroidC2 board (Amlogic S905 SOC) with an >> NXP SGTL5000 codec connected to its I2S input port. >> >> Since this work brings GX platform very close to the AXG one, once this >> series is accepted, follow up work will be done in order to unify >> GX and AXG formatters so as to minimize the number of implementations. >> >> The series a bit long and it includes changes to drivers, dt-bindings and >> device-tree. Of course this only happens because this is an RFC and I >> wanted to give a full overview of what will be the final design. If no >> objection is raised, this patch series will be split into 3: one for >> reshaping AIU and introducing formatters, one to add AUDIN driver and its >> dt-bindings, one for the device-tree changes. >> >> [1]: Different naming for the aiu part is related to the fact that >> "aiu-encoder-i2s" is already used for the interface and the goal >> of this series was to introduce the minimum amount of changes that allow >> I2S capture to work. Renaming can be implemented in the future as follow up >> activity. > > Thanks a lot for this awesome work Valerio. I know this was a lot of > effort. With Mark and Krzysztof comments addressed > My comments are still unanswered. One of the devices looks like artificially split from some other, because one word register is not a device. Best regards, Krzysztof