From: "Andreas Färber" <afaerber@suse.de>
To: "Andrew Lunn" <andrew@lunn.ch>, "Marek Behún" <kabel@kernel.org>
Cc: "Gregory CLEMENT" <gregory.clement@bootlin.com>,
arm@kernel.org, "Uwe Kleine-König" <uwe@kleine-koenig.org>,
"Jason Cooper" <jason@lakedaemon.net>,
"Rob Herring" <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH mvebu-dt 3/6] ARM: dts: turris-omnia: describe ethernet-phy interrupt
Date: Sat, 14 Nov 2020 22:20:38 +0100 [thread overview]
Message-ID: <a060d0fe-a10f-de9f-bc21-7b7ec8da5f86@suse.de> (raw)
In-Reply-To: <20201114171639.GO1456319@lunn.ch>
On 14.11.20 18:16, Andrew Lunn wrote:
> On Sat, Nov 14, 2020 at 05:49:28PM +0100, Marek Behún wrote:
>> On Sat, 14 Nov 2020 17:04:06 +0100
>> Marek Behún <kabel@kernel.org> wrote:
>>
>>> + interrupt-parent = <&pcawan>;
>>> + interrupt = <7 IRQ_TYPE_LEVEL_LOW>;
>>
>> Also we need to use IRQ_TYPE_EDGE_FALLING. The gpio-pca953x driver does
>> not support IRQ_TYPE_LEVEL_LOW...
>
> Please check the datasheet for the PHY. I expect you will find it is
> level triggering, not edge. So you can miss interrupts, and have the
> wrong state.
I can confirm that neither rising nor falling had worked for me, so I
reverted such changes again. I did not look into pca953x code myself.
Regards,
Andreas
P.S. Was LAKML intentionally omitted from CC?
--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
next prev parent reply other threads:[~2020-11-14 21:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 16:04 [PATCH mvebu-dt 0/6] Turris Omnia device-tree changes Marek Behún
2020-11-14 16:04 ` [PATCH mvebu-dt 1/6] ARM: dts: turris-omnia: enable HW buffer management Marek Behún
2020-11-14 16:04 ` [PATCH mvebu-dt 2/6] ARM: dts: turris-omnia: add comphy handle to eth2 Marek Behún
2020-11-14 16:26 ` Andrew Lunn
2020-11-14 16:04 ` [PATCH mvebu-dt 3/6] ARM: dts: turris-omnia: describe ethernet-phy interrupt Marek Behún
2020-11-14 16:34 ` Andrew Lunn
2020-11-14 16:52 ` Marek Behún
2020-11-14 16:40 ` Marek Behún
2020-11-14 16:49 ` Marek Behún
2020-11-14 17:16 ` Andrew Lunn
2020-11-14 17:42 ` Marek Behún
2020-11-14 17:47 ` Marek Behun
2020-11-14 20:16 ` Andrew Lunn
2020-11-14 20:39 ` Marek Behun
2020-11-14 21:20 ` Andreas Färber [this message]
2020-11-14 23:32 ` Marek Behún
2020-11-14 16:04 ` [PATCH mvebu-dt 4/6] ARM: dts: turris-omnia: add SFP node Marek Behún
2020-11-14 16:36 ` Andrew Lunn
2020-11-14 16:04 ` [PATCH mvebu-dt 5/6] ARM: dts: turris-omnia: add LED controller node Marek Behún
2020-11-14 16:04 ` [PATCH mvebu-dt 6/6] ARM: dts: turris-omnia: update ethernet-phy node and handle name Marek Behún
2020-11-14 16:37 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a060d0fe-a10f-de9f-bc21-7b7ec8da5f86@suse.de \
--to=afaerber@suse.de \
--cc=andrew@lunn.ch \
--cc=arm@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=kabel@kernel.org \
--cc=robh+dt@kernel.org \
--cc=uwe@kleine-koenig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).