From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B4B1C5519F for ; Sat, 14 Nov 2020 21:20:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 412822242C for ; Sat, 14 Nov 2020 21:20:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726265AbgKNVUk (ORCPT ); Sat, 14 Nov 2020 16:20:40 -0500 Received: from mx2.suse.de ([195.135.220.15]:50868 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726230AbgKNVUk (ORCPT ); Sat, 14 Nov 2020 16:20:40 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 82F54ABDE; Sat, 14 Nov 2020 21:20:39 +0000 (UTC) Subject: Re: [PATCH mvebu-dt 3/6] ARM: dts: turris-omnia: describe ethernet-phy interrupt To: Andrew Lunn , =?UTF-8?Q?Marek_Beh=c3=ban?= Cc: Gregory CLEMENT , arm@kernel.org, =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Jason Cooper , Rob Herring , devicetree@vger.kernel.org References: <20201114160409.19670-1-kabel@kernel.org> <20201114160409.19670-4-kabel@kernel.org> <20201114174928.5ab4f8ae@kernel.org> <20201114171639.GO1456319@lunn.ch> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Software Solutions Germany GmbH Message-ID: Date: Sat, 14 Nov 2020 22:20:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201114171639.GO1456319@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14.11.20 18:16, Andrew Lunn wrote: > On Sat, Nov 14, 2020 at 05:49:28PM +0100, Marek Behún wrote: >> On Sat, 14 Nov 2020 17:04:06 +0100 >> Marek Behún wrote: >> >>> + interrupt-parent = <&pcawan>; >>> + interrupt = <7 IRQ_TYPE_LEVEL_LOW>; >> >> Also we need to use IRQ_TYPE_EDGE_FALLING. The gpio-pca953x driver does >> not support IRQ_TYPE_LEVEL_LOW... > > Please check the datasheet for the PHY. I expect you will find it is > level triggering, not edge. So you can miss interrupts, and have the > wrong state. I can confirm that neither rising nor falling had worked for me, so I reverted such changes again. I did not look into pca953x code myself. Regards, Andreas P.S. Was LAKML intentionally omitted from CC? -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg)