From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 735924CB5B for ; Wed, 21 Feb 2024 14:31:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708525903; cv=none; b=q9RFQPF9u6HHRqNGgcs5AN5Rf8gVf/nFIddXh++NMeVC6TpDqCinfSDx4cAOy5SuwvssGaWin3EEvln/8tFEDNZ7FtCvEEDKLIiaFUbVHYzj3TPL80k1QC1sa41wiwoKphkHfGce5TW1joFqQA2fj27mBxLqT1tgzXVt1P7+80o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708525903; c=relaxed/simple; bh=tIlda+yBAO+nKMsxQJQvIb26CRGsj/VptIeKeX7mTUc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Qj3pfJO0ovCVitgEz0FvbBuN17f4J1ZjdYkNnMbLYXGTh3lGUVpJAM6Fzn928oqY+Pay43H+hUgLs4JrigJIIN4lqtEuMIQYePfXgPL35MCwDPS4HPS+L7AsLRMCmHidiaQ+ZGrPXR7CwFWomq5Lar5JEwF4U5I/TPKKw7vB17E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yS9l3byX; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yS9l3byX" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5648d92919dso1125224a12.1 for ; Wed, 21 Feb 2024 06:31:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708525900; x=1709130700; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=z2JdI3YAxaGTmA0HoW3eMpz5feqBHWJQ7MSJAU6hfHw=; b=yS9l3byXDk2MoaPQVWeHGqrSgGl4Ff/C2guYaaKDfPe0Brn0+T+jK946Hu6UFewG+k Yd4gbdZe4c5okupyNMcrTF1ydxVuEZgVW3TKJzlAohJW2VF3o28+4MSqhkcYN/ceqzgJ kL3PnnCkM3JkEIpaeSFlV4fMR1cDcLXjkIwMBs2URXFlcwW5IEqlpeteklwMaskFffqn WOM+T5MZD0zzR7HgRCV/kcCipG82fIUgfwnpYlYisLaddgkfAt9zANXhUZdIblNO9rtV PLSQqAvE5QiX4slAPdW+DEW+1gzsOGWm25B0XQVedPisTatSbmuSwUmn/WzOzy2viumK SwkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708525900; x=1709130700; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=z2JdI3YAxaGTmA0HoW3eMpz5feqBHWJQ7MSJAU6hfHw=; b=Z0+I+xQrMKsEZrDLt1pNGcgxWKun2b5bRDcUrbWBfNAPMqozg+CVtxBnIsRcCwFXTO 7aBbuflOweHzImxsrT96x2zM6eEg5nQCJNDvJfPXzXdWWQTUzqgHT+OLZAisqzZXTTDI Wn07nrMDANbM99o7qeETH6PuZXXxpnCEQqONDeZgAJpS5ivoMlsUX6XsbjW2q/F0kxST rcBcBm4h5f9JsIs+/1RLGED3OfyUjY8y3Ib25AIipBPn+mU7v+iOPFQB/ckDGrBso2lR GAy/IPwtj6ezjqRaWEE4pXQ83rhwvIR3Bf0T69iI3gd3lRtDtQ1W7cSO4dAeDviL4GKP 4u/w== X-Forwarded-Encrypted: i=1; AJvYcCUVkcsTz6FpCE31JvLy1xenX+iM19jlri7MPhS+9fb6/8485f4N114Z2zwTQxjhit5FThXQVJkxGFjgXXHDWo9FzkzKwe/0f0W7nA== X-Gm-Message-State: AOJu0Yy5bVO3n+6q12F6U8Gl4m9EJTSIssbFTxQC0n31SGsKqBzsRDO1 F4lWy+lkxJiZYCVZx4H6tUJi66wgtHCkeL0m2YRLQIUE0NZ0MB+NmHOywgMOh4Y= X-Google-Smtp-Source: AGHT+IEDJ16WYJiD+UFATfu6RX4YFohZBjzeM38hER/3jaUSl/tHjrnZnyOYfGy86xU3JxF7qtUdgA== X-Received: by 2002:aa7:d343:0:b0:564:5109:25c5 with SMTP id m3-20020aa7d343000000b00564510925c5mr6766060edr.13.1708525899759; Wed, 21 Feb 2024 06:31:39 -0800 (PST) Received: from [192.168.192.135] (078088045141.garwolin.vectranet.pl. [78.88.45.141]) by smtp.gmail.com with ESMTPSA id eo11-20020a056402530b00b00564acce7d31sm1995424edb.45.2024.02.21.06.31.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Feb 2024 06:31:39 -0800 (PST) Message-ID: Date: Wed, 21 Feb 2024 15:31:36 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/3] dt-bindings: PCI: qcom: Add global irq support for SA8775p Content-Language: en-US To: Krzysztof Kozlowski , root , andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, jingoohan1@gmail.com, gustavo.pimentel@synopsys.com, manivannan.sadhasivam@linaro.org, conor+dt@kernel.org, quic_nitegupt@quicinc.com Cc: quic_shazhuss@quicinc.com, quic_ramkri@quicinc.com, quic_nayiluri@quicinc.com, quic_krichai@quicinc.com, quic_vbadigan@quicinc.com, Mrinmay Sarkar , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240221140405.28532-1-root@hu-msarkar-hyd.qualcomm.com> <20240221140405.28532-2-root@hu-msarkar-hyd.qualcomm.com> <08ca89da-d6a1-440c-8347-f2e31222bede@linaro.org> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <08ca89da-d6a1-440c-8347-f2e31222bede@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 21.02.2024 15:28, Krzysztof Kozlowski wrote: > On 21/02/2024 15:04, root wrote: >> From: Mrinmay Sarkar >> >> Add global interrupt support in dt-bindings for SA8775p RC platform. > > What is this global interrupt? Why wasn't it there before? > >> >> Signed-off-by: Mrinmay Sarkar >> --- >> .../devicetree/bindings/pci/qcom,pcie.yaml | 26 +++++++++++++++++-- >> 1 file changed, 24 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> index a93ab3b54066..d86fb63a2d2c 100644 >> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> @@ -63,7 +63,7 @@ properties: >> >> interrupt-names: >> minItems: 1 >> - maxItems: 8 >> + maxItems: 9 >> >> iommu-map: >> minItems: 1 >> @@ -873,8 +873,30 @@ allOf: >> compatible: >> contains: >> enum: >> - - qcom,pcie-msm8996 >> - qcom,pcie-sa8775p >> + then: >> + oneOf: > > No need, drop. Moreover, I think this global irq should be present on all qc platforms Konrad