* Re: [PATCH v6 4/6] dt: bindings: lp8860: Update the bindings to the standard [not found] ` <20171201165613.10358-4-dmurphy-l0cyMroinI0@public.gmane.org> @ 2017-12-03 13:27 ` Jacek Anaszewski 2017-12-04 22:35 ` Rob Herring 0 siblings, 1 reply; 3+ messages in thread From: Jacek Anaszewski @ 2017-12-03 13:27 UTC (permalink / raw) To: Dan Murphy, rpurdie-Fm38FmjxZ/leoWH0uzbU5w, pavel-+ZI9xUNit7I Cc: linux-leds-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Rob Herring, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Dan, On 12/01/2017 05:56 PM, Dan Murphy wrote: > Update the lp8860 dt binding to the LED standard where > the LED should have a child node and also adding a > LED trigger entry. > > Signed-off-by: Dan Murphy <dmurphy-l0cyMroinI0@public.gmane.org> > --- > > v6 - New patch to fix binding documentation > > Documentation/devicetree/bindings/leds/leds-lp8860.txt | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt > index aad38dd94d4b..4cf396de6eba 100644 > --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt > +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt > @@ -12,17 +12,24 @@ Required properties: > - label - Used for naming LEDs > > Optional properties: > - - enable-gpio - gpio pin to enable/disable the device. > - - supply - "vled" - LED supply > + - enable-gpios : gpio pin to enable/disable the device. > + - vled-supply : LED supply > + - label : see Documentation/devicetree/bindings/leds/common.txt > + - linux,default-trigger : (optional) > + see Documentation/devicetree/bindings/leds/common.txt > > Example: > > -leds: leds@6 { > +lp8860@2d { > compatible = "ti,lp8860"; > reg = <0x2d>; > - label = "display_cluster"; > enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>; > vled-supply = <&vbatt>; > + > + backlight: backlight@0 { > + label = "backlight_cluster"; You'll need to change this to: label = "white:backlight_cluster" Please always cc your patches with DT bindings to devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org and related maintainers. > + linux,default-trigger = "backlight"; > + }; > } > > For more product information please see the link below: > -- Best regards, Jacek Anaszewski -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v6 4/6] dt: bindings: lp8860: Update the bindings to the standard 2017-12-03 13:27 ` [PATCH v6 4/6] dt: bindings: lp8860: Update the bindings to the standard Jacek Anaszewski @ 2017-12-04 22:35 ` Rob Herring 2017-12-05 13:06 ` Dan Murphy 0 siblings, 1 reply; 3+ messages in thread From: Rob Herring @ 2017-12-04 22:35 UTC (permalink / raw) To: Jacek Anaszewski Cc: Dan Murphy, rpurdie, pavel, linux-leds, linux-kernel, devicetree@vger.kernel.org On Sun, Dec 03, 2017 at 02:27:20PM +0100, Jacek Anaszewski wrote: > Dan, > > On 12/01/2017 05:56 PM, Dan Murphy wrote: > > Update the lp8860 dt binding to the LED standard where > > the LED should have a child node and also adding a > > LED trigger entry. > > > > Signed-off-by: Dan Murphy <dmurphy@ti.com> > > --- > > > > v6 - New patch to fix binding documentation > > > > Documentation/devicetree/bindings/leds/leds-lp8860.txt | 15 +++++++++++---- > > 1 file changed, 11 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt > > index aad38dd94d4b..4cf396de6eba 100644 > > --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt > > +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt > > @@ -12,17 +12,24 @@ Required properties: > > - label - Used for naming LEDs > > > > Optional properties: > > - - enable-gpio - gpio pin to enable/disable the device. > > - - supply - "vled" - LED supply > > + - enable-gpios : gpio pin to enable/disable the device. > > + - vled-supply : LED supply > > + - label : see Documentation/devicetree/bindings/leds/common.txt > > + - linux,default-trigger : (optional) > > + see Documentation/devicetree/bindings/leds/common.txt > > > > Example: > > > > -leds: leds@6 { > > +lp8860@2d { leds@2d > > compatible = "ti,lp8860"; > > reg = <0x2d>; > > - label = "display_cluster"; > > enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>; > > vled-supply = <&vbatt>; > > + > > + backlight: backlight@0 { unit-address requires a 'reg' property. Building your dts files with W=1 will tell you this. > > + label = "backlight_cluster"; > > You'll need to change this to: > > label = "white:backlight_cluster" > > Please always cc your patches with DT bindings to > devicetree@vger.kernel.org and related maintainers. > > > + linux,default-trigger = "backlight"; > > + }; > > } > > > > For more product information please see the link below: > > > > -- > Best regards, > Jacek Anaszewski ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v6 4/6] dt: bindings: lp8860: Update the bindings to the standard 2017-12-04 22:35 ` Rob Herring @ 2017-12-05 13:06 ` Dan Murphy 0 siblings, 0 replies; 3+ messages in thread From: Dan Murphy @ 2017-12-05 13:06 UTC (permalink / raw) To: Rob Herring, Jacek Anaszewski Cc: rpurdie-Fm38FmjxZ/leoWH0uzbU5w, pavel-+ZI9xUNit7I, linux-leds-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Rob On 12/04/2017 04:35 PM, Rob Herring wrote: > On Sun, Dec 03, 2017 at 02:27:20PM +0100, Jacek Anaszewski wrote: >> Dan, >> >> On 12/01/2017 05:56 PM, Dan Murphy wrote: >>> Update the lp8860 dt binding to the LED standard where >>> the LED should have a child node and also adding a >>> LED trigger entry. >>> >>> Signed-off-by: Dan Murphy <dmurphy-l0cyMroinI0@public.gmane.org> >>> --- >>> >>> v6 - New patch to fix binding documentation >>> >>> Documentation/devicetree/bindings/leds/leds-lp8860.txt | 15 +++++++++++---- >>> 1 file changed, 11 insertions(+), 4 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt >>> index aad38dd94d4b..4cf396de6eba 100644 >>> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt >>> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt >>> @@ -12,17 +12,24 @@ Required properties: >>> - label - Used for naming LEDs >>> >>> Optional properties: >>> - - enable-gpio - gpio pin to enable/disable the device. >>> - - supply - "vled" - LED supply >>> + - enable-gpios : gpio pin to enable/disable the device. >>> + - vled-supply : LED supply >>> + - label : see Documentation/devicetree/bindings/leds/common.txt >>> + - linux,default-trigger : (optional) >>> + see Documentation/devicetree/bindings/leds/common.txt >>> >>> Example: >>> >>> -leds: leds@6 { >>> +lp8860@2d { > > leds@2d Ack > >>> compatible = "ti,lp8860"; >>> reg = <0x2d>; >>> - label = "display_cluster"; >>> enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>; >>> vled-supply = <&vbatt>; >>> + >>> + backlight: backlight@0 { > > unit-address requires a 'reg' property. Building your dts files with W=1 > will tell you this. I will add this. There is so much noise when enabling this option on the dts I missed the warning. Dan <snip> -- ------------------ Dan Murphy -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-05 13:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20171201165613.10358-1-dmurphy@ti.com>
[not found] ` <20171201165613.10358-4-dmurphy@ti.com>
[not found] ` <20171201165613.10358-4-dmurphy-l0cyMroinI0@public.gmane.org>
2017-12-03 13:27 ` [PATCH v6 4/6] dt: bindings: lp8860: Update the bindings to the standard Jacek Anaszewski
2017-12-04 22:35 ` Rob Herring
2017-12-05 13:06 ` Dan Murphy
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).