public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Tony Lindgren <tony@atomide.com>, linux-omap@vger.kernel.org
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
	devicetree@vger.kernel.org, "Arnd Bergmann" <arnd@arndb.de>,
	"Koen Kooi" <koen@dominion.thruhere.net>,
	"Neeraj Dantu" <dantuguf14105@gmail.com>
Subject: Re: [PATCH] ARM: dts: am335x: Replace remaining legacy phy_id with phy-handle
Date: Fri, 28 Sep 2018 16:10:37 -0500	[thread overview]
Message-ID: <a07fa3e0-df8e-b7da-e006-e46818a66a20@ti.com> (raw)
In-Reply-To: <20180928203457.121761-1-tony@atomide.com>



On 09/28/2018 03:34 PM, Tony Lindgren wrote:
> Looks like we still have two instances of phy_handle that did not
> get update by Grygorii's series. Let's replace these too with
> standard phy-handle.
> 
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Grygorii Strashko <grygorii.strashko@ti.com>
> Cc: Koen Kooi <koen@dominion.thruhere.net>
> Cc: Neeraj Dantu <dantuguf14105@gmail.com>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Tony Lindgren <tony@atomide.com>

Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>

> ---
>   arch/arm/boot/dts/am335x-osd3358-sm-red.dts | 6 +++++-
>   arch/arm/boot/dts/am335x-sancloud-bbe.dts   | 6 +++++-
>   2 files changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/am335x-osd3358-sm-red.dts b/arch/arm/boot/dts/am335x-osd3358-sm-red.dts
> --- a/arch/arm/boot/dts/am335x-osd3358-sm-red.dts
> +++ b/arch/arm/boot/dts/am335x-osd3358-sm-red.dts
> @@ -424,7 +424,7 @@
>   };
>   
>   &cpsw_emac0 {
> -	phy_id = <&davinci_mdio>, <4>;
> +	phy-handle = <&ethphy0>;
>   	phy-mode = "rgmii-txid";
>   };
>   
> @@ -441,6 +441,10 @@
>   	pinctrl-0 = <&davinci_mdio_default>;
>   	pinctrl-1 = <&davinci_mdio_sleep>;
>   	status = "okay";
> +
> +	ethphy0: ethernet-phy@4 {
> +		reg = <4>;
> +	};
>   };
>   
>   &mmc1 {
> diff --git a/arch/arm/boot/dts/am335x-sancloud-bbe.dts b/arch/arm/boot/dts/am335x-sancloud-bbe.dts
> --- a/arch/arm/boot/dts/am335x-sancloud-bbe.dts
> +++ b/arch/arm/boot/dts/am335x-sancloud-bbe.dts
> @@ -103,10 +103,14 @@
>   	pinctrl-0 = <&davinci_mdio_default>;
>   	pinctrl-1 = <&davinci_mdio_sleep>;
>   	status = "okay";
> +
> +	ethphy0: ethernet-phy@0 {
> +		reg = <0>;
> +	};
>   };
>   
>   &cpsw_emac0 {
> -	phy_id = <&davinci_mdio>, <0>;
> +	phy-handle = <&ethphy0>;
>   	phy-mode = "rgmii-txid";
>   };
>   
> 

-- 
regards,
-grygorii

  reply	other threads:[~2018-09-29  3:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-28 20:34 [PATCH] ARM: dts: am335x: Replace remaining legacy phy_id with phy-handle Tony Lindgren
2018-09-28 21:10 ` Grygorii Strashko [this message]
2018-09-29 10:01 ` Koen Kooi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a07fa3e0-df8e-b7da-e006-e46818a66a20@ti.com \
    --to=grygorii.strashko@ti.com \
    --cc=arnd@arndb.de \
    --cc=bcousson@baylibre.com \
    --cc=dantuguf14105@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=koen@dominion.thruhere.net \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox