* [PATCH] ARM: dts: am335x: Replace remaining legacy phy_id with phy-handle
@ 2018-09-28 20:34 Tony Lindgren
2018-09-28 21:10 ` Grygorii Strashko
2018-09-29 10:01 ` Koen Kooi
0 siblings, 2 replies; 3+ messages in thread
From: Tony Lindgren @ 2018-09-28 20:34 UTC (permalink / raw)
To: linux-omap
Cc: Benoît Cousson, devicetree, Arnd Bergmann, Grygorii Strashko,
Koen Kooi, Neeraj Dantu
Looks like we still have two instances of phy_handle that did not
get update by Grygorii's series. Let's replace these too with
standard phy-handle.
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Koen Kooi <koen@dominion.thruhere.net>
Cc: Neeraj Dantu <dantuguf14105@gmail.com>
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
arch/arm/boot/dts/am335x-osd3358-sm-red.dts | 6 +++++-
arch/arm/boot/dts/am335x-sancloud-bbe.dts | 6 +++++-
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/am335x-osd3358-sm-red.dts b/arch/arm/boot/dts/am335x-osd3358-sm-red.dts
--- a/arch/arm/boot/dts/am335x-osd3358-sm-red.dts
+++ b/arch/arm/boot/dts/am335x-osd3358-sm-red.dts
@@ -424,7 +424,7 @@
};
&cpsw_emac0 {
- phy_id = <&davinci_mdio>, <4>;
+ phy-handle = <ðphy0>;
phy-mode = "rgmii-txid";
};
@@ -441,6 +441,10 @@
pinctrl-0 = <&davinci_mdio_default>;
pinctrl-1 = <&davinci_mdio_sleep>;
status = "okay";
+
+ ethphy0: ethernet-phy@4 {
+ reg = <4>;
+ };
};
&mmc1 {
diff --git a/arch/arm/boot/dts/am335x-sancloud-bbe.dts b/arch/arm/boot/dts/am335x-sancloud-bbe.dts
--- a/arch/arm/boot/dts/am335x-sancloud-bbe.dts
+++ b/arch/arm/boot/dts/am335x-sancloud-bbe.dts
@@ -103,10 +103,14 @@
pinctrl-0 = <&davinci_mdio_default>;
pinctrl-1 = <&davinci_mdio_sleep>;
status = "okay";
+
+ ethphy0: ethernet-phy@0 {
+ reg = <0>;
+ };
};
&cpsw_emac0 {
- phy_id = <&davinci_mdio>, <0>;
+ phy-handle = <ðphy0>;
phy-mode = "rgmii-txid";
};
--
2.19.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: am335x: Replace remaining legacy phy_id with phy-handle
2018-09-28 20:34 [PATCH] ARM: dts: am335x: Replace remaining legacy phy_id with phy-handle Tony Lindgren
@ 2018-09-28 21:10 ` Grygorii Strashko
2018-09-29 10:01 ` Koen Kooi
1 sibling, 0 replies; 3+ messages in thread
From: Grygorii Strashko @ 2018-09-28 21:10 UTC (permalink / raw)
To: Tony Lindgren, linux-omap
Cc: Benoît Cousson, devicetree, Arnd Bergmann, Koen Kooi,
Neeraj Dantu
On 09/28/2018 03:34 PM, Tony Lindgren wrote:
> Looks like we still have two instances of phy_handle that did not
> get update by Grygorii's series. Let's replace these too with
> standard phy-handle.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Grygorii Strashko <grygorii.strashko@ti.com>
> Cc: Koen Kooi <koen@dominion.thruhere.net>
> Cc: Neeraj Dantu <dantuguf14105@gmail.com>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> arch/arm/boot/dts/am335x-osd3358-sm-red.dts | 6 +++++-
> arch/arm/boot/dts/am335x-sancloud-bbe.dts | 6 +++++-
> 2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am335x-osd3358-sm-red.dts b/arch/arm/boot/dts/am335x-osd3358-sm-red.dts
> --- a/arch/arm/boot/dts/am335x-osd3358-sm-red.dts
> +++ b/arch/arm/boot/dts/am335x-osd3358-sm-red.dts
> @@ -424,7 +424,7 @@
> };
>
> &cpsw_emac0 {
> - phy_id = <&davinci_mdio>, <4>;
> + phy-handle = <ðphy0>;
> phy-mode = "rgmii-txid";
> };
>
> @@ -441,6 +441,10 @@
> pinctrl-0 = <&davinci_mdio_default>;
> pinctrl-1 = <&davinci_mdio_sleep>;
> status = "okay";
> +
> + ethphy0: ethernet-phy@4 {
> + reg = <4>;
> + };
> };
>
> &mmc1 {
> diff --git a/arch/arm/boot/dts/am335x-sancloud-bbe.dts b/arch/arm/boot/dts/am335x-sancloud-bbe.dts
> --- a/arch/arm/boot/dts/am335x-sancloud-bbe.dts
> +++ b/arch/arm/boot/dts/am335x-sancloud-bbe.dts
> @@ -103,10 +103,14 @@
> pinctrl-0 = <&davinci_mdio_default>;
> pinctrl-1 = <&davinci_mdio_sleep>;
> status = "okay";
> +
> + ethphy0: ethernet-phy@0 {
> + reg = <0>;
> + };
> };
>
> &cpsw_emac0 {
> - phy_id = <&davinci_mdio>, <0>;
> + phy-handle = <ðphy0>;
> phy-mode = "rgmii-txid";
> };
>
>
--
regards,
-grygorii
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: am335x: Replace remaining legacy phy_id with phy-handle
2018-09-28 20:34 [PATCH] ARM: dts: am335x: Replace remaining legacy phy_id with phy-handle Tony Lindgren
2018-09-28 21:10 ` Grygorii Strashko
@ 2018-09-29 10:01 ` Koen Kooi
1 sibling, 0 replies; 3+ messages in thread
From: Koen Kooi @ 2018-09-29 10:01 UTC (permalink / raw)
To: Tony Lindgren
Cc: linux-omap, Benoît Cousson, devicetree, Arnd Bergmann,
Grygorii Strashko, Neeraj Dantu
> Op 28 sep. 2018, om 22:34 heeft Tony Lindgren <tony@atomide.com> het volgende geschreven:
>
> Looks like we still have two instances of phy_handle that did not
> get update by Grygorii's series. Let's replace these too with
> standard phy-handle.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Grygorii Strashko <grygorii.strashko@ti.com>
> Cc: Koen Kooi <koen@dominion.thruhere.net>
> Cc: Neeraj Dantu <dantuguf14105@gmail.com>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Thanks for taking care of this!
Acked-by: Koen Kooi <koen@dominion.thruhere.net>
> ---
> arch/arm/boot/dts/am335x-osd3358-sm-red.dts | 6 +++++-
> arch/arm/boot/dts/am335x-sancloud-bbe.dts | 6 +++++-
> 2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am335x-osd3358-sm-red.dts b/arch/arm/boot/dts/am335x-osd3358-sm-red.dts
> --- a/arch/arm/boot/dts/am335x-osd3358-sm-red.dts
> +++ b/arch/arm/boot/dts/am335x-osd3358-sm-red.dts
> @@ -424,7 +424,7 @@
> };
>
> &cpsw_emac0 {
> - phy_id = <&davinci_mdio>, <4>;
> + phy-handle = <ðphy0>;
> phy-mode = "rgmii-txid";
> };
>
> @@ -441,6 +441,10 @@
> pinctrl-0 = <&davinci_mdio_default>;
> pinctrl-1 = <&davinci_mdio_sleep>;
> status = "okay";
> +
> + ethphy0: ethernet-phy@4 {
> + reg = <4>;
> + };
> };
>
> &mmc1 {
> diff --git a/arch/arm/boot/dts/am335x-sancloud-bbe.dts b/arch/arm/boot/dts/am335x-sancloud-bbe.dts
> --- a/arch/arm/boot/dts/am335x-sancloud-bbe.dts
> +++ b/arch/arm/boot/dts/am335x-sancloud-bbe.dts
> @@ -103,10 +103,14 @@
> pinctrl-0 = <&davinci_mdio_default>;
> pinctrl-1 = <&davinci_mdio_sleep>;
> status = "okay";
> +
> + ethphy0: ethernet-phy@0 {
> + reg = <0>;
> + };
> };
>
> &cpsw_emac0 {
> - phy_id = <&davinci_mdio>, <0>;
> + phy-handle = <ðphy0>;
> phy-mode = "rgmii-txid";
> };
>
> --
> 2.19.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-29 16:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-28 20:34 [PATCH] ARM: dts: am335x: Replace remaining legacy phy_id with phy-handle Tony Lindgren
2018-09-28 21:10 ` Grygorii Strashko
2018-09-29 10:01 ` Koen Kooi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox