[PATCH 1/2] ARM: dts: Add the CLCD controller to Cygnus.

[PATCH 1/2] ARM: dts: Add the CLCD controller to Cygnus.

[Eric Anholt]

This doesn't yet enable it on any particular platform, as we still
need a panel driver for bcm911360_entphn.

Signed-off-by: Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>
---

These bits are just carving off a little bit of my 911360_entphn panel
series, to reduce conflicts when rebasing (which I just did for
testing pl111 changes for cygnus regressions).  I'm waiting to get my
current RPi panel driver in before working on the 911360 panel again.

 arch/arm/boot/dts/bcm-cygnus.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
index 7c957ea06c66..74f73ff24aec 100644
--- a/arch/arm/boot/dts/bcm-cygnus.dtsi
+++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
@@ -575,6 +575,16 @@
 			status = "disabled";
 		};
 
+		clcd: clcd@180a0000 {
+			compatible = "arm,pl111", "arm,primecell";
+			reg = <0x180a0000 0x1000>;
+			interrupts = <GIC_SPI 155 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "combined";
+			clocks = <&axi41_clk>, <&apb_clk>;
+			clock-names = "clcdclk", "apb_pclk";
+			status = "disabled";
+		};
+
 		keypad: keypad@180ac000 {
 			compatible = "brcm,bcm-keypad";
 			reg = <0x180ac000 0x14c>;
-- 
2.14.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] ARM: dts: Add the PWM node to Cygnus

[Eric Anholt]

This is connected up to the backlight on 911360_entphn, which we'll
need for a panel driver.  For now, leave the node disabled in the
shared dtsi.

Signed-off-by: Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>
---
 arch/arm/boot/dts/bcm-cygnus.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
index 74f73ff24aec..b9a654d733ae 100644
--- a/arch/arm/boot/dts/bcm-cygnus.dtsi
+++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
@@ -585,6 +585,14 @@
 			status = "disabled";
 		};
 
+		pwm: pwm@180aa500 {
+			compatible = "brcm,kona-pwm";
+			reg = <0x180aa500 0xc4>;
+			#pwm-cells = <3>;
+			clocks = <&asiu_clks BCM_CYGNUS_ASIU_PWM_CLK>;
+			status = "disabled";
+		};
+
 		keypad: keypad@180ac000 {
 			compatible = "brcm,bcm-keypad";
 			reg = <0x180ac000 0x14c>;
-- 
2.14.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] ARM: dts: Add the PWM node to Cygnus

[Scott Branden]

pwm node is correct.


On 17-08-31 11:54 AM, Eric Anholt wrote:
> This is connected up to the backlight on 911360_entphn, which we'll
> need for a panel driver.  For now, leave the node disabled in the
> shared dtsi.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
Acked-by: Scott Branden <scott.branden@broadcom.com>
> ---
>   arch/arm/boot/dts/bcm-cygnus.dtsi | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
> index 74f73ff24aec..b9a654d733ae 100644
> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
> @@ -585,6 +585,14 @@
>   			status = "disabled";
>   		};
>   
> +		pwm: pwm@180aa500 {
> +			compatible = "brcm,kona-pwm";
> +			reg = <0x180aa500 0xc4>;
> +			#pwm-cells = <3>;
> +			clocks = <&asiu_clks BCM_CYGNUS_ASIU_PWM_CLK>;
> +			status = "disabled";
> +		};
> +
>   		keypad: keypad@180ac000 {
>   			compatible = "brcm,bcm-keypad";
>   			reg = <0x180ac000 0x14c>;

Re: [PATCH 2/2] ARM: dts: Add the PWM node to Cygnus

[Florian Fainelli]

On 08/31/2017 01:10 PM, Scott Branden wrote:
> pwm node is correct.
> 
> 
> On 17-08-31 11:54 AM, Eric Anholt wrote:
>> This is connected up to the backlight on 911360_entphn, which we'll
>> need for a panel driver.  For now, leave the node disabled in the
>> shared dtsi.
>>
>> Signed-off-by: Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>
> Acked-by: Scott Branden <scott.branden-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>

Applied to devicetree/next:

https://github.com/Broadcom/stblinux/commit/31807d46f85c4d86ef3b6df9c5a4e69d35f75bc0

>> ---
>>   arch/arm/boot/dts/bcm-cygnus.dtsi | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi
>> b/arch/arm/boot/dts/bcm-cygnus.dtsi
>> index 74f73ff24aec..b9a654d733ae 100644
>> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
>> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
>> @@ -585,6 +585,14 @@
>>               status = "disabled";
>>           };
>>   +        pwm: pwm@180aa500 {
>> +            compatible = "brcm,kona-pwm";
>> +            reg = <0x180aa500 0xc4>;
>> +            #pwm-cells = <3>;
>> +            clocks = <&asiu_clks BCM_CYGNUS_ASIU_PWM_CLK>;
>> +            status = "disabled";
>> +        };
>> +
>>           keypad: keypad@180ac000 {
>>               compatible = "brcm,bcm-keypad";
>>               reg = <0x180ac000 0x14c>;
> 

-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ARM: dts: Add the CLCD controller to Cygnus.

[Scott Branden]

Hi Eric,

mode is correct, location in file needs to be moved.


On 17-08-31 11:54 AM, Eric Anholt wrote:
> This doesn't yet enable it on any particular platform, as we still
> need a panel driver for bcm911360_entphn.
>
> Signed-off-by: Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>
> ---
>
> These bits are just carving off a little bit of my 911360_entphn panel
> series, to reduce conflicts when rebasing (which I just did for
> testing pl111 changes for cygnus regressions).  I'm waiting to get my
> current RPi panel driver in before working on the 911360 panel again.
>
>   arch/arm/boot/dts/bcm-cygnus.dtsi | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
> index 7c957ea06c66..74f73ff24aec 100644
> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
> @@ -575,6 +575,16 @@
>   			status = "disabled";
>   		};
>   
> +		clcd: clcd@180a0000 {
please place in correct address ordered location in file
> +			compatible = "arm,pl111", "arm,primecell";
> +			reg = <0x180a0000 0x1000>;
> +			interrupts = <GIC_SPI 155 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupt-names = "combined";
> +			clocks = <&axi41_clk>, <&apb_clk>;
> +			clock-names = "clcdclk", "apb_pclk";
> +			status = "disabled";
> +		};
> +
>   		keypad: keypad@180ac000 {
>   			compatible = "brcm,bcm-keypad";
>   			reg = <0x180ac000 0x14c>;

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ARM: dts: Add the CLCD controller to Cygnus.

[Florian Fainelli]

On 08/31/2017 01:16 PM, Scott Branden wrote:
> Hi Eric,
> 
> mode is correct, location in file needs to be moved.
> 
> 
> On 17-08-31 11:54 AM, Eric Anholt wrote:
>> This doesn't yet enable it on any particular platform, as we still
>> need a panel driver for bcm911360_entphn.
>>
>> Signed-off-by: Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>
>> ---
>>
>> These bits are just carving off a little bit of my 911360_entphn panel
>> series, to reduce conflicts when rebasing (which I just did for
>> testing pl111 changes for cygnus regressions).  I'm waiting to get my
>> current RPi panel driver in before working on the 911360 panel again.
>>
>>   arch/arm/boot/dts/bcm-cygnus.dtsi | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi
>> b/arch/arm/boot/dts/bcm-cygnus.dtsi
>> index 7c957ea06c66..74f73ff24aec 100644
>> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
>> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
>> @@ -575,6 +575,16 @@
>>               status = "disabled";
>>           };
>>   +        clcd: clcd@180a0000 {
> please place in correct address ordered location in file

I moved it right above the v3d node to keep the nodes ordered by unit
address, please check the result here:

https://github.com/Broadcom/stblinux/commit/4d1e42c6b9d28ce7b74d92258435f9d16834ae75

>> +            compatible = "arm,pl111", "arm,primecell";
>> +            reg = <0x180a0000 0x1000>;
>> +            interrupts = <GIC_SPI 155 IRQ_TYPE_LEVEL_HIGH>;
>> +            interrupt-names = "combined";
>> +            clocks = <&axi41_clk>, <&apb_clk>;
>> +            clock-names = "clcdclk", "apb_pclk";
>> +            status = "disabled";
>> +        };
>> +
>>           keypad: keypad@180ac000 {
>>               compatible = "brcm,bcm-keypad";
>>               reg = <0x180ac000 0x14c>;
> 

-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ARM: dts: Add the CLCD controller to Cygnus.

[Scott Branden]

[-- Attachment #1: Type: text/plain, Size: 1992 bytes --]

Looks good

On Sep 1, 2017 7:10 PM, "Florian Fainelli" <f.fainelli@gmail.com> wrote:



On 08/31/2017 01:16 PM, Scott Branden wrote:
> Hi Eric,
>
> mode is correct, location in file needs to be moved.
>
>
> On 17-08-31 11:54 AM, Eric Anholt wrote:
>> This doesn't yet enable it on any particular platform, as we still
>> need a panel driver for bcm911360_entphn.
>>
>> Signed-off-by: Eric Anholt <eric@anholt.net>
>> ---
>>
>> These bits are just carving off a little bit of my 911360_entphn panel
>> series, to reduce conflicts when rebasing (which I just did for
>> testing pl111 changes for cygnus regressions).  I'm waiting to get my
>> current RPi panel driver in before working on the 911360 panel again.
>>
>>   arch/arm/boot/dts/bcm-cygnus.dtsi | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi
>> b/arch/arm/boot/dts/bcm-cygnus.dtsi
>> index 7c957ea06c66..74f73ff24aec 100644
>> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
>> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
>> @@ -575,6 +575,16 @@
>>               status = "disabled";
>>           };
>>   +        clcd: clcd@180a0000 {
> please place in correct address ordered location in file

I moved it right above the v3d node to keep the nodes ordered by unit
address, please check the result here:

https://github.com/Broadcom/stblinux/commit/4d1e42c6b9d28ce7b74d92258435f9
d16834ae75


With Moved location
Acked-by: Scott Branden <scott.branden@broadcom.com>

>> +            compatible = "arm,pl111", "arm,primecell";
>> +            reg = <0x180a0000 0x1000>;
>> +            interrupts = <GIC_SPI 155 IRQ_TYPE_LEVEL_HIGH>;
>> +            interrupt-names = "combined";
>> +            clocks = <&axi41_clk>, <&apb_clk>;
>> +            clock-names = "clcdclk", "apb_pclk";
>> +            status = "disabled";
>> +        };
>> +
>>           keypad: keypad@180ac000 {
>>               compatible = "brcm,bcm-keypad";
>>               reg = <0x180ac000 0x14c>;
>

--
Florian

[-- Attachment #2: Type: text/html, Size: 3649 bytes --]

Re: [PATCH 1/2] ARM: dts: Add the CLCD controller to Cygnus.

[Florian Fainelli]

On 09/02/2017 08:48 AM, Scott Branden wrote:
> Looks good
> 
> On Sep 1, 2017 7:10 PM, "Florian Fainelli" <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
> <mailto:f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>> wrote:
> 
> 
> 
>     On 08/31/2017 01:16 PM, Scott Branden wrote:
>     > Hi Eric,
>     >
>     > mode is correct, location in file needs to be moved.
>     >
>     >
>     > On 17-08-31 11:54 AM, Eric Anholt wrote:
>     >> This doesn't yet enable it on any particular platform, as we still
>     >> need a panel driver for bcm911360_entphn.
>     >>
>     >> Signed-off-by: Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org <mailto:eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>>
>     >> ---
>     >>
>     >> These bits are just carving off a little bit of my 911360_entphn
>     panel
>     >> series, to reduce conflicts when rebasing (which I just did for
>     >> testing pl111 changes for cygnus regressions).  I'm waiting to get my
>     >> current RPi panel driver in before working on the 911360 panel again.
>     >>
>     >>   arch/arm/boot/dts/bcm-cygnus.dtsi | 10 ++++++++++
>     >>   1 file changed, 10 insertions(+)
>     >>
>     >> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi
>     >> b/arch/arm/boot/dts/bcm-cygnus.dtsi
>     >> index 7c957ea06c66..74f73ff24aec 100644
>     >> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
>     >> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
>     >> @@ -575,6 +575,16 @@
>     >>               status = "disabled";
>     >>           };
>     >>   +        clcd: clcd@180a0000 {
>     > please place in correct address ordered location in file
> 
>     I moved it right above the v3d node to keep the nodes ordered by unit
>     address, please check the result here:
> 
>     https://github.com/Broadcom/stblinux/commit/4d1e42c6b9d28ce7b74d92258435f9d16834ae75
>     <https://github.com/Broadcom/stblinux/commit/4d1e42c6b9d28ce7b74d92258435f9d16834ae75>
> 
> 
> With Moved location
> Acked-by: Scott Branden <scott.branden-dY08KVG/lbpWk0Htik3J/w@public.gmane.org
> <mailto:scott.branden-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>>

Pushed in place with your tag added, thanks!
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html