From: Krzysztof Kozlowski <krzk@kernel.org>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: Sebastian Reichel <sre@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: power: supply: Document Maxim MAX8971 charger
Date: Mon, 3 Mar 2025 09:23:38 +0100 [thread overview]
Message-ID: <a091f085-a7f0-4aaa-997d-cd478764c18a@kernel.org> (raw)
In-Reply-To: <CAPVz0n0KVE8baFyGSgM+0rNfY8+Y2LFZbAhHHzPWTV358gc+Bw@mail.gmail.com>
On 03/03/2025 09:13, Svyatoslav Ryhel wrote:
> пн, 3 бер. 2025 р. о 09:52 Krzysztof Kozlowski <krzk@kernel.org> пише:
>>
>> On 27/02/2025 12:03, Svyatoslav Ryhel wrote:
>>> чт, 27 лют. 2025 р. о 12:45 Krzysztof Kozlowski <krzk@kernel.org> пише:
>>>>
>>>> On Wed, Feb 26, 2025 at 11:36:59AM +0200, Svyatoslav Ryhel wrote:
>>>>> + maxim,fcharge-current-limit-microamp:
>>>>> + description:
>>>>> + Fast-Charge current limit
>>>>> + minimum: 250000
>>>>> + default: 500000
>>>>> + maximum: 1550000
>>>>> +
>>>>> + maxim,fcharge-timer-hours:
>>>>> + description:
>>>>> + Fast-Charge timer in hours. Setting this value 3 and lower or 11 and higher
>>>>> + will disable Fast-Charge timer.
>>>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>>>> + default: 5
>>>>
>>>> You still did not answer why this is board specific. This was rejected
>>>> in the past because of that reason and nothing here changed. Nothing
Where are the arguments to existing/previous decisions?
>>>> will change without detailed explanation, so use other interfaces if you
Again, where is detailed explanation why time is determined per board,
unlike previously agreed that it is not?
>>>> need user-space to configure it (see other drivers, e.g. maxim)
>>>>
>>>
>>> Btw, I have used this awesome example you have provided. Take a look
>>
>> Where did I provide this example?
>>
>
> Its presence in the docs is an example on its no? You have explicitly
> told to check other maxim devices, I did so, they all have similar set
> of convifurations.
Choose rather later or latest, not 12 YO, binding as an example.
>
>>>
>>> https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/power/supply/maxim,max77693.yaml?h=v6.14-rc4
>>
>> I opened it and I do not see anything about time. Please point to
>> specific line.
>>
>> But regardless, how did I propose to use 12 year old binding? Where did
>> I suggest that one?
>>
>>>
>>> Oh, I wonder why it uses so much values which duplicate battery? I
>>> know, it lacks battery, I assume that is why?
>>
>> No. You added to DT something which is not a hardware property, but
>> user-space choice or policy.
>>
>
> It is NOT a user-space choice or policy!
Previous discussions on the lists - since you mention 12 year old
binding, so also discussions 12 years ago - determined that they are
closer to them than board configuration.
I already said - this was rejected in the past - so now I am repeating
myself.
You did not bring any arguments just keep repeating "no", so I suggest
reading previous discussions and coming with arguments against them.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-03 8:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 9:36 [PATCH v2 0/2] power: supply: Add support for Maxim MAX8971 charger Svyatoslav Ryhel
2025-02-26 9:36 ` [PATCH v2 1/2] dt-bindings: power: supply: Document " Svyatoslav Ryhel
2025-02-27 10:45 ` Krzysztof Kozlowski
2025-02-27 10:55 ` Svyatoslav Ryhel
2025-03-03 7:54 ` Krzysztof Kozlowski
2025-03-03 8:11 ` Svyatoslav Ryhel
2025-03-03 8:18 ` Krzysztof Kozlowski
2025-03-03 8:20 ` Svyatoslav Ryhel
2025-03-03 8:24 ` Krzysztof Kozlowski
2025-03-03 8:24 ` Krzysztof Kozlowski
2025-02-27 11:03 ` Svyatoslav Ryhel
2025-03-03 7:52 ` Krzysztof Kozlowski
2025-03-03 8:13 ` Svyatoslav Ryhel
2025-03-03 8:23 ` Krzysztof Kozlowski [this message]
2025-02-26 9:37 ` [PATCH v2 2/2] power: supply: Add support for " Svyatoslav Ryhel
2025-02-27 14:18 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a091f085-a7f0-4aaa-997d-cd478764c18a@kernel.org \
--to=krzk@kernel.org \
--cc=clamor95@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox