* [PATCH] arm64: dts: qcom: msm8939-samsung-a7: Drop internal pull for SD CD
@ 2023-07-23 10:54 Stephan Gerhold
2023-07-26 15:49 ` Konrad Dybcio
2023-07-28 4:08 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Stephan Gerhold @ 2023-07-23 10:54 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Andy Gross, Konrad Dybcio, linux-arm-msm, devicetree,
linux-kernel, Lin, Meng-Bo, Stephan Gerhold
A7 seems to have external pull-up for the SD card chip detect (like
most MSM8916/MSM8939 devices) so drop the internal pull-up. It's not
necessary.
Tested-by: "Lin, Meng-Bo" <linmengbo0689@protonmail.com>
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
---
arch/arm64/boot/dts/qcom/msm8939-samsung-a7.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8939-samsung-a7.dts b/arch/arm64/boot/dts/qcom/msm8939-samsung-a7.dts
index 66e56ac59998..ba652909d162 100644
--- a/arch/arm64/boot/dts/qcom/msm8939-samsung-a7.dts
+++ b/arch/arm64/boot/dts/qcom/msm8939-samsung-a7.dts
@@ -448,7 +448,7 @@ sdc2_cd_default: sdc2-cd-default-state {
pins = "gpio38";
function = "gpio";
drive-strength = <2>;
- bias-pull-up;
+ bias-disable;
};
sensor_i2c_default: sensor-i2c-default-state {
---
base-commit: 34e472f41d9cd04400b80649ce82cfe11fbe135a
change-id: 20230723-a7sdc2cdnopull-3eb4cadf8f1f
Best regards,
--
Stephan Gerhold <stephan@gerhold.net>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: qcom: msm8939-samsung-a7: Drop internal pull for SD CD
2023-07-23 10:54 [PATCH] arm64: dts: qcom: msm8939-samsung-a7: Drop internal pull for SD CD Stephan Gerhold
@ 2023-07-26 15:49 ` Konrad Dybcio
2023-07-28 4:08 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2023-07-26 15:49 UTC (permalink / raw)
To: Stephan Gerhold, Bjorn Andersson
Cc: Andy Gross, linux-arm-msm, devicetree, linux-kernel, Lin, Meng-Bo
On 23.07.2023 12:54, Stephan Gerhold wrote:
> A7 seems to have external pull-up for the SD card chip detect (like
> most MSM8916/MSM8939 devices) so drop the internal pull-up. It's not
> necessary.
>
> Tested-by: "Lin, Meng-Bo" <linmengbo0689@protonmail.com>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
If you say so..
Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: qcom: msm8939-samsung-a7: Drop internal pull for SD CD
2023-07-23 10:54 [PATCH] arm64: dts: qcom: msm8939-samsung-a7: Drop internal pull for SD CD Stephan Gerhold
2023-07-26 15:49 ` Konrad Dybcio
@ 2023-07-28 4:08 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2023-07-28 4:08 UTC (permalink / raw)
To: Stephan Gerhold
Cc: Andy Gross, Konrad Dybcio, linux-arm-msm, devicetree,
linux-kernel, Lin, Meng-Bo
On Sun, 23 Jul 2023 12:54:41 +0200, Stephan Gerhold wrote:
> A7 seems to have external pull-up for the SD card chip detect (like
> most MSM8916/MSM8939 devices) so drop the internal pull-up. It's not
> necessary.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: msm8939-samsung-a7: Drop internal pull for SD CD
commit: ee0e92b8e7b5894daf5c94e6433a1989f7233fbe
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-28 4:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-23 10:54 [PATCH] arm64: dts: qcom: msm8939-samsung-a7: Drop internal pull for SD CD Stephan Gerhold
2023-07-26 15:49 ` Konrad Dybcio
2023-07-28 4:08 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).