From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: David Virag <virag.david003@gmail.com>
Cc: phone-devel@vger.kernel.org,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] clk: samsung: exynos7885: Add TREX clocks
Date: Thu, 2 Jun 2022 13:56:41 +0200 [thread overview]
Message-ID: <a0d848eb-c312-ea66-c62f-b4bdb982a66a@linaro.org> (raw)
In-Reply-To: <20220601233743.56317-5-virag.david003@gmail.com>
On 02/06/2022 01:37, David Virag wrote:
> TREX D Core and P core clocks seem to be related to the BTS (Bus Traffic
> Shaper) inside the Exynos7885 SoC, and are needed for the SoC to
> function correctly.
>
> When clocks are cut from TREX D Core, the eMMC and the framebuffer stops
> working properly. Other unknown things may stop working as well.
>
> When clocks are cut from TREX P Core, the system locks up needing a hard
> reset.
>
> Add these clocks and mark them critical so that they are always on.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-02 11:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 23:37 [PATCH 0/5] Bring up internal eMMC on Samsung Galaxy A8 (2018) David Virag
2022-06-01 23:37 ` [PATCH 1/5] dt-bindings: clock: Add bindings for Exynos7885 CMU_FSYS David Virag
2022-06-02 11:54 ` Krzysztof Kozlowski
2022-06-08 15:12 ` Krzysztof Kozlowski
2022-06-20 10:31 ` Sylwester Nawrocki
[not found] ` <CGME20220620102819eucas1p2b03a01c45ca3d0d42ebb9542954f0a4a@eucas1p2.samsung.com>
2022-06-20 10:28 ` Sylwester Nawrocki
2022-06-20 12:27 ` (subset) " Krzysztof Kozlowski
2022-06-01 23:37 ` [PATCH 2/5] dt-bindings: clock: Add indices for Exynos7885 TREX clocks David Virag
2022-06-02 11:55 ` Krzysztof Kozlowski
2022-06-20 12:27 ` (subset) " Krzysztof Kozlowski
2022-06-01 23:37 ` [PATCH 3/5] clk: samsung: exynos7885: Implement CMU_FSYS domain David Virag
2022-06-02 11:56 ` Krzysztof Kozlowski
2022-06-01 23:37 ` [PATCH 4/5] clk: samsung: exynos7885: Add TREX clocks David Virag
2022-06-02 11:56 ` Krzysztof Kozlowski [this message]
2022-06-01 23:37 ` [PATCH 5/5] arm64: dts: exynos: Add internal eMMC support to jackpotlte David Virag
2022-06-02 12:01 ` Krzysztof Kozlowski
2022-06-02 22:18 ` David Virag
2022-06-03 7:38 ` Krzysztof Kozlowski
2022-06-20 12:27 ` (subset) " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0d848eb-c312-ea66-c62f-b4bdb982a66a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=tomasz.figa@gmail.com \
--cc=virag.david003@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).