From: Krzysztof Kozlowski <krzk@kernel.org>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"Heiko Stübner" <heiko@sntech.de>,
"Andy Yan" <andy.yan@rock-chips.com>,
"Alexandre ARNOUD" <aarnoud@me.com>,
"Luis de Arquer" <ldearquer@gmail.com>
Subject: Re: [PATCH 1/2] dt-bindings: display: bridge: Add schema for Synopsys DW HDMI QP TX IP
Date: Fri, 2 Aug 2024 08:46:16 +0200 [thread overview]
Message-ID: <a0f0b7a9-db81-4f64-83f0-8e1f93f0be55@kernel.org> (raw)
In-Reply-To: <e3ce055d-13c9-4e25-a039-dd4a58c8dd7a@collabora.com>
On 01/08/2024 11:29, Cristian Ciocaltea wrote:
>>> + interrupts:
>>> + minItems: 4
>>> + maxItems: 5
>>> + items:
>>> + - description: AVP Unit interrupt
>>> + - description: CEC interrupt
>>> + - description: eARC RX interrupt
>>> + - description: Main Unit interrupt
>>> + additionalItems: true
>>> +
>>> + interrupt-names:
>>> + minItems: 4
>>> + maxItems: 5
>>> + items:
>>> + - const: avp
>>> + - const: cec
>>> + - const: earc
>>> + - const: main
>>> + additionalItems: true
>>
>> Sorry, there is no user of this and nothing here is actually common
>> except first entries in clocks and interrupts properties.
>>
>> I don't see any benefit of this.
>
> Sorry, I should have better indicated this is part of a larger changeset -
> the cover mentions this is a reworked version of an initial (larger) series
> and the split has been explicitly suggested during the review.
This split is really odd. It creates unnecessary dependency, blocks
automated testing and confuses reviewers because reviewers expect common
code followed by its user.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-02 6:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 2:05 [PATCH 0/2] Initial support for Synopsys DW HDMI QP TX Controller Cristian Ciocaltea
2024-08-01 2:05 ` [PATCH 1/2] dt-bindings: display: bridge: Add schema for Synopsys DW HDMI QP TX IP Cristian Ciocaltea
2024-08-01 8:38 ` Krzysztof Kozlowski
2024-08-01 9:29 ` Cristian Ciocaltea
2024-08-01 14:18 ` Krzysztof Kozlowski
2024-08-02 6:46 ` Krzysztof Kozlowski [this message]
2024-08-01 2:05 ` [PATCH 2/2] drm/bridge: synopsys: Add DW HDMI QP TX Controller driver Cristian Ciocaltea
2024-08-01 8:50 ` Krzysztof Kozlowski
2024-08-01 9:43 ` Cristian Ciocaltea
2024-08-01 14:17 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0f0b7a9-db81-4f64-83f0-8e1f93f0be55@kernel.org \
--to=krzk@kernel.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=aarnoud@me.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=ldearquer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).