From: "Rafał Miłecki" <rafal@milecki.pl>
To: William Zhang <william.zhang@broadcom.com>
Cc: Linux ARM List <linux-arm-kernel@lists.infradead.org>,
joel.peshkin@broadcom.com, dan.beygelman@broadcom.com,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Anand Gore <anand.gore@broadcom.com>,
Kursad Oney <kursad.oney@broadcom.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH 2/9] dt-bindings: arm64: bcmbca: Update BCM4908 description
Date: Thu, 21 Jul 2022 08:11:38 +0200 [thread overview]
Message-ID: <a0fa14ba8c4782bde5148d389e2f2a37@milecki.pl> (raw)
In-Reply-To: <20220721000658.29537-1-william.zhang@broadcom.com>
On 2022-07-21 02:06, William Zhang wrote:
> Append "brcm,bcmbca" to BCM4908 chip family compatible strings. Add
> generic 4908 board entry.
>
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
Acked-by: Rafał Miłecki <rafal@milecki.pl>
(with one minor comment below)
> ---
>
> Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git
> a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
> b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
> index 6a64afa95918..4494a2c58c7f 100644
> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
> @@ -36,18 +36,22 @@ properties:
> - tplink,archer-c2300-v1
> - const: brcm,bcm4906
> - const: brcm,bcm4908
> + - const: brcm,bcmbca
>
> - description: BCM4908 based boards
> items:
> - enum:
> - asus,gt-ac5300
> - netgear,raxe500
> + - brcm,bcm94908
I think it would be nice to keep enum entries sorted
> - const: brcm,bcm4908
> + - const: brcm,bcmbca
>
> - description: BCM49408 based boards
> items:
> - const: brcm,bcm49408
> - const: brcm,bcm4908
> + - const: brcm,bcmbca
>
> - description: BCM4912 based boards
> items:
next prev parent reply other threads:[~2022-07-21 6:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 0:06 [RESEND PATCH 2/9] dt-bindings: arm64: bcmbca: Update BCM4908 description William Zhang
2022-07-21 6:11 ` Rafał Miłecki [this message]
2022-07-21 6:44 ` Krzysztof Kozlowski
2022-07-21 6:51 ` Rafał Miłecki
2022-07-21 7:01 ` Krzysztof Kozlowski
2022-07-21 7:13 ` Rafał Miłecki
2022-07-21 7:36 ` Krzysztof Kozlowski
2022-07-21 7:50 ` Rafał Miłecki
2022-07-21 16:43 ` Florian Fainelli
2022-07-21 19:35 ` William Zhang
2022-07-22 18:22 ` Krzysztof Kozlowski
2022-07-25 6:00 ` William Zhang
2022-07-22 0:07 ` William Zhang
2022-07-22 18:24 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0fa14ba8c4782bde5148d389e2f2a37@milecki.pl \
--to=rafal@milecki.pl \
--cc=anand.gore@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.beygelman@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=joel.peshkin@broadcom.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kursad.oney@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).