From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11F44C43334 for ; Thu, 21 Jul 2022 06:50:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231686AbiGUGu6 (ORCPT ); Thu, 21 Jul 2022 02:50:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231675AbiGUGu5 (ORCPT ); Thu, 21 Jul 2022 02:50:57 -0400 Received: from 14.mo561.mail-out.ovh.net (14.mo561.mail-out.ovh.net [188.165.43.98]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC9A442ADC for ; Wed, 20 Jul 2022 23:50:55 -0700 (PDT) Received: from player758.ha.ovh.net (unknown [10.109.146.86]) by mo561.mail-out.ovh.net (Postfix) with ESMTP id BD8BC22E08 for ; Thu, 21 Jul 2022 06:11:49 +0000 (UTC) Received: from RCM-web2.webmail.mail.ovh.net (ip-194-187-74-233.konfederacka.maverick.com.pl [194.187.74.233]) (Authenticated sender: rafal@milecki.pl) by player758.ha.ovh.net (Postfix) with ESMTPSA id 6F8EF2CD0FAD7; Thu, 21 Jul 2022 06:11:38 +0000 (UTC) MIME-Version: 1.0 Date: Thu, 21 Jul 2022 08:11:38 +0200 From: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= To: William Zhang Cc: Linux ARM List , joel.peshkin@broadcom.com, dan.beygelman@broadcom.com, Rob Herring , Krzysztof Kozlowski , Anand Gore , Kursad Oney , Florian Fainelli , Broadcom internal kernel review list , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH 2/9] dt-bindings: arm64: bcmbca: Update BCM4908 description In-Reply-To: <20220721000658.29537-1-william.zhang@broadcom.com> References: <20220721000658.29537-1-william.zhang@broadcom.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: rafal@milecki.pl X-Originating-IP: 194.187.74.233 X-Webmail-UserID: rafal@milecki.pl Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 17160121956132236251 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrudelkedgtdekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepggffhffvvefujghffgfkgihitgfgsehtkehjtddtreejnecuhfhrohhmpeftrghfrghlpgfoihhlvggtkhhiuceorhgrfhgrlhesmhhilhgvtghkihdrphhlqeenucggtffrrghtthgvrhhnpeevjefhffffveeludejfedtvdfftdekgffghfegieeliedvfeeigfejteejjeekfeenucfkpheptddrtddrtddrtddpudelgedrudekjedrjeegrddvfeefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehplhgrhigvrhejheekrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheprhgrfhgrlhesmhhilhgvtghkihdrphhlpdhnsggprhgtphhtthhopedupdhrtghpthhtohepuggvvhhitggvthhrvggvsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdfovfetjfhoshhtpehmohehiedu Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2022-07-21 02:06, William Zhang wrote: > Append "brcm,bcmbca" to BCM4908 chip family compatible strings. Add > generic 4908 board entry. > > Signed-off-by: William Zhang Acked-by: Rafał Miłecki (with one minor comment below) > --- > > Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git > a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml > b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml > index 6a64afa95918..4494a2c58c7f 100644 > --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml > +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml > @@ -36,18 +36,22 @@ properties: > - tplink,archer-c2300-v1 > - const: brcm,bcm4906 > - const: brcm,bcm4908 > + - const: brcm,bcmbca > > - description: BCM4908 based boards > items: > - enum: > - asus,gt-ac5300 > - netgear,raxe500 > + - brcm,bcm94908 I think it would be nice to keep enum entries sorted > - const: brcm,bcm4908 > + - const: brcm,bcmbca > > - description: BCM49408 based boards > items: > - const: brcm,bcm49408 > - const: brcm,bcm4908 > + - const: brcm,bcmbca > > - description: BCM4912 based boards > items: