From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dylan Van Assche <me@dylanvanassche.be>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, amartinz@shiftphones.com
Subject: Re: [PATCH 1/2] arm64: dts: qcom: pmi8998: add flash LED
Date: Wed, 17 May 2023 21:07:06 +0200 [thread overview]
Message-ID: <a10695f5-e7d6-7fac-695c-a5b1c17ad56a@linaro.org> (raw)
In-Reply-To: <20230517182133.72590-2-me@dylanvanassche.be>
On 17/05/2023 20:21, Dylan Van Assche wrote:
> Qualcomm PMIC PMI8998 has a 3 channel flash LED driver which is used
> by many phones for 1 or 2 flash LEDs. Each LED can be used in flash mode
> or torch mode. Add the flash LED node to PMI8998 DTS.
>
> Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
> ---
> arch/arm64/boot/dts/qcom/pmi8998.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> index ffe587f281d8..89f959353ad5 100644
> --- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> @@ -60,6 +60,12 @@ pmi8998_lpg: pwm {
> status = "disabled";
> };
>
> + pmi8998_flash: led-controller@d300 {
> + compatible = "qcom,spmi-flash-led";
This cannot be alone.
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-17 19:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 18:21 [PATCH 0/2] arm64: dts: qcom: pmi8998: add and enable flash LED Dylan Van Assche
2023-05-17 18:21 ` [PATCH 1/2] arm64: dts: qcom: pmi8998: add " Dylan Van Assche
2023-05-17 19:07 ` Krzysztof Kozlowski [this message]
2023-05-17 18:21 ` [PATCH 2/2] arm64: dts: qcom: sdm845-shift-axolotl: enable " Dylan Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a10695f5-e7d6-7fac-695c-a5b1c17ad56a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=amartinz@shiftphones.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@dylanvanassche.be \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).