* [PATCH v3 0/2] Enable TSENS and thermal zone for QCS615 SoC
@ 2025-06-13 11:24 Gaurav Kohli
2025-06-13 11:24 ` [PATCH v3 1/2] dt-bindings: thermal: tsens: Add QCS615 compatible Gaurav Kohli
2025-06-13 11:24 ` [PATCH v3 2/2] arm64: dts: qcom: qcs615: Enable TSENS support for QCS615 SoC Gaurav Kohli
0 siblings, 2 replies; 6+ messages in thread
From: Gaurav Kohli @ 2025-06-13 11:24 UTC (permalink / raw)
To: amitk, daniel.lezcano, robh, krzk+dt, andersson, konradybcio
Cc: devicetree, =linux-kernel, linux-arm-msm, quic_manafm,
Gaurav Kohli
Adding compatible string in TSENS dt-bindings, device node
for TSENS controller and Thermal zone support.
---
Changes in v3:
- Add critical for all trips.
- Link to v2: https://lore.kernel.org/linux-devicetree/cover.1744955863.git.gkohli@qti.qualcomm.com/
Changes in v2:
- Drop the passive trip point and add critical for CPU thermal zones.
- Rearrange the tsens dt node and fix the address part.
- Fix the commit subject with target name.
- Link to v1: https://lore.kernel.org/linux-devicetree/cover.1744292503.git.quic_gkohli@quicinc.com/
---
Gaurav Kohli (2):
dt-bindings: thermal: tsens: Add QCS615 compatible
arm64: dts: qcom: qcs615: Enable TSENS support for QCS615 SoC
.../bindings/thermal/qcom-tsens.yaml | 1 +
arch/arm64/boot/dts/qcom/qcs615.dtsi | 205 ++++++++++++++++++
2 files changed, 206 insertions(+)
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3 1/2] dt-bindings: thermal: tsens: Add QCS615 compatible
2025-06-13 11:24 [PATCH v3 0/2] Enable TSENS and thermal zone for QCS615 SoC Gaurav Kohli
@ 2025-06-13 11:24 ` Gaurav Kohli
2025-06-13 11:24 ` [PATCH v3 2/2] arm64: dts: qcom: qcs615: Enable TSENS support for QCS615 SoC Gaurav Kohli
1 sibling, 0 replies; 6+ messages in thread
From: Gaurav Kohli @ 2025-06-13 11:24 UTC (permalink / raw)
To: amitk, daniel.lezcano, robh, krzk+dt, andersson, konradybcio
Cc: devicetree, =linux-kernel, linux-arm-msm, quic_manafm,
Gaurav Kohli
Add compatibility string for the thermal sensors on QCS615 platform.
Acked-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Gaurav Kohli <quic_gkohli@quicinc.com>
diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
index 0e653bbe9884..c8cc67b65f73 100644
--- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
+++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
@@ -53,6 +53,7 @@ properties:
- qcom,msm8996-tsens
- qcom,msm8998-tsens
- qcom,qcm2290-tsens
+ - qcom,qcs615-tsens
- qcom,sa8255p-tsens
- qcom,sa8775p-tsens
- qcom,sar2130p-tsens
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v3 2/2] arm64: dts: qcom: qcs615: Enable TSENS support for QCS615 SoC
2025-06-13 11:24 [PATCH v3 0/2] Enable TSENS and thermal zone for QCS615 SoC Gaurav Kohli
2025-06-13 11:24 ` [PATCH v3 1/2] dt-bindings: thermal: tsens: Add QCS615 compatible Gaurav Kohli
@ 2025-06-13 11:24 ` Gaurav Kohli
2025-06-13 12:35 ` Dmitry Baryshkov
2025-06-13 12:42 ` Krzysztof Kozlowski
1 sibling, 2 replies; 6+ messages in thread
From: Gaurav Kohli @ 2025-06-13 11:24 UTC (permalink / raw)
To: amitk, daniel.lezcano, robh, krzk+dt, andersson, konradybcio
Cc: devicetree, =linux-kernel, linux-arm-msm, quic_manafm,
Gaurav Kohli
Add TSENS and thermal devicetree node for QCS615 SoC.
Signed-off-by: Gaurav Kohli <quic_gkohli@quicinc.com>
diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi
index bb8b6c3ebd03..fda8b8638718 100644
--- a/arch/arm64/boot/dts/qcom/qcs615.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi
@@ -3692,6 +3692,17 @@ usb_2_dwc3: usb@a800000 {
maximum-speed = "high-speed";
};
};
+
+ tsens0: tsens@c222000 {
+ compatible = "qcom,qcs615-tsens", "qcom,tsens-v2";
+ reg = <0x0 0x0c263000 0x0 0x1ff>,
+ <0x0 0x0c222000 0x0 0x8>;
+ interrupts = <GIC_SPI 506 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 508 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "uplow", "critical";
+ #qcom,sensors = <16>;
+ #thermal-sensor-cells = <1>;
+ };
};
arch_timer: timer {
@@ -3701,4 +3712,198 @@ arch_timer: timer {
<GIC_PPI 3 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
<GIC_PPI 0 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>;
};
+
+ thermal-zones {
+ aoss-thermal {
+ thermal-sensors = <&tsens0 0>;
+
+ trips {
+ aoss-critical {
+ temperature = <115000>;
+ hysteresis = <1000>;
+ type = "critical";
+ };
+ };
+ };
+
+ cpuss-0-thermal {
+ thermal-sensors = <&tsens0 1>;
+
+ trips {
+ cpuss0-critical {
+ temperature = <115000>;
+ hysteresis = <1000>;
+ type = "critical";
+ };
+ };
+ };
+
+ cpuss-1-thermal {
+ thermal-sensors = <&tsens0 2>;
+
+ trips {
+ cpuss1-critical {
+ temperature = <115000>;
+ hysteresis = <1000>;
+ type = "critical";
+ };
+ };
+ };
+
+ cpuss-2-thermal {
+ thermal-sensors = <&tsens0 3>;
+
+ trips {
+ cpuss2-critical {
+ temperature = <115000>;
+ hysteresis = <1000>;
+ type = "critical";
+ };
+ };
+ };
+
+ cpuss-3-thermal {
+ thermal-sensors = <&tsens0 4>;
+
+ trips {
+ cpuss3-critical {
+ temperature = <115000>;
+ hysteresis = <1000>;
+ type = "critical";
+ };
+ };
+ };
+
+ cpu-1-0-thermal {
+ thermal-sensors = <&tsens0 5>;
+
+ trips {
+ cpu-critical {
+ temperature = <115000>;
+ hysteresis = <1000>;
+ type = "critical";
+ };
+ };
+ };
+
+ cpu-1-1-thermal {
+ thermal-sensors = <&tsens0 6>;
+
+ trips {
+ cpu-critical {
+ temperature = <115000>;
+ hysteresis = <1000>;
+ type = "critical";
+ };
+ };
+ };
+
+ cpu-1-2-thermal {
+ thermal-sensors = <&tsens0 7>;
+
+ trips {
+ cpu-critical {
+ temperature = <115000>;
+ hysteresis = <1000>;
+ type = "critical";
+ };
+ };
+ };
+
+ cpu-1-3-thermal {
+ thermal-sensors = <&tsens0 8>;
+
+ trips {
+ cpu-critical {
+ temperature = <115000>;
+ hysteresis = <1000>;
+ type = "critical";
+ };
+ };
+ };
+
+ gpu-thermal {
+ thermal-sensors = <&tsens0 9>;
+
+ trips {
+ gpu-critical {
+ temperature = <115000>;
+ hysteresis = <1000>;
+ type = "critical";
+ };
+ };
+ };
+
+ q6-hvx-thermal {
+ thermal-sensors = <&tsens0 10>;
+
+ trips {
+ q6-hvx-critical {
+ temperature = <115000>;
+ hysteresis = <1000>;
+ type = "critical";
+ };
+ };
+ };
+
+ mdm-core-thermal {
+ thermal-sensors = <&tsens0 11>;
+
+ trips {
+ mdm-core-critical {
+ temperature = <115000>;
+ hysteresis = <1000>;
+ type = "critical";
+ };
+ };
+ };
+
+ camera-thermal {
+ thermal-sensors = <&tsens0 12>;
+
+ trips {
+ camera-critical {
+ temperature = <115000>;
+ hysteresis = <1000>;
+ type = "critical";
+ };
+ };
+ };
+
+ wlan-thermal {
+ thermal-sensors = <&tsens0 13>;
+
+ trips {
+ wlan-critical {
+ temperature = <115000>;
+ hysteresis = <1000>;
+ type = "critical";
+ };
+ };
+ };
+
+ display-thermal {
+ thermal-sensors = <&tsens0 14>;
+
+ trips {
+ display-critical {
+ temperature = <115000>;
+ hysteresis = <1000>;
+ type = "critical";
+ };
+ };
+ };
+
+ video-thermal {
+ thermal-sensors = <&tsens0 15>;
+
+ trips {
+ video-critical {
+ temperature = <115000>;
+ hysteresis = <1000>;
+ type = "critical";
+ };
+ };
+ };
+ };
};
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3 2/2] arm64: dts: qcom: qcs615: Enable TSENS support for QCS615 SoC
2025-06-13 11:24 ` [PATCH v3 2/2] arm64: dts: qcom: qcs615: Enable TSENS support for QCS615 SoC Gaurav Kohli
@ 2025-06-13 12:35 ` Dmitry Baryshkov
2025-06-13 12:42 ` Krzysztof Kozlowski
1 sibling, 0 replies; 6+ messages in thread
From: Dmitry Baryshkov @ 2025-06-13 12:35 UTC (permalink / raw)
To: Gaurav Kohli
Cc: amitk, daniel.lezcano, robh, krzk+dt, andersson, konradybcio,
devicetree, =linux-kernel, linux-arm-msm, quic_manafm
On Fri, Jun 13, 2025 at 04:54:02PM +0530, Gaurav Kohli wrote:
> Add TSENS and thermal devicetree node for QCS615 SoC.
>
> Signed-off-by: Gaurav Kohli <quic_gkohli@quicinc.com>
>
Please don't edit the patches when sending. You seem to have removed the
diffstat. That doesn't help the reviewers.
Nevertheless:
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi
> index bb8b6c3ebd03..fda8b8638718 100644
> --- a/arch/arm64/boot/dts/qcom/qcs615.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi
> @@ -3692,6 +3692,17 @@ usb_2_dwc3: usb@a800000 {
> maximum-speed = "high-speed";
> };
> };
> +
> + tsens0: tsens@c222000 {
> + compatible = "qcom,qcs615-tsens", "qcom,tsens-v2";
> + reg = <0x0 0x0c263000 0x0 0x1ff>,
> + <0x0 0x0c222000 0x0 0x8>;
> + interrupts = <GIC_SPI 506 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 508 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "uplow", "critical";
> + #qcom,sensors = <16>;
> + #thermal-sensor-cells = <1>;
> + };
> };
>
> arch_timer: timer {
> @@ -3701,4 +3712,198 @@ arch_timer: timer {
> <GIC_PPI 3 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
> <GIC_PPI 0 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>;
> };
> +
> + thermal-zones {
> + aoss-thermal {
> + thermal-sensors = <&tsens0 0>;
> +
> + trips {
> + aoss-critical {
> + temperature = <115000>;
> + hysteresis = <1000>;
> + type = "critical";
> + };
> + };
> + };
> +
> + cpuss-0-thermal {
> + thermal-sensors = <&tsens0 1>;
> +
> + trips {
> + cpuss0-critical {
> + temperature = <115000>;
> + hysteresis = <1000>;
> + type = "critical";
> + };
> + };
> + };
> +
> + cpuss-1-thermal {
> + thermal-sensors = <&tsens0 2>;
> +
> + trips {
> + cpuss1-critical {
> + temperature = <115000>;
> + hysteresis = <1000>;
> + type = "critical";
> + };
> + };
> + };
> +
> + cpuss-2-thermal {
> + thermal-sensors = <&tsens0 3>;
> +
> + trips {
> + cpuss2-critical {
> + temperature = <115000>;
> + hysteresis = <1000>;
> + type = "critical";
> + };
> + };
> + };
> +
> + cpuss-3-thermal {
> + thermal-sensors = <&tsens0 4>;
> +
> + trips {
> + cpuss3-critical {
> + temperature = <115000>;
> + hysteresis = <1000>;
> + type = "critical";
> + };
> + };
> + };
> +
> + cpu-1-0-thermal {
> + thermal-sensors = <&tsens0 5>;
> +
> + trips {
> + cpu-critical {
> + temperature = <115000>;
> + hysteresis = <1000>;
> + type = "critical";
> + };
> + };
> + };
> +
> + cpu-1-1-thermal {
> + thermal-sensors = <&tsens0 6>;
> +
> + trips {
> + cpu-critical {
> + temperature = <115000>;
> + hysteresis = <1000>;
> + type = "critical";
> + };
> + };
> + };
> +
> + cpu-1-2-thermal {
> + thermal-sensors = <&tsens0 7>;
> +
> + trips {
> + cpu-critical {
> + temperature = <115000>;
> + hysteresis = <1000>;
> + type = "critical";
> + };
> + };
> + };
> +
> + cpu-1-3-thermal {
> + thermal-sensors = <&tsens0 8>;
> +
> + trips {
> + cpu-critical {
> + temperature = <115000>;
> + hysteresis = <1000>;
> + type = "critical";
> + };
> + };
> + };
> +
> + gpu-thermal {
> + thermal-sensors = <&tsens0 9>;
> +
> + trips {
> + gpu-critical {
> + temperature = <115000>;
> + hysteresis = <1000>;
> + type = "critical";
> + };
> + };
> + };
> +
> + q6-hvx-thermal {
> + thermal-sensors = <&tsens0 10>;
> +
> + trips {
> + q6-hvx-critical {
> + temperature = <115000>;
> + hysteresis = <1000>;
> + type = "critical";
> + };
> + };
> + };
> +
> + mdm-core-thermal {
> + thermal-sensors = <&tsens0 11>;
> +
> + trips {
> + mdm-core-critical {
> + temperature = <115000>;
> + hysteresis = <1000>;
> + type = "critical";
> + };
> + };
> + };
> +
> + camera-thermal {
> + thermal-sensors = <&tsens0 12>;
> +
> + trips {
> + camera-critical {
> + temperature = <115000>;
> + hysteresis = <1000>;
> + type = "critical";
> + };
> + };
> + };
> +
> + wlan-thermal {
> + thermal-sensors = <&tsens0 13>;
> +
> + trips {
> + wlan-critical {
> + temperature = <115000>;
> + hysteresis = <1000>;
> + type = "critical";
> + };
> + };
> + };
> +
> + display-thermal {
> + thermal-sensors = <&tsens0 14>;
> +
> + trips {
> + display-critical {
> + temperature = <115000>;
> + hysteresis = <1000>;
> + type = "critical";
> + };
> + };
> + };
> +
> + video-thermal {
> + thermal-sensors = <&tsens0 15>;
> +
> + trips {
> + video-critical {
> + temperature = <115000>;
> + hysteresis = <1000>;
> + type = "critical";
> + };
> + };
> + };
> + };
> };
> --
> 2.34.1
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 2/2] arm64: dts: qcom: qcs615: Enable TSENS support for QCS615 SoC
2025-06-13 11:24 ` [PATCH v3 2/2] arm64: dts: qcom: qcs615: Enable TSENS support for QCS615 SoC Gaurav Kohli
2025-06-13 12:35 ` Dmitry Baryshkov
@ 2025-06-13 12:42 ` Krzysztof Kozlowski
2025-06-17 4:30 ` Gaurav Kohli
1 sibling, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-13 12:42 UTC (permalink / raw)
To: Gaurav Kohli, amitk, daniel.lezcano, robh, krzk+dt, andersson,
konradybcio
Cc: devicetree, =linux-kernel, linux-arm-msm, quic_manafm
On 13/06/2025 13:24, Gaurav Kohli wrote:
> Add TSENS and thermal devicetree node for QCS615 SoC.
>
> Signed-off-by: Gaurav Kohli <quic_gkohli@quicinc.com>
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi
> index bb8b6c3ebd03..fda8b8638718 100644
> --- a/arch/arm64/boot/dts/qcom/qcs615.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi
> @@ -3692,6 +3692,17 @@ usb_2_dwc3: usb@a800000 {
> maximum-speed = "high-speed";
> };
> };
> +
> + tsens0: tsens@c222000 {
Don't send us downstream. Node names should be generic. See also an
explanation and list of examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 2/2] arm64: dts: qcom: qcs615: Enable TSENS support for QCS615 SoC
2025-06-13 12:42 ` Krzysztof Kozlowski
@ 2025-06-17 4:30 ` Gaurav Kohli
0 siblings, 0 replies; 6+ messages in thread
From: Gaurav Kohli @ 2025-06-17 4:30 UTC (permalink / raw)
To: Krzysztof Kozlowski, amitk, daniel.lezcano, robh, krzk+dt,
andersson, konradybcio
Cc: devicetree, =linux-kernel, linux-arm-msm, quic_manafm
On 6/13/2025 6:12 PM, Krzysztof Kozlowski wrote:
> On 13/06/2025 13:24, Gaurav Kohli wrote:
>> Add TSENS and thermal devicetree node for QCS615 SoC.
>>
>> Signed-off-by: Gaurav Kohli <quic_gkohli@quicinc.com>
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi
>> index bb8b6c3ebd03..fda8b8638718 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs615.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi
>> @@ -3692,6 +3692,17 @@ usb_2_dwc3: usb@a800000 {
>> maximum-speed = "high-speed";
>> };
>> };
>> +
>> + tsens0: tsens@c222000 {
>
> Don't send us downstream. Node names should be generic. See also an
> explanation and list of examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>
>
thanks for review & comment, will fix the naming.
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-06-17 4:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-13 11:24 [PATCH v3 0/2] Enable TSENS and thermal zone for QCS615 SoC Gaurav Kohli
2025-06-13 11:24 ` [PATCH v3 1/2] dt-bindings: thermal: tsens: Add QCS615 compatible Gaurav Kohli
2025-06-13 11:24 ` [PATCH v3 2/2] arm64: dts: qcom: qcs615: Enable TSENS support for QCS615 SoC Gaurav Kohli
2025-06-13 12:35 ` Dmitry Baryshkov
2025-06-13 12:42 ` Krzysztof Kozlowski
2025-06-17 4:30 ` Gaurav Kohli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).