From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99931C0015E for ; Wed, 26 Jul 2023 11:26:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233538AbjGZL0v (ORCPT ); Wed, 26 Jul 2023 07:26:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233662AbjGZL0g (ORCPT ); Wed, 26 Jul 2023 07:26:36 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D38E2696 for ; Wed, 26 Jul 2023 04:26:22 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-3141fa31c2bso5226111f8f.2 for ; Wed, 26 Jul 2023 04:26:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690370780; x=1690975580; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Me9DdLikay9/mg6C3pH4uUNkCjGXHrRqvb1zE6qVcE8=; b=ujTe+OeVXyCQq14CK3Lba2vXYOY9/0WyK+FgPAmVWPvzh3WNG2TICYQast91tQL3J7 7nZSIWWrhBBoDpJgfuV54SLHBWWYOCemg/C5NM5OftTyQk8YsN3RyzWTeINC6jiP20T6 Yvw+psL8owvkQ0G+pmfjynvhdzpJuaKajxQDJ1sKtdGQylimQcZ8kz/nspw0Bg0GsK07 dKIL0khNzLWR6bfDh71j3MQeL6YkTcRBtJvOYrm9MpfVgHft9xgCPLOisrXQndxpjXan wqUtQCJ6w2jldLKMabpDa/QJtc9sU8gKVGiaz5BYvrmdBjU4eesDzOULf9ieBr5AU7d/ pQzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690370780; x=1690975580; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Me9DdLikay9/mg6C3pH4uUNkCjGXHrRqvb1zE6qVcE8=; b=ixVg8Nv1Uy960jqhuE9KUHtYNrq/R3+RkfhGw5FudlWc3mw8dZFO0LvwgjGTOqmHhn 2BY+UBTy+vjWeeCGSbwvTeZZV+2g9AgiGC1tBICxtIhsZ7uMJZywSsRstFOXNRktpL3Q T/xr87M8VLKTw7rFXB10NmoilgtxqdAlXkelQ8CJxSSbXWkR4x0jVNCGq4oZ0xuYme84 5u2OzC9dLknD5hUQISOeJbtdwKtd4/Cp4ua0J0+y3U7ewyylhvMczb30DhBGnwp37hoc pBk+I0uaPiumqnVc7MIKAb85MwpYrp/87xsIQ/l8OWi8V+LTLwIBSOh4/LNzxkjJdYsj zvSQ== X-Gm-Message-State: ABy/qLbNgucA5ndaXmn2KYnDgsefL5GXyvuG7+I8EWJgH9fUxo7Dbti5 p4XnwGlgaYoq22CMzDBQ4SrmEw== X-Google-Smtp-Source: APBJJlEGjczswR4kEUEn/zYFcZ9/aGxKnTF+3Hy6HdeMe8iP8tSvfbhOFOcSPsrOUXJpQ+OHei9OVw== X-Received: by 2002:adf:efcb:0:b0:314:370f:e92c with SMTP id i11-20020adfefcb000000b00314370fe92cmr1190968wrp.67.1690370780412; Wed, 26 Jul 2023 04:26:20 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id h4-20020adfe984000000b003175f00e555sm9584341wrm.97.2023.07.26.04.26.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jul 2023 04:26:19 -0700 (PDT) Message-ID: Date: Wed, 26 Jul 2023 12:26:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v7 2/6] media: admin-guide: Add starfive_camss.rst for Starfive Camera Subsystem Content-Language: en-US To: Jack Zhu , Mauro Carvalho Chehab , Robert Foss , Todor Tomov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Laurent Pinchart , Hans Verkuil , Eugen Hristev , Ezequiel Garcia Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, changhuang.liang@starfivetech.com References: <20230619112838.19797-1-jack.zhu@starfivetech.com> <20230619112838.19797-3-jack.zhu@starfivetech.com> From: Bryan O'Donoghue In-Reply-To: <20230619112838.19797-3-jack.zhu@starfivetech.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/06/2023 12:28, Jack Zhu wrote: > Add starfive_camss.rst file that documents the Starfive Camera > Subsystem driver which is used for handing image sensor data. > > Signed-off-by: Jack Zhu > --- > .../admin-guide/media/starfive_camss.rst | 57 +++++++++++++++++++ > .../media/starfive_camss_graph.dot | 16 ++++++ > .../admin-guide/media/v4l-drivers.rst | 1 + > MAINTAINERS | 1 + > 4 files changed, 75 insertions(+) > create mode 100644 Documentation/admin-guide/media/starfive_camss.rst > create mode 100644 Documentation/admin-guide/media/starfive_camss_graph.dot > > diff --git a/Documentation/admin-guide/media/starfive_camss.rst b/Documentation/admin-guide/media/starfive_camss.rst > new file mode 100644 > index 000000000000..a6378849384f > --- /dev/null > +++ b/Documentation/admin-guide/media/starfive_camss.rst > @@ -0,0 +1,57 @@ > +.. SPDX-License-Identifier: GPL-2.0 > + > +.. include:: > + > +================================ > +Starfive Camera Subsystem driver > +================================ > + > +Introduction > +------------ > + > +This file documents the driver for the Starfive Camera Subsystem found on > +Starfive JH7110 SoC. The driver is located under drivers/media/platform/ > +starfive. > + > +The driver implements V4L2, Media controller and v4l2_subdev interfaces. > +Camera sensor using V4L2 subdev interface in the kernel is supported. > + > +The driver has been successfully used on the Gstreamer 1.18.5 with > +v4l2src plugin. > + > + > +Starfive Camera Subsystem hardware > +---------------------------------- > + > +The Starfive Camera Subsystem hardware consists of: > + > +- MIPI DPHY Receiver: receives mipi data from a MIPI camera sensor. Feels like a terribe nit-pick but you have "mipi" and "MIPI" here. I'd be consistent with one - recommend MIPI throughout your documentation. > +- MIPI CSIRx Controller: is responsible for handling and decoding CSI2 protocol > + based camera sensor data stream. > +- ISP: handles the image data streams from the MIPI CSIRx Controller. Maybe you've done this elsewhere but, it would be worthwhile describing what the ISP does. Debayering ? 3As ? Just raw dumps ? > +- VIN(Video In): a top-level module, is responsible for controlling power > + and clocks to other modules, dumps the input data to memory or transfers the > + input data to ISP. > + > + > +Topology > +-------- > + > +The media controller pipeline graph is as follows: > + > +.. _starfive_camss_graph: > + > +.. kernel-figure:: starfive_camss_graph.dot > + :alt: starfive_camss_graph.dot > + :align: center > + > +The driver has 2 video devices: > + > +- stf_vin0_wr_video0: capture device for images directly from the VIN module. OK so you can get the raw images. > +- stf_vin0_isp0_video1: capture device for images without scaling. > + > +The driver has 3 subdevices: > + > +- stf_isp0: is responsible for all the isp operations. > +- stf_vin0_wr: used to dump RAW images to memory. > +- stf_vin0_isp0: used to capture images for the stf_vin0_isp0_video1 device. But what is being output here ? RGB, jpeg, YUV ? It would be worth adding a few bits of text to describe that so you don't have to dive into code to understand it. --- bod