* [PATCH v4 1/3] arm64: dts: qcom: sm8250: camss: Define ports address/size cells
2022-11-12 12:41 [PATCH v4 0/3] Switch on IMX577 on RB5 Bryan O'Donoghue
@ 2022-11-12 12:41 ` Bryan O'Donoghue
2022-11-12 12:41 ` [PATCH v4 2/3] arm64: dts: qcom: qrb5165-rb5-vision-mezzanine: Add vision mezzanine Bryan O'Donoghue
2022-11-12 12:41 ` [PATCH v4 3/3] arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Add navigation mezzanine dts Bryan O'Donoghue
2 siblings, 0 replies; 8+ messages in thread
From: Bryan O'Donoghue @ 2022-11-12 12:41 UTC (permalink / raw)
To: robert.foss, todor.too, agross, andersson, konrad.dybcio, mchehab,
robh+dt, krzysztof.kozlowski+dt, dmitry.baryshkov,
vladimir.zapolskiy
Cc: sakari.ailus, hverkuil, laurent.pinchart, quic_mmitkov,
linux-media, linux-arm-msm, devicetree, Bryan O'Donoghue
The ports {} address and size cells definition is the same for every
derived 8250 board so, we should define it in the core sm8250.dtsi.
Suggested-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8250.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index d517d6a80bdcb..f28a8893d00d7 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -3412,6 +3412,11 @@ camss: camss@ac6a000 {
"cam_hf_0_mnoc",
"cam_sf_0_mnoc",
"cam_sf_icp_mnoc";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
};
camcc: clock-controller@ad00000 {
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v4 2/3] arm64: dts: qcom: qrb5165-rb5-vision-mezzanine: Add vision mezzanine
2022-11-12 12:41 [PATCH v4 0/3] Switch on IMX577 on RB5 Bryan O'Donoghue
2022-11-12 12:41 ` [PATCH v4 1/3] arm64: dts: qcom: sm8250: camss: Define ports address/size cells Bryan O'Donoghue
@ 2022-11-12 12:41 ` Bryan O'Donoghue
2022-11-12 13:13 ` Konrad Dybcio
2022-11-12 12:41 ` [PATCH v4 3/3] arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Add navigation mezzanine dts Bryan O'Donoghue
2 siblings, 1 reply; 8+ messages in thread
From: Bryan O'Donoghue @ 2022-11-12 12:41 UTC (permalink / raw)
To: robert.foss, todor.too, agross, andersson, konrad.dybcio, mchehab,
robh+dt, krzysztof.kozlowski+dt, dmitry.baryshkov,
vladimir.zapolskiy
Cc: sakari.ailus, hverkuil, laurent.pinchart, quic_mmitkov,
linux-media, linux-arm-msm, devicetree, Bryan O'Donoghue
The Vision Mezzanine for the RB5 ships with an imx517 and ov9282 populated.
Other sensors and components may be added or stacked with additional
mezzanines.
Enable both the IMX577
An example media-ctl pipeline for the imx577 is:
media-ctl --reset
media-ctl -v -d /dev/media0 -V '"imx577 '22-001a'":0[fmt:SRGGB10/4056x3040 field:none]'
media-ctl -V '"msm_csiphy2":0[fmt:SRGGB10/4056x3040]'
media-ctl -V '"msm_csid0":0[fmt:SRGGB10/4056x3040]'
media-ctl -V '"msm_vfe0_rdi0":0[fmt:SRGGB10/4056x3040]'
media-ctl -l '"msm_csiphy2":1->"msm_csid0":0[1]'
media-ctl -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]'
yavta -B capture-mplane -c -I -n 5 -f SRGGB10P -s 4056x3040 -F /dev/video0
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
arch/arm64/boot/dts/qcom/Makefile | 1 +
.../dts/qcom/qrb5165-rb5-vision-mezzanine.dts | 63 +++++++++++++++++++
arch/arm64/boot/dts/qcom/sm8250.dtsi | 33 ++++++++++
3 files changed, 97 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/qrb5165-rb5-vision-mezzanine.dts
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index d534888bcfe52..cd88efa19e750 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -54,6 +54,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-poplar.dtb
dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb
dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb
dtb-$(CONFIG_ARCH_QCOM) += qrb5165-rb5.dtb
+dtb-$(CONFIG_ARCH_QCOM) += qrb5165-rb5-vision-mezzanine.dtb
dtb-$(CONFIG_ARCH_QCOM) += sa8155p-adp.dtb
dtb-$(CONFIG_ARCH_QCOM) += sa8295p-adp.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-idp.dtb
diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5-vision-mezzanine.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5-vision-mezzanine.dts
new file mode 100644
index 0000000000000..315d524045cf3
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5-vision-mezzanine.dts
@@ -0,0 +1,63 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2022, Linaro Ltd.
+ */
+
+/dts-v1/;
+
+#include "qrb5165-rb5.dts"
+
+&camss {
+ status = "okay";
+ vdda-phy-supply = <&vreg_l5a_0p88>;
+ vdda-pll-supply = <&vreg_l9a_1p2>;
+
+ ports {
+ /* The port index denotes CSIPHY id i.e. csiphy2 */
+ port@2 {
+ reg = <2>;
+ csiphy2_ep: endpoint {
+ clock-lanes = <7>;
+ data-lanes = <0 1 2 3>;
+ remote-endpoint = <&imx577_ep>;
+ };
+ };
+ };
+};
+
+&camcc {
+ status = "okay";
+};
+
+&cci1 {
+ status = "okay";
+};
+
+&cci1_i2c0 {
+ camera@1a {
+ compatible = "sony,imx577";
+ reg = <0x1a>;
+
+ reset-gpios = <&tlmm 78 GPIO_ACTIVE_LOW>;
+ pinctrl-names = "default", "suspend";
+ pinctrl-0 = <&cam2_default>;
+ pinctrl-1 = <&cam2_suspend>;
+
+ clocks = <&camcc CAM_CC_MCLK2_CLK>;
+ assigned-clocks = <&camcc CAM_CC_MCLK2_CLK>;
+ assigned-clock-rates = <24000000>;
+
+ dovdd-supply = <&vreg_l7f_1p8>;
+ avdd-supply = <&vdc_5v>;
+ dvdd-supply = <&vdc_5v>;
+
+ port {
+ imx577_ep: endpoint {
+ clock-lanes = <1>;
+ link-frequencies = /bits/ 64 <600000000>;
+ data-lanes = <1 2 3 4>;
+ remote-endpoint = <&csiphy2_ep>;
+ };
+ };
+ };
+};
diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index f28a8893d00d7..83604b9772766 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -3798,6 +3798,39 @@ tlmm: pinctrl@f100000 {
gpio-ranges = <&tlmm 0 0 181>;
wakeup-parent = <&pdc>;
+ cam2_default: cam2-default-state {
+ rst-pins {
+ pins = "gpio78";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ mclk-pins {
+ pins = "gpio96";
+ function = "cam_mclk";
+ drive-strength = <16>;
+ bias-disable;
+ };
+ };
+
+ cam2_suspend: cam2-suspend-state {
+ rst-pins {
+ pins = "gpio78";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-down;
+ output-low;
+ };
+
+ mclk-pins {
+ pins = "gpio96";
+ function = "cam_mclk";
+ drive-strength = <2>;
+ bias-disable;
+ };
+ };
+
cci0_default: cci0-default-state {
cci0_i2c0_default: cci0-i2c0-default-pins {
/* SDA, SCL */
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v4 2/3] arm64: dts: qcom: qrb5165-rb5-vision-mezzanine: Add vision mezzanine
2022-11-12 12:41 ` [PATCH v4 2/3] arm64: dts: qcom: qrb5165-rb5-vision-mezzanine: Add vision mezzanine Bryan O'Donoghue
@ 2022-11-12 13:13 ` Konrad Dybcio
0 siblings, 0 replies; 8+ messages in thread
From: Konrad Dybcio @ 2022-11-12 13:13 UTC (permalink / raw)
To: Bryan O'Donoghue, robert.foss, todor.too, agross, andersson,
mchehab, robh+dt, krzysztof.kozlowski+dt, dmitry.baryshkov,
vladimir.zapolskiy
Cc: sakari.ailus, hverkuil, laurent.pinchart, quic_mmitkov,
linux-media, linux-arm-msm, devicetree
Hi!
On 12/11/2022 13:41, Bryan O'Donoghue wrote:
> The Vision Mezzanine for the RB5 ships with an imx517 and ov9282 populated.
> Other sensors and components may be added or stacked with additional
> mezzanines.
>
> Enable both the IMX577
Sounds like a copypaste error?
>
> An example media-ctl pipeline for the imx577 is:
>
> media-ctl --reset
> media-ctl -v -d /dev/media0 -V '"imx577 '22-001a'":0[fmt:SRGGB10/4056x3040 field:none]'
> media-ctl -V '"msm_csiphy2":0[fmt:SRGGB10/4056x3040]'
> media-ctl -V '"msm_csid0":0[fmt:SRGGB10/4056x3040]'
> media-ctl -V '"msm_vfe0_rdi0":0[fmt:SRGGB10/4056x3040]'
> media-ctl -l '"msm_csiphy2":1->"msm_csid0":0[1]'
> media-ctl -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]'
>
> yavta -B capture-mplane -c -I -n 5 -f SRGGB10P -s 4056x3040 -F /dev/video0
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> .../dts/qcom/qrb5165-rb5-vision-mezzanine.dts | 63 +++++++++++++++++++
> arch/arm64/boot/dts/qcom/sm8250.dtsi | 33 ++++++++++
> 3 files changed, 97 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/qrb5165-rb5-vision-mezzanine.dts
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index d534888bcfe52..cd88efa19e750 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -54,6 +54,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-poplar.dtb
> dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb
> dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb
> dtb-$(CONFIG_ARCH_QCOM) += qrb5165-rb5.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += qrb5165-rb5-vision-mezzanine.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sa8155p-adp.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sa8295p-adp.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7180-idp.dtb
> diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5-vision-mezzanine.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5-vision-mezzanine.dts
> new file mode 100644
> index 0000000000000..315d524045cf3
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5-vision-mezzanine.dts
> @@ -0,0 +1,63 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2022, Linaro Ltd.
> + */
> +
> +/dts-v1/;
> +
> +#include "qrb5165-rb5.dts"
> +
Maybe setting
model = "Qualcomm Technologies, Inc. Robotics RB5 with Vision Mezzanine"
could be beneficial, so that when somebody shares a log, you can easily
differentiate between the two configurations. Not sure if that wouldn't
get too long too fast with different mezzanines..
> +&camss {
> + status = "okay";
Status should be last.
> + vdda-phy-supply = <&vreg_l5a_0p88>;
> + vdda-pll-supply = <&vreg_l9a_1p2>;
> +
> + ports {
> + /* The port index denotes CSIPHY id i.e. csiphy2 */
> + port@2 {
> + reg = <2>;
> + csiphy2_ep: endpoint {
> + clock-lanes = <7>;
> + data-lanes = <0 1 2 3>;
> + remote-endpoint = <&imx577_ep>;
> + };
> + };
> + };
> +};
> +
> +&camcc {
> + status = "okay";
camcc goes before camss alphabetically.
Konrad
> +};
> +
> +&cci1 {
> + status = "okay";
> +};
> +
> +&cci1_i2c0 {
> + camera@1a {
> + compatible = "sony,imx577";
> + reg = <0x1a>;
> +
> + reset-gpios = <&tlmm 78 GPIO_ACTIVE_LOW>;
> + pinctrl-names = "default", "suspend";
> + pinctrl-0 = <&cam2_default>;
> + pinctrl-1 = <&cam2_suspend>;
> +
> + clocks = <&camcc CAM_CC_MCLK2_CLK>;
> + assigned-clocks = <&camcc CAM_CC_MCLK2_CLK>;
> + assigned-clock-rates = <24000000>;
> +
> + dovdd-supply = <&vreg_l7f_1p8>;
> + avdd-supply = <&vdc_5v>;
> + dvdd-supply = <&vdc_5v>;
> +
> + port {
> + imx577_ep: endpoint {
> + clock-lanes = <1>;
> + link-frequencies = /bits/ 64 <600000000>;
> + data-lanes = <1 2 3 4>;
> + remote-endpoint = <&csiphy2_ep>;
> + };
> + };
> + };
> +};
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index f28a8893d00d7..83604b9772766 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -3798,6 +3798,39 @@ tlmm: pinctrl@f100000 {
> gpio-ranges = <&tlmm 0 0 181>;
> wakeup-parent = <&pdc>;
>
> + cam2_default: cam2-default-state {
> + rst-pins {
> + pins = "gpio78";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-disable;
> + };
> +
> + mclk-pins {
> + pins = "gpio96";
> + function = "cam_mclk";
> + drive-strength = <16>;
> + bias-disable;
> + };
> + };
> +
> + cam2_suspend: cam2-suspend-state {
> + rst-pins {
> + pins = "gpio78";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-pull-down;
> + output-low;
> + };
> +
> + mclk-pins {
> + pins = "gpio96";
> + function = "cam_mclk";
> + drive-strength = <2>;
> + bias-disable;
> + };
> + };
> +
> cci0_default: cci0-default-state {
> cci0_i2c0_default: cci0-i2c0-default-pins {
> /* SDA, SCL */
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v4 3/3] arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Add navigation mezzanine dts
2022-11-12 12:41 [PATCH v4 0/3] Switch on IMX577 on RB5 Bryan O'Donoghue
2022-11-12 12:41 ` [PATCH v4 1/3] arm64: dts: qcom: sm8250: camss: Define ports address/size cells Bryan O'Donoghue
2022-11-12 12:41 ` [PATCH v4 2/3] arm64: dts: qcom: qrb5165-rb5-vision-mezzanine: Add vision mezzanine Bryan O'Donoghue
@ 2022-11-12 12:41 ` Bryan O'Donoghue
2022-11-12 13:17 ` Konrad Dybcio
2022-11-14 10:00 ` Krzysztof Kozlowski
2 siblings, 2 replies; 8+ messages in thread
From: Bryan O'Donoghue @ 2022-11-12 12:41 UTC (permalink / raw)
To: robert.foss, todor.too, agross, andersson, konrad.dybcio, mchehab,
robh+dt, krzysztof.kozlowski+dt, dmitry.baryshkov,
vladimir.zapolskiy
Cc: sakari.ailus, hverkuil, laurent.pinchart, quic_mmitkov,
linux-media, linux-arm-msm, devicetree, Bryan O'Donoghue
Move the dts data for the rb3 navigation mezzanine into its own dts file.
Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
arch/arm64/boot/dts/qcom/Makefile | 1 +
.../sdm845-db845c-navigation-mezzanine.dts | 109 ++++++++++++++++++
arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 101 ----------------
3 files changed, 110 insertions(+), 101 deletions(-)
create mode 100644 arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dts
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index cd88efa19e750..5eadd251a0a16 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -132,6 +132,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r1.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r2.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r3.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm845-db845c.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sdm845-db845c-navigation-mezzanine.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm845-lg-judyln.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm845-lg-judyp.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm845-mtp.dtb
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dts
new file mode 100644
index 0000000000000..0862ca30c8963
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dts
@@ -0,0 +1,109 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2022, Linaro Ltd.
+ */
+
+/dts-v1/;
+
+#include "sdm845-db845c.dts"
+
+&cci {
+ status = "okay";
+};
+
+&camss {
+ vdda-phy-supply = <&vreg_l1a_0p875>;
+ vdda-pll-supply = <&vreg_l26a_1p2>;
+
+ status = "ok";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@0 {
+ reg = <0>;
+ csiphy0_ep: endpoint {
+ data-lanes = <0 1 2 3>;
+ remote-endpoint = <&ov8856_ep>;
+ };
+ };
+ };
+};
+
+&cci_i2c0 {
+ camera@10 {
+ compatible = "ovti,ov8856";
+ reg = <0x10>;
+
+ /* CAM0_RST_N */
+ reset-gpios = <&tlmm 9 GPIO_ACTIVE_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&cam0_default>;
+
+ clocks = <&clock_camcc CAM_CC_MCLK0_CLK>;
+ clock-names = "xvclk";
+ clock-frequency = <19200000>;
+
+ /*
+ * The &vreg_s4a_1p8 trace is powered on as a,
+ * so it is represented by a fixed regulator.
+ *
+ * The 2.8V vdda-supply and 1.2V vddd-supply regulators
+ * both have to be enabled through the power management
+ * gpios.
+ */
+ dovdd-supply = <&vreg_lvs1a_1p8>;
+ avdd-supply = <&cam0_avdd_2v8>;
+ dvdd-supply = <&cam0_dvdd_1v2>;
+
+ status = "ok";
+
+ port {
+ ov8856_ep: endpoint {
+ link-frequencies = /bits/ 64
+ <360000000 180000000>;
+ data-lanes = <1 2 3 4>;
+ remote-endpoint = <&csiphy0_ep>;
+ };
+ };
+ };
+};
+
+&cci_i2c1 {
+ camera@60 {
+ compatible = "ovti,ov7251";
+
+ /* I2C address as per ov7251.txt linux documentation */
+ reg = <0x60>;
+
+ /* CAM3_RST_N */
+ enable-gpios = <&tlmm 21 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&cam3_default>;
+
+ clocks = <&clock_camcc CAM_CC_MCLK3_CLK>;
+ clock-names = "xclk";
+ clock-frequency = <24000000>;
+
+ /*
+ * The &vreg_s4a_1p8 trace always powered on.
+ *
+ * The 2.8V vdda-supply regulator is enabled when the
+ * vreg_s4a_1p8 trace is pulled high.
+ * It too is represented by a fixed regulator.
+ *
+ * No 1.2V vddd-supply regulator is used.
+ */
+ vdddo-supply = <&vreg_lvs1a_1p8>;
+ vdda-supply = <&cam3_avdd_2v8>;
+
+ status = "disable";
+
+ port {
+ ov7251_ep: endpoint {
+ data-lanes = <0 1>;
+/* remote-endpoint = <&csiphy3_ep>; */
+ };
+ };
+ };
+};
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
index 3e7ceb0861eb0..f41c6d600ea8c 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
@@ -1174,107 +1174,6 @@ &pm8998_gpio {
};
-&cci {
- status = "okay";
-};
-
-&camss {
- vdda-phy-supply = <&vreg_l1a_0p875>;
- vdda-pll-supply = <&vreg_l26a_1p2>;
-
- status = "ok";
-
- ports {
- #address-cells = <1>;
- #size-cells = <0>;
- port@0 {
- reg = <0>;
- csiphy0_ep: endpoint {
- data-lanes = <0 1 2 3>;
- remote-endpoint = <&ov8856_ep>;
- };
- };
- };
-};
-
-&cci_i2c0 {
- camera@10 {
- compatible = "ovti,ov8856";
- reg = <0x10>;
-
- /* CAM0_RST_N */
- reset-gpios = <&tlmm 9 GPIO_ACTIVE_LOW>;
- pinctrl-names = "default";
- pinctrl-0 = <&cam0_default>;
-
- clocks = <&clock_camcc CAM_CC_MCLK0_CLK>;
- clock-names = "xvclk";
- clock-frequency = <19200000>;
-
- /*
- * The &vreg_s4a_1p8 trace is powered on as a,
- * so it is represented by a fixed regulator.
- *
- * The 2.8V vdda-supply and 1.2V vddd-supply regulators
- * both have to be enabled through the power management
- * gpios.
- */
- dovdd-supply = <&vreg_lvs1a_1p8>;
- avdd-supply = <&cam0_avdd_2v8>;
- dvdd-supply = <&cam0_dvdd_1v2>;
-
- status = "ok";
-
- port {
- ov8856_ep: endpoint {
- link-frequencies = /bits/ 64
- <360000000 180000000>;
- data-lanes = <1 2 3 4>;
- remote-endpoint = <&csiphy0_ep>;
- };
- };
- };
-};
-
-&cci_i2c1 {
- camera@60 {
- compatible = "ovti,ov7251";
-
- /* I2C address as per ov7251.txt linux documentation */
- reg = <0x60>;
-
- /* CAM3_RST_N */
- enable-gpios = <&tlmm 21 GPIO_ACTIVE_HIGH>;
- pinctrl-names = "default";
- pinctrl-0 = <&cam3_default>;
-
- clocks = <&clock_camcc CAM_CC_MCLK3_CLK>;
- clock-names = "xclk";
- clock-frequency = <24000000>;
-
- /*
- * The &vreg_s4a_1p8 trace always powered on.
- *
- * The 2.8V vdda-supply regulator is enabled when the
- * vreg_s4a_1p8 trace is pulled high.
- * It too is represented by a fixed regulator.
- *
- * No 1.2V vddd-supply regulator is used.
- */
- vdddo-supply = <&vreg_lvs1a_1p8>;
- vdda-supply = <&cam3_avdd_2v8>;
-
- status = "disable";
-
- port {
- ov7251_ep: endpoint {
- data-lanes = <0 1>;
-/* remote-endpoint = <&csiphy3_ep>; */
- };
- };
- };
-};
-
/* PINCTRL - additions to nodes defined in sdm845.dtsi */
&qup_spi0_default {
config {
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v4 3/3] arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Add navigation mezzanine dts
2022-11-12 12:41 ` [PATCH v4 3/3] arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Add navigation mezzanine dts Bryan O'Donoghue
@ 2022-11-12 13:17 ` Konrad Dybcio
2022-11-12 14:37 ` Bryan O'Donoghue
2022-11-14 10:00 ` Krzysztof Kozlowski
1 sibling, 1 reply; 8+ messages in thread
From: Konrad Dybcio @ 2022-11-12 13:17 UTC (permalink / raw)
To: Bryan O'Donoghue, robert.foss, todor.too, agross, andersson,
mchehab, robh+dt, krzysztof.kozlowski+dt, dmitry.baryshkov,
vladimir.zapolskiy
Cc: sakari.ailus, hverkuil, laurent.pinchart, quic_mmitkov,
linux-media, linux-arm-msm, devicetree
On 12/11/2022 13:41, Bryan O'Donoghue wrote:
> Move the dts data for the rb3 navigation mezzanine into its own dts file.
>
> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> .../sdm845-db845c-navigation-mezzanine.dts | 109 ++++++++++++++++++
> arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 101 ----------------
> 3 files changed, 110 insertions(+), 101 deletions(-)
> create mode 100644 arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dts
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index cd88efa19e750..5eadd251a0a16 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -132,6 +132,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r1.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r2.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r3.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-db845c.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += sdm845-db845c-navigation-mezzanine.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-lg-judyln.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-lg-judyp.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-mtp.dtb
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dts
> new file mode 100644
> index 0000000000000..0862ca30c8963
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dts
> @@ -0,0 +1,109 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2022, Linaro Ltd.
> + */
> +
> +/dts-v1/;
> +
> +#include "sdm845-db845c.dts"
> +
> +&cci {
> + status = "okay";
> +};
> +
> +&camss {
> + vdda-phy-supply = <&vreg_l1a_0p875>;
> + vdda-pll-supply = <&vreg_l26a_1p2>;
> +
> + status = "ok";
"okay" is preferred.
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
Looks like the -cells properties are defined in 845 dtsi already.
> + port@0 {
> + reg = <0>;
> + csiphy0_ep: endpoint {
> + data-lanes = <0 1 2 3>;
> + remote-endpoint = <&ov8856_ep>;
> + };
> + };
> + };
> +};
> +
> +&cci_i2c0 {
> + camera@10 {
> + compatible = "ovti,ov8856";
> + reg = <0x10>;
> +
> + /* CAM0_RST_N */
> + reset-gpios = <&tlmm 9 GPIO_ACTIVE_LOW>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&cam0_default>;
> +
> + clocks = <&clock_camcc CAM_CC_MCLK0_CLK>;
> + clock-names = "xvclk";
> + clock-frequency = <19200000>;
> +
> + /*
> + * The &vreg_s4a_1p8 trace is powered on as a,
> + * so it is represented by a fixed regulator.
> + *
> + * The 2.8V vdda-supply and 1.2V vddd-supply regulators
> + * both have to be enabled through the power management
> + * gpios.
> + */
> + dovdd-supply = <&vreg_lvs1a_1p8>;
> + avdd-supply = <&cam0_avdd_2v8>;
> + dvdd-supply = <&cam0_dvdd_1v2>;
> +
> + status = "ok";
"okay" is prefered.
> +
> + port {
> + ov8856_ep: endpoint {
> + link-frequencies = /bits/ 64
> + <360000000 180000000>;
> + data-lanes = <1 2 3 4>;
> + remote-endpoint = <&csiphy0_ep>;
> + };
> + };
> + };
> +};
> +
> +&cci_i2c1 {
> + camera@60 {
> + compatible = "ovti,ov7251";
> +
> + /* I2C address as per ov7251.txt linux documentation */
> + reg = <0x60>;
> +
> + /* CAM3_RST_N */
> + enable-gpios = <&tlmm 21 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&cam3_default>;
> +
> + clocks = <&clock_camcc CAM_CC_MCLK3_CLK>;
> + clock-names = "xclk";
> + clock-frequency = <24000000>;
> +
> + /*
> + * The &vreg_s4a_1p8 trace always powered on.
> + *
> + * The 2.8V vdda-supply regulator is enabled when the
> + * vreg_s4a_1p8 trace is pulled high.
> + * It too is represented by a fixed regulator.
> + *
> + * No 1.2V vddd-supply regulator is used.
> + */
> + vdddo-supply = <&vreg_lvs1a_1p8>;
> + vdda-supply = <&cam3_avdd_2v8>;
> +
> + status = "disable";
Missing d
Konrad
> +
> + port {
> + ov7251_ep: endpoint {
> + data-lanes = <0 1>;
> +/* remote-endpoint = <&csiphy3_ep>; */
> + };
> + };
> + };
> +};
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> index 3e7ceb0861eb0..f41c6d600ea8c 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> @@ -1174,107 +1174,6 @@ &pm8998_gpio {
>
> };
>
> -&cci {
> - status = "okay";
> -};
> -
> -&camss {
> - vdda-phy-supply = <&vreg_l1a_0p875>;
> - vdda-pll-supply = <&vreg_l26a_1p2>;
> -
> - status = "ok";
> -
> - ports {
> - #address-cells = <1>;
> - #size-cells = <0>;
> - port@0 {
> - reg = <0>;
> - csiphy0_ep: endpoint {
> - data-lanes = <0 1 2 3>;
> - remote-endpoint = <&ov8856_ep>;
> - };
> - };
> - };
> -};
> -
> -&cci_i2c0 {
> - camera@10 {
> - compatible = "ovti,ov8856";
> - reg = <0x10>;
> -
> - /* CAM0_RST_N */
> - reset-gpios = <&tlmm 9 GPIO_ACTIVE_LOW>;
> - pinctrl-names = "default";
> - pinctrl-0 = <&cam0_default>;
> -
> - clocks = <&clock_camcc CAM_CC_MCLK0_CLK>;
> - clock-names = "xvclk";
> - clock-frequency = <19200000>;
> -
> - /*
> - * The &vreg_s4a_1p8 trace is powered on as a,
> - * so it is represented by a fixed regulator.
> - *
> - * The 2.8V vdda-supply and 1.2V vddd-supply regulators
> - * both have to be enabled through the power management
> - * gpios.
> - */
> - dovdd-supply = <&vreg_lvs1a_1p8>;
> - avdd-supply = <&cam0_avdd_2v8>;
> - dvdd-supply = <&cam0_dvdd_1v2>;
> -
> - status = "ok";
> -
> - port {
> - ov8856_ep: endpoint {
> - link-frequencies = /bits/ 64
> - <360000000 180000000>;
> - data-lanes = <1 2 3 4>;
> - remote-endpoint = <&csiphy0_ep>;
> - };
> - };
> - };
> -};
> -
> -&cci_i2c1 {
> - camera@60 {
> - compatible = "ovti,ov7251";
> -
> - /* I2C address as per ov7251.txt linux documentation */
> - reg = <0x60>;
> -
> - /* CAM3_RST_N */
> - enable-gpios = <&tlmm 21 GPIO_ACTIVE_HIGH>;
> - pinctrl-names = "default";
> - pinctrl-0 = <&cam3_default>;
> -
> - clocks = <&clock_camcc CAM_CC_MCLK3_CLK>;
> - clock-names = "xclk";
> - clock-frequency = <24000000>;
> -
> - /*
> - * The &vreg_s4a_1p8 trace always powered on.
> - *
> - * The 2.8V vdda-supply regulator is enabled when the
> - * vreg_s4a_1p8 trace is pulled high.
> - * It too is represented by a fixed regulator.
> - *
> - * No 1.2V vddd-supply regulator is used.
> - */
> - vdddo-supply = <&vreg_lvs1a_1p8>;
> - vdda-supply = <&cam3_avdd_2v8>;
> -
> - status = "disable";
> -
> - port {
> - ov7251_ep: endpoint {
> - data-lanes = <0 1>;
> -/* remote-endpoint = <&csiphy3_ep>; */
> - };
> - };
> - };
> -};
> -
> /* PINCTRL - additions to nodes defined in sdm845.dtsi */
> &qup_spi0_default {
> config {
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v4 3/3] arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Add navigation mezzanine dts
2022-11-12 13:17 ` Konrad Dybcio
@ 2022-11-12 14:37 ` Bryan O'Donoghue
0 siblings, 0 replies; 8+ messages in thread
From: Bryan O'Donoghue @ 2022-11-12 14:37 UTC (permalink / raw)
To: Konrad Dybcio, robert.foss, todor.too, agross, andersson, mchehab,
robh+dt, krzysztof.kozlowski+dt, dmitry.baryshkov,
vladimir.zapolskiy
Cc: sakari.ailus, hverkuil, laurent.pinchart, quic_mmitkov,
linux-media, linux-arm-msm, devicetree
On 12/11/2022 13:17, Konrad Dybcio wrote:
>
>
> On 12/11/2022 13:41, Bryan O'Donoghue wrote:
>> Move the dts data for the rb3 navigation mezzanine into its own dts file.
>>
>> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/Makefile | 1 +
>> .../sdm845-db845c-navigation-mezzanine.dts | 109 ++++++++++++++++++
>> arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 101 ----------------
>> 3 files changed, 110 insertions(+), 101 deletions(-)
>> create mode 100644
>> arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dts
>>
>> diff --git a/arch/arm64/boot/dts/qcom/Makefile
>> b/arch/arm64/boot/dts/qcom/Makefile
>> index cd88efa19e750..5eadd251a0a16 100644
>> --- a/arch/arm64/boot/dts/qcom/Makefile
>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>> @@ -132,6 +132,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r1.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r2.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r3.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sdm845-db845c.dtb
>> +dtb-$(CONFIG_ARCH_QCOM) += sdm845-db845c-navigation-mezzanine.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sdm845-lg-judyln.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sdm845-lg-judyp.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += sdm845-mtp.dtb
>> diff --git
>> a/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dts
>> b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dts
>> new file mode 100644
>> index 0000000000000..0862ca30c8963
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dts
>> @@ -0,0 +1,109 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Copyright (c) 2022, Linaro Ltd.
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "sdm845-db845c.dts"
>> +
>> +&cci {
>> + status = "okay";
>> +};
>> +
>> +&camss {
>> + vdda-phy-supply = <&vreg_l1a_0p875>;
>> + vdda-pll-supply = <&vreg_l26a_1p2>;
>> +
>> + status = "ok";
> "okay" is preferred.
>
>> +
>> + ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
> Looks like the -cells properties are defined in 845 dtsi already.
>
>
>> + port@0 {
>> + reg = <0>;
>> + csiphy0_ep: endpoint {
>> + data-lanes = <0 1 2 3>;
>> + remote-endpoint = <&ov8856_ep>;
>> + };
>> + };
>> + };
>> +};
>> +
>> +&cci_i2c0 {
>> + camera@10 {
>> + compatible = "ovti,ov8856";
>> + reg = <0x10>;
>> +
>> + /* CAM0_RST_N */
>> + reset-gpios = <&tlmm 9 GPIO_ACTIVE_LOW>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&cam0_default>;
>> +
>> + clocks = <&clock_camcc CAM_CC_MCLK0_CLK>;
>> + clock-names = "xvclk";
>> + clock-frequency = <19200000>;
>> +
>> + /*
>> + * The &vreg_s4a_1p8 trace is powered on as a,
>> + * so it is represented by a fixed regulator.
>> + *
>> + * The 2.8V vdda-supply and 1.2V vddd-supply regulators
>> + * both have to be enabled through the power management
>> + * gpios.
>> + */
>> + dovdd-supply = <&vreg_lvs1a_1p8>;
>> + avdd-supply = <&cam0_avdd_2v8>;
>> + dvdd-supply = <&cam0_dvdd_1v2>;
>> +
>> + status = "ok";
> "okay" is prefered.
>
>> +
>> + port {
>> + ov8856_ep: endpoint {
>> + link-frequencies = /bits/ 64
>> + <360000000 180000000>;
>> + data-lanes = <1 2 3 4>;
>> + remote-endpoint = <&csiphy0_ep>;
>> + };
>> + };
>> + };
>> +};
>> +
>> +&cci_i2c1 {
>> + camera@60 {
>> + compatible = "ovti,ov7251";
>> +
>> + /* I2C address as per ov7251.txt linux documentation */
>> + reg = <0x60>;
>> +
>> + /* CAM3_RST_N */
>> + enable-gpios = <&tlmm 21 GPIO_ACTIVE_HIGH>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&cam3_default>;
>> +
>> + clocks = <&clock_camcc CAM_CC_MCLK3_CLK>;
>> + clock-names = "xclk";
>> + clock-frequency = <24000000>;
>> +
>> + /*
>> + * The &vreg_s4a_1p8 trace always powered on.
>> + *
>> + * The 2.8V vdda-supply regulator is enabled when the
>> + * vreg_s4a_1p8 trace is pulled high.
>> + * It too is represented by a fixed regulator.
>> + *
>> + * No 1.2V vddd-supply regulator is used.
>> + */
>> + vdddo-supply = <&vreg_lvs1a_1p8>;
>> + vdda-supply = <&cam3_avdd_2v8>;
>> +
>> + status = "disable";
> Missing d
>
> Konrad
>> +
>> + port {
>> + ov7251_ep: endpoint {
>> + data-lanes = <0 1>;
>> +/* remote-endpoint = <&csiphy3_ep>; */
>> + };
>> + };
>> + };
>> +};
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
>> b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
>> index 3e7ceb0861eb0..f41c6d600ea8c 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
>> @@ -1174,107 +1174,6 @@ &pm8998_gpio {
>> };
>> -&cci {
>> - status = "okay";
>> -};
>> -
>> -&camss {
>> - vdda-phy-supply = <&vreg_l1a_0p875>;
>> - vdda-pll-supply = <&vreg_l26a_1p2>;
>> -
>> - status = "ok";
>> -
>> - ports {
>> - #address-cells = <1>;
>> - #size-cells = <0>;
>> - port@0 {
>> - reg = <0>;
>> - csiphy0_ep: endpoint {
>> - data-lanes = <0 1 2 3>;
>> - remote-endpoint = <&ov8856_ep>;
>> - };
>> - };
>> - };
>> -};
>> -
>> -&cci_i2c0 {
>> - camera@10 {
>> - compatible = "ovti,ov8856";
>> - reg = <0x10>;
>> -
>> - /* CAM0_RST_N */
>> - reset-gpios = <&tlmm 9 GPIO_ACTIVE_LOW>;
>> - pinctrl-names = "default";
>> - pinctrl-0 = <&cam0_default>;
>> -
>> - clocks = <&clock_camcc CAM_CC_MCLK0_CLK>;
>> - clock-names = "xvclk";
>> - clock-frequency = <19200000>;
>> -
>> - /*
>> - * The &vreg_s4a_1p8 trace is powered on as a,
>> - * so it is represented by a fixed regulator.
>> - *
>> - * The 2.8V vdda-supply and 1.2V vddd-supply regulators
>> - * both have to be enabled through the power management
>> - * gpios.
>> - */
>> - dovdd-supply = <&vreg_lvs1a_1p8>;
>> - avdd-supply = <&cam0_avdd_2v8>;
>> - dvdd-supply = <&cam0_dvdd_1v2>;
>> -
>> - status = "ok";
>> -
>> - port {
>> - ov8856_ep: endpoint {
>> - link-frequencies = /bits/ 64
>> - <360000000 180000000>;
>> - data-lanes = <1 2 3 4>;
>> - remote-endpoint = <&csiphy0_ep>;
>> - };
>> - };
>> - };
>> -};
>> -
>> -&cci_i2c1 {
>> - camera@60 {
>> - compatible = "ovti,ov7251";
>> -
>> - /* I2C address as per ov7251.txt linux documentation */
>> - reg = <0x60>;
>> -
>> - /* CAM3_RST_N */
>> - enable-gpios = <&tlmm 21 GPIO_ACTIVE_HIGH>;
>> - pinctrl-names = "default";
>> - pinctrl-0 = <&cam3_default>;
>> -
>> - clocks = <&clock_camcc CAM_CC_MCLK3_CLK>;
>> - clock-names = "xclk";
>> - clock-frequency = <24000000>;
>> -
>> - /*
>> - * The &vreg_s4a_1p8 trace always powered on.
>> - *
>> - * The 2.8V vdda-supply regulator is enabled when the
>> - * vreg_s4a_1p8 trace is pulled high.
>> - * It too is represented by a fixed regulator.
>> - *
>> - * No 1.2V vddd-supply regulator is used.
>> - */
>> - vdddo-supply = <&vreg_lvs1a_1p8>;
>> - vdda-supply = <&cam3_avdd_2v8>;
>> -
>> - status = "disable";
>> -
>> - port {
>> - ov7251_ep: endpoint {
>> - data-lanes = <0 1>;
>> -/* remote-endpoint = <&csiphy3_ep>; */
>> - };
>> - };
>> - };
>> -};
>> -
>> /* PINCTRL - additions to nodes defined in sdm845.dtsi */
>> &qup_spi0_default {
>> config {
Hmm.
I wasn't really looking to do anything other than move existing upstream
stuff from one location to another.
But, since you flag it I will generate a number of Fixes: and append
them to the head of this series.
---
bod
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 3/3] arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Add navigation mezzanine dts
2022-11-12 12:41 ` [PATCH v4 3/3] arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Add navigation mezzanine dts Bryan O'Donoghue
2022-11-12 13:17 ` Konrad Dybcio
@ 2022-11-14 10:00 ` Krzysztof Kozlowski
1 sibling, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-14 10:00 UTC (permalink / raw)
To: Bryan O'Donoghue, robert.foss, todor.too, agross, andersson,
konrad.dybcio, mchehab, robh+dt, krzysztof.kozlowski+dt,
dmitry.baryshkov, vladimir.zapolskiy
Cc: sakari.ailus, hverkuil, laurent.pinchart, quic_mmitkov,
linux-media, linux-arm-msm, devicetree
On 12/11/2022 13:41, Bryan O'Donoghue wrote:
> Move the dts data for the rb3 navigation mezzanine into its own dts file.
>
> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> .../sdm845-db845c-navigation-mezzanine.dts | 109 ++++++++++++++++++
> arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 101 ----------------
> 3 files changed, 110 insertions(+), 101 deletions(-)
> create mode 100644 arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dts
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index cd88efa19e750..5eadd251a0a16 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -132,6 +132,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r1.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r2.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r3.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-db845c.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += sdm845-db845c-navigation-mezzanine.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-lg-judyln.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-lg-judyp.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-mtp.dtb
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dts
> new file mode 100644
> index 0000000000000..0862ca30c8963
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dts
> @@ -0,0 +1,109 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2022, Linaro Ltd.
> + */
> +
> +/dts-v1/;
> +
> +#include "sdm845-db845c.dts"
> +
> +&cci {
> + status = "okay";
> +};
> +
> +&camss {
> + vdda-phy-supply = <&vreg_l1a_0p875>;
> + vdda-pll-supply = <&vreg_l26a_1p2>;
> +
> + status = "ok";
These are "okay".
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@0 {
> + reg = <0>;
> + csiphy0_ep: endpoint {
> + data-lanes = <0 1 2 3>;
> + remote-endpoint = <&ov8856_ep>;
> + };
> + };
> + };
> +};
> +
> +&cci_i2c0 {
> + camera@10 {
> + compatible = "ovti,ov8856";
> + reg = <0x10>;
> +
> + /* CAM0_RST_N */
> + reset-gpios = <&tlmm 9 GPIO_ACTIVE_LOW>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&cam0_default>;
> +
> + clocks = <&clock_camcc CAM_CC_MCLK0_CLK>;
> + clock-names = "xvclk";
> + clock-frequency = <19200000>;
> +
> + /*
> + * The &vreg_s4a_1p8 trace is powered on as a,
> + * so it is represented by a fixed regulator.
> + *
> + * The 2.8V vdda-supply and 1.2V vddd-supply regulators
> + * both have to be enabled through the power management
> + * gpios.
> + */
> + dovdd-supply = <&vreg_lvs1a_1p8>;
> + avdd-supply = <&cam0_avdd_2v8>;
> + dvdd-supply = <&cam0_dvdd_1v2>;
> +
> + status = "ok";
drop
> +
> + port {
> + ov8856_ep: endpoint {
> + link-frequencies = /bits/ 64
> + <360000000 180000000>;
> + data-lanes = <1 2 3 4>;
> + remote-endpoint = <&csiphy0_ep>;
> + };
> + };
> + };
> +};
> +
> +&cci_i2c1 {
> + camera@60 {
> + compatible = "ovti,ov7251";
> +
> + /* I2C address as per ov7251.txt linux documentation */
> + reg = <0x60>;
> +
> + /* CAM3_RST_N */
> + enable-gpios = <&tlmm 21 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&cam3_default>;
> +
> + clocks = <&clock_camcc CAM_CC_MCLK3_CLK>;
> + clock-names = "xclk";
> + clock-frequency = <24000000>;
> +
> + /*
> + * The &vreg_s4a_1p8 trace always powered on.
> + *
> + * The 2.8V vdda-supply regulator is enabled when the
> + * vreg_s4a_1p8 trace is pulled high.
> + * It too is represented by a fixed regulator.
> + *
> + * No 1.2V vddd-supply regulator is used.
> + */
> + vdddo-supply = <&vreg_lvs1a_1p8>;
> + vdda-supply = <&cam3_avdd_2v8>;
> +
> + status = "disable";
> +
> + port {
> + ov7251_ep: endpoint {
> + data-lanes = <0 1>;
> +/* remote-endpoint = <&csiphy3_ep>; */
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread