Re: [PATCH v3 08/13] ARM: dts: microchip: sama7d65: Add ADC node

[Claudiu Beznea <claudiu.beznea@tuxon.dev>]

Hi, Varshini,

On 6/30/26 12:35, Varshini Rajendran wrote:
> Add node for the ADC controller in sama7d65 SoC. Add the vddout25 fixed
> regulator node which provides the 2.5V reference voltage for the ADC.
> 
> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
> ---
>   arch/arm/boot/dts/microchip/sama7d65.dtsi | 29 +++++++++++++++++++++++
>   1 file changed, 29 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/microchip/sama7d65.dtsi b/arch/arm/boot/dts/microchip/sama7d65.dtsi
> index 94d49e20dc79..ba775459a816 100644
> --- a/arch/arm/boot/dts/microchip/sama7d65.dtsi
> +++ b/arch/arm/boot/dts/microchip/sama7d65.dtsi
> @@ -11,6 +11,7 @@
>   #include <dt-bindings/clock/at91.h>
>   #include <dt-bindings/dma/at91.h>
>   #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/iio/adc/at91-sama5d2_adc.h>
>   #include <dt-bindings/interrupt-controller/arm-gic.h>
>   #include <dt-bindings/interrupt-controller/irq.h>
>   #include <dt-bindings/mfd/at91-usart.h>
> @@ -95,6 +96,16 @@ slow_xtal: clock-slowxtal {
>   		};
>   	};
>   
> +	vddout25: fixed-regulator-vddout25 {
> +		compatible = "regulator-fixed";
> +

This line could be dropped.

> +		regulator-name = "VDDOUT25";
> +		regulator-min-microvolt = <2500000>;
> +		regulator-max-microvolt = <2500000>;
> +		regulator-boot-on;
> +		status = "disabled";
> +	};
> +
>   	ns_sram: sram@100000 {
>   		compatible = "mmio-sram";
>   		reg = <0x100000 0x20000>;
> @@ -296,6 +307,24 @@ can4: can@e0838000 {
>   			status = "disabled";
>   		};
>   
> +		adc: adc@e1000000 {
> +			compatible = "microchip,sama7d65-adc";
> +			reg = <0xe1000000 0x200>;
> +			interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&pmc PMC_TYPE_GCK 25>;
> +			assigned-clocks = <&pmc PMC_TYPE_GCK 25>;
> +			assigned-clock-rates = <100000000>;
> +			clock-names = "adc_clk";

clock-names usually goes after clocks.

> +			dmas = <&dma0 AT91_XDMAC_DT_PERID(0)>;
> +			dma-names = "rx";
> +			atmel,min-sample-rate-hz = <200000>;
> +			atmel,max-sample-rate-hz = <20000000>;
> +			atmel,trigger-edge-type = <IRQ_TYPE_EDGE_RISING>;
> +			atmel,startup-time-ms = <4>;
> +			#io-channel-cells = <1>;

This could be moved before vendor specific properties since it's standard.

I can address all these while applying, if any.

Thank you,
Claudiu

> +			status = "disabled";
> +		};
> +
>   		dma2: dma-controller@e1200000 {
>   			compatible = "microchip,sama7d65-dma", "microchip,sama7g5-dma";
>   			reg = <0xe1200000 0x1000>;