From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
heiko@sntech.de
Cc: martijn@brixit.nl, ayufan@ayufan.eu, megi@xff.cz,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, phone-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] arm64: dts: rockchip: Add initial support for Pine64 PinePhone Pro
Date: Tue, 16 Aug 2022 10:52:01 +0300 [thread overview]
Message-ID: <a11bc22e-a10e-7d15-72d2-6af1d4790695@linaro.org> (raw)
In-Reply-To: <20220815123004.252014-3-tom@tom-fitzhenry.me.uk>
On 15/08/2022 15:30, Tom Fitzhenry wrote:
> +
> +/dts-v1/;
> +#include <dt-bindings/input/linux-event-codes.h>
> +#include "rk3399.dtsi"
> +#include "rk3399-opp.dtsi"
> +
> +/ {
> + model = "Pine64 PinePhonePro";
> + compatible = "pine64,pinephone-pro", "rockchip,rk3399";
> + chassis-type = "handset";
> +
> + aliases {
> + mmc0 = &sdio0;
> + mmc1 = &sdmmc;
> + mmc2 = &sdhci;
> + };
> +
> + chosen {
> + stdout-path = "serial2:115200n8";
> + };
> +
> + gpio-keys {
> + compatible = "gpio-keys";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pwrbtn_pin>;
> +
> + power {
Still wrong. Do not ignore comments and test your DTS with dtbs_check.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-16 9:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 12:30 [PATCH v3 0/2] Add support for the Pine64 PinePhone Pro phone Tom Fitzhenry
2022-08-15 12:30 ` [PATCH v3 1/2] dt-bindings: arm: rockchip: Add PinePhone Pro bindings Tom Fitzhenry
2022-08-15 22:27 ` Caleb Connolly
2022-08-16 7:50 ` Krzysztof Kozlowski
2022-08-15 12:30 ` [PATCH v3 2/2] arm64: dts: rockchip: Add initial support for Pine64 PinePhone Pro Tom Fitzhenry
2022-08-15 22:26 ` Caleb Connolly
2022-08-16 7:52 ` Krzysztof Kozlowski [this message]
2022-08-22 0:04 ` Tom Fitzhenry
2022-08-18 3:05 ` Nícolas F. R. A. Prado
2022-08-21 9:00 ` Ondřej Jirman
2022-08-21 9:04 ` Ondřej Jirman
2022-08-22 0:23 ` Tom Fitzhenry
2022-08-22 0:19 ` Tom Fitzhenry
2022-08-21 0:11 ` Nícolas F. R. A. Prado
2022-08-22 0:33 ` Tom Fitzhenry
2022-09-04 17:22 ` (subset) [PATCH v3 0/2] Add support for the Pine64 PinePhone Pro phone Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a11bc22e-a10e-7d15-72d2-6af1d4790695@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=ayufan@ayufan.eu \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=martijn@brixit.nl \
--cc=megi@xff.cz \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tom@tom-fitzhenry.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).