From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BADD9EB64DC for ; Tue, 18 Jul 2023 18:01:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231422AbjGRSBt (ORCPT ); Tue, 18 Jul 2023 14:01:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230379AbjGRSBo (ORCPT ); Tue, 18 Jul 2023 14:01:44 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12D411BC3 for ; Tue, 18 Jul 2023 11:01:39 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-98377c5d53eso807004166b.0 for ; Tue, 18 Jul 2023 11:01:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689703297; x=1692295297; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GkVGM62mLoDf1421cn8cwTEotQIx3Vb8NTgK8HMMhLs=; b=zChok7gLqa3CeX8YEWNGoSPxHG7oVyaI4+5EvYswkjR8IqeKcdDVxDaeSFeDUxvPbe bzhLSaNLT4Keg26LYPhrh0NXkFCzQ79n4Rno3rIBtz+XJj2ROIPIc84IgaWhUbnaTOo/ yRlRL6+X9fG6D1WAWsv6xLsdHAtvQ5esp4a2NECiLsXySWQSjp1LJiCOp3QdoRrg1med ElwcBadNtrVzGLlxpXSMW7yFnqw85uISx8daZ30f210Zte0h35C3oc+0zqvvTriJ2+rJ REIqn2gbNR4NaGyCE1HgpDJXWkS0FRIOFLWqK9RXB1KfZRlv5bSrqLqg9vhOAmdQ58Zh JGyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689703297; x=1692295297; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GkVGM62mLoDf1421cn8cwTEotQIx3Vb8NTgK8HMMhLs=; b=Ftq2+PIn/uuQ5r+BqvKoIrRLpb/LGUhwNSq+x/fS63HMPCrMiul6ITGSFoiV0c+vCI 1/cW2HUJdXAxkIhzz768s5h4W8lYVZJkP87Ej+MKd8f83fDCWef+Psv+ebaPry82Mp+k UvwVBiFSp1xQ7QM5K5nWqp9zfL9m7SDlDyFdlDkvIB9LB5TcKAW5FXNEiayKw2JqwlhT rBI8J++Y3AG1LGWh2h9CGRIbeZmII40LwsG06b942CsFaRrAd81m566TgWwz5SaG5Uxn BnErjrC+WcZqelXGbN+pvdap7RE5YWxuxKgy8MPcTJQNu15zoJL+zc3Ae6+vhw4xlspU t7Vw== X-Gm-Message-State: ABy/qLbMDNcvpSo3rS1ih+76Fj3etUqVG7LhMa+sSg8KFjOFCY7UHG7H XECUMqmpI7+WOE/yJoUTm4cqfg== X-Google-Smtp-Source: APBJJlFhWjdgZ1ezpyp222J0MdGWAGjVP8OoiENBNp0TYKiVYjOrc3M21q/BeICF5P2a9vwFoqzFgw== X-Received: by 2002:a17:906:53c7:b0:988:9ec1:a8c5 with SMTP id p7-20020a17090653c700b009889ec1a8c5mr340449ejo.55.1689703297677; Tue, 18 Jul 2023 11:01:37 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id ks20-20020a170906f85400b0098e0a937a6asm1299075ejb.69.2023.07.18.11.01.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jul 2023 11:01:37 -0700 (PDT) Message-ID: Date: Tue, 18 Jul 2023 20:01:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/2] dt-bindings: reset: Updated binding for Versal-NET reset driver Content-Language: en-US To: Michal Simek , Conor Dooley , Piyush Mehta Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, p.zabel@pengutronix.de, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, git@amd.com References: <20230717112348.1381367-1-piyush.mehta@amd.com> <20230717112348.1381367-2-piyush.mehta@amd.com> <20230717-explode-caucus-82c12e340e39@spud> <694a1314-0b25-ff5e-b19f-5a0efe07bf64@linaro.org> <22e7dc73-2411-5cb1-6cef-daa5f2af8297@linaro.org> <5df3e976-9fc2-19af-e6b4-e2bea0d64623@amd.com> <4c932cbf-19db-2c88-2558-aa42c5338598@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/07/2023 16:30, Michal Simek wrote: >>> >>> Please correct me if I am wrong. Description about ID should be removed from >>> commit message because it is not necessary. And >>> include/dt-bindings/reset/xlnx-versal-net-resets.h >>> should be added when we merge also DT for versal-net SOC. >> >> No, the binding header is needed only if driver is using it. Adding DTS >> will not change that - still no kernel driver users. No benefits of such >> binding. If there are no users and no benefits - don't make it a binding. > > But header in board folder should be fine like these. > arch/arm64/boot/dts/mediatek/mt2712-pinfunc.h > arch/arm64/boot/dts/mediatek/mt8516-pinfunc.h > arch/arm64/boot/dts/mediatek/mt8167-pinfunc.h > arch/arm64/boot/dts/mediatek/mt8173-pinfunc.h > arch/arm64/boot/dts/exynos/exynos-pinctrl.h > arch/arm64/boot/dts/freescale/imx8mq-pinfunc.h > arch/arm64/boot/dts/freescale/imx8mp-pinfunc.h > arch/arm64/boot/dts/freescale/imx8mn-pinfunc.h > arch/arm64/boot/dts/freescale/imx93-pinfunc.h > arch/arm64/boot/dts/freescale/imx8ulp-pinfunc.h > arch/arm64/boot/dts/freescale/imx8mm-pinfunc.h > arch/arm64/boot/dts/tesla/fsd-pinctrl.h Yes. If you want to store some constants (register values, firmware magic numbers) and use in DTS, this is the way to go. Most (or all) of examples above are for register values. Best regards, Krzysztof