From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14CAEC6FD19 for ; Mon, 13 Mar 2023 17:03:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229656AbjCMRD2 (ORCPT ); Mon, 13 Mar 2023 13:03:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229961AbjCMRDM (ORCPT ); Mon, 13 Mar 2023 13:03:12 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A00C07C9EB for ; Mon, 13 Mar 2023 10:02:26 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id h9so13342727ljq.2 for ; Mon, 13 Mar 2023 10:02:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678726880; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=f1RDtAGLj0Ru2Y2XZ1WbfrRwXcKezO5xKtNrT7rLq4M=; b=i1ay3requ062Q/P51oQcvpIxd3HoiBx9BQwoVQO1GtfP+yzxTw8KHfJZBVsDkNdwvF FTT9RMf3tIsG7hgHOu5wxE0BdczImUtinFEPCCYjiDFX0l86vBTNANw4uVm05AgktBki YZaKPwua9xHwGRJx72zFISfXk31qhYvUTweQnMGIV39d8yUslUPKfxCaTNvczoqcM2Rs EfQif4dAfLOImmbBoDpVDKktpcv5ineqKKfuoRL35/EK9A7+oj5KkMljtIrWL8MjaGZa 0TmsddaTpYbHDk27jt4kJQp4VvvF4Jy+o7T5Nl/lBR68qgRp2cdxlt0XP73ZjZHK8MDA zpdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678726880; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f1RDtAGLj0Ru2Y2XZ1WbfrRwXcKezO5xKtNrT7rLq4M=; b=I+N2mWLUDPzquiuE4WCDrHeILVTyt9SQlFqMOoJdewS0IQDG0Lx6KRMPqjO4T4v7Jt IVed8xkjbMA2e1cSEWBhFwX+/URvcpuJX84XWDLnscUTmipjXkdiLoaBesMKc/xrp2iw HyLAR+GwDWF6GzC2GoLboeYrDRB81evnYBJRjwfyDu5XMHJWF1dJDn/ZLDB6VKZWBcWS t9L4sdQNq3RfaPq7sWw7vV4KNL29P7QOZZMoZvAkp4DU5b/bqydLKkX0AADAY//c+Bm0 KbN7gvDUUEn/gH/UzZQpuur616yPmhtpNgFliBKswIw8zgrdZdr3K+R7T2UCBhlHmki5 2Qwg== X-Gm-Message-State: AO0yUKXlL+aKLz/9ifWzv8gURk6qAvs9facZdsAEBLsAcG43KbrHfiLD B9z6loIqQXDjcgD2T+mK9Y3utg== X-Google-Smtp-Source: AK7set9ikAiz3Ii8WfPk13mIVyXmlhmTfMzPl5IqSmp1dTqqDaWFactO+pFjYLfz/l/Tyotkzw2nZQ== X-Received: by 2002:a2e:99c4:0:b0:293:4d57:7148 with SMTP id l4-20020a2e99c4000000b002934d577148mr10860247ljj.11.1678726880222; Mon, 13 Mar 2023 10:01:20 -0700 (PDT) Received: from [192.168.1.101] (abyj16.neoplus.adsl.tpnet.pl. [83.9.29.16]) by smtp.gmail.com with ESMTPSA id q7-20020a2e8747000000b002959f550084sm63352ljj.100.2023.03.13.10.01.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Mar 2023 10:01:19 -0700 (PDT) Message-ID: Date: Mon, 13 Mar 2023 18:01:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH RFC v2 2/6] arm64: dts: qcom: sdm845-tama: Add Synaptics Touchscreen Content-Language: en-US To: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio References: <20230313-topic-tama_disp-v2-0-37ececf43770@linaro.org> <20230313-topic-tama_disp-v2-2-37ececf43770@linaro.org> From: Konrad Dybcio In-Reply-To: <20230313-topic-tama_disp-v2-2-37ececf43770@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 13.03.2023 17:32, Konrad Dybcio wrote: > From: Konrad Dybcio > > Add required pins and RMI4 node to the common DT and remove it > from Akatsuki, as it uses a different touch. > > Since the panels are super high tech proprietary incell, they > need to be handled with very precise timings. As such the panel > driver sets up the power rails and GPIOs and the touchscreen > driver *has to* probe afterwards. > > Signed-off-by: Konrad Dybcio > Signed-off-by: Konrad Dybcio > --- [...] > &i2c5 { > - status = "okay"; > clock-frequency = <400000>; > + status = "okay"; > + > + touchscreen: touchscreen@2c { > + compatible = "syna,rmi4-i2c"; > + reg = <0x2c>; > + > + interrupt-parent = <&tlmm>; > + interrupts = <125 IRQ_TYPE_EDGE_FALLING>; interrupts-extended > + vdd-supply = <&vreg_l14a_1p8>; > + /* > + * This is a blatant abuse of OF, but the panel driver *needs* > + * to probe first, as the power/gpio switching needs to be precisely > + * timed in order for both the display and touch panel to function properly. > + */ > + incell-supply = <&panel>; > + > + syna,reset-delay-ms = <220>; > + syna,startup-delay-ms = <1000>; > + > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&ts_default>; > + pinctrl-1 = <&ts_sleep>; swapped > > - /* Synaptics touchscreen @ 2c, 3c */ > + #address-cells = <1>; > + #size-cells = <0>; Konrad