From: Maksim Kiselev <bigunclemax@gmail.com>
To: andre.przywara@arm.com
Cc: anarsoul@gmail.com, bob@electricworry.net, conor+dt@kernel.org,
daniel.lezcano@linaro.org, devicetree@vger.kernel.org,
jernej.skrabec@gmail.com, krzysztof.kozlowski+dt@linaro.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
linux-sunxi@lists.linux.dev, lukasz.luba@arm.com,
martin.botka@somainline.org, rafael@kernel.org,
robh+dt@kernel.org, rui.zhang@intel.com, samuel@sholland.org,
tiny.windzz@gmail.com, wens@csie.org
Subject: Re: [PATCH v3 5/6] thermal: sun8i: add support for H616 THS controller
Date: Sat, 9 Dec 2023 13:44:34 +0300 [thread overview]
Message-ID: <a14fb458-caf0-4a4a-b76b-c2503b0840d2@gmail.com> (raw)
In-Reply-To: <20231128005849.19044-6-andre.przywara@arm.com>
Hi Martin, Andre.
May I inquire? Why do we need a separate sun50i_h616_ths_calibrate()
function? Why can't we just extend an existing sun50i_h6_ths_calibrate()?
At my glance the calculations in both functions are the same. We just
need to handle a special case for the 4th sensor.
Best regards,
Maksim
next prev parent reply other threads:[~2023-12-09 10:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 0:58 [PATCH v3 0/6] Add support for H616 Thermal system Andre Przywara
2023-11-28 0:58 ` [PATCH v3 1/6] soc: sunxi: sram: export register 0 for THS on H616 Andre Przywara
2023-11-28 0:58 ` [PATCH v3 2/6] dt-bindings: thermal: sun8i: Add H616 THS controller Andre Przywara
2023-11-28 7:41 ` Krzysztof Kozlowski
2023-11-28 0:58 ` [PATCH v3 3/6] thermal: sun8i: explain unknown H6 register value Andre Przywara
2023-11-28 0:58 ` [PATCH v3 4/6] thermal: sun8i: add syscon register access code Andre Przywara
2023-11-28 7:43 ` Krzysztof Kozlowski
2023-11-28 7:50 ` Chen-Yu Tsai
2023-11-28 8:29 ` Krzysztof Kozlowski
2023-11-28 8:59 ` Chen-Yu Tsai
2023-11-28 9:02 ` Chen-Yu Tsai
2023-11-28 9:09 ` Chen-Yu Tsai
2023-11-28 9:13 ` Krzysztof Kozlowski
2023-11-28 14:11 ` Krzysztof Kozlowski
2023-11-28 14:33 ` Andre Przywara
2023-11-28 14:48 ` Krzysztof Kozlowski
2023-11-28 16:10 ` Andre Przywara
2023-11-28 16:39 ` Chen-Yu Tsai
2023-11-28 16:50 ` Rob Herring
2023-11-29 17:03 ` Andre Przywara
2023-11-29 17:09 ` Chen-Yu Tsai
2023-11-28 0:58 ` [PATCH v3 5/6] thermal: sun8i: add support for H616 THS controller Andre Przywara
2023-12-09 10:44 ` Maksim Kiselev [this message]
2023-12-11 0:05 ` Andre Przywara
2023-12-12 18:09 ` Maxim Kiselev
2023-12-14 9:59 ` Andre Przywara
2023-12-17 14:16 ` Maxim Kiselev
2023-11-28 0:58 ` [PATCH v3 6/6] arm64: dts: allwinner: h616: Add thermal sensor and zones Andre Przywara
-- strict thread matches above, loose matches on Subject: below --
2023-12-13 9:41 [PATCH v3 5/6] thermal: sun8i: add support for H616 THS controller Maxim Kiselev
2023-12-14 9:59 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a14fb458-caf0-4a4a-b76b-c2503b0840d2@gmail.com \
--to=bigunclemax@gmail.com \
--cc=anarsoul@gmail.com \
--cc=andre.przywara@arm.com \
--cc=bob@electricworry.net \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=lukasz.luba@arm.com \
--cc=martin.botka@somainline.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=samuel@sholland.org \
--cc=tiny.windzz@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).