From: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Subject: Re: [PATCH v3 3/3] regulator: qcom-refgen: add support for the IPQ9650 SoC
Date: Mon, 15 Jun 2026 23:10:02 +0530 [thread overview]
Message-ID: <a1501ac2-277c-4993-88fa-f29f0123c8a4@oss.qualcomm.com> (raw)
In-Reply-To: <f2e9f59c-3de7-41e4-92d9-88f91955175d@sirena.org.uk>
On 6/15/2026 11:01 PM, Mark Brown wrote:
> On Mon, Jun 15, 2026 at 10:54:26PM +0530, Kathiravan Thirumoorthy wrote:
>> On 6/15/2026 9:28 PM, Mark Brown wrote:
>>> This looks like a get_status() operation, not an enable operation? The
>>> enables and disables are pure clock operations.
>> Thanks, Mark for the review. If I understand correctly, I should track the
>> clock enable/disable operations and return that state in the is_enabled()
>> callback (as I did in v1). Please let me know if my understanding does not
>> align with your expectations.
> Yes. If as it seems the device can actually implement a get_status()
> operation the driver should do that as well.
Thanks Mark. I shall introduce get_status() with STATUS register read
back and update the is_enabled() to track the clock enable / disable
operation.
prev parent reply other threads:[~2026-06-15 17:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 8:35 [PATCH v3 0/3] Add support for the REFGEN in the IPQ9650 SoC Kathiravan Thirumoorthy
2026-06-15 8:35 ` [PATCH v3 1/3] regulator: qcom-refgen: correct the regulator type to CURRENT Kathiravan Thirumoorthy
2026-06-15 8:35 ` [PATCH v3 2/3] regulator: dt-bindings: qcom,sdm845-refgen-regulator: Document IPQ9650 Kathiravan Thirumoorthy
2026-06-17 7:04 ` Krzysztof Kozlowski
2026-06-15 8:35 ` [PATCH v3 3/3] regulator: qcom-refgen: add support for the IPQ9650 SoC Kathiravan Thirumoorthy
2026-06-15 8:46 ` sashiko-bot
2026-06-15 8:54 ` Kathiravan Thirumoorthy
2026-06-15 15:58 ` Mark Brown
2026-06-15 17:24 ` Kathiravan Thirumoorthy
2026-06-15 17:31 ` Mark Brown
2026-06-15 17:40 ` Kathiravan Thirumoorthy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1501ac2-277c-4993-88fa-f29f0123c8a4@oss.qualcomm.com \
--to=kathiravan.thirumoorthy@oss.qualcomm.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox