[PATCH v3 0/2] Improve older camss supply descriptions

[PATCH v3 0/2] Improve older camss supply descriptions

[David Heidelberg via B4 Relay]

Signed-off-by: David Heidelberg <david@ixit.cz>
---
Changes in v3:
- Add commit improving vdda-phy-supply description to match more recent
  bindings.
- Double-checked and specified it's 1.2 V vdda-pll-supply. (Vladimir)
- Link to v2: https://lore.kernel.org/r/20251213-docs-camss-fixes-v2-1-a8a4d4d51c6c@ixit.cz

Changes in v2:
- Applied suggestion to clarify the description. (Krzysztof)
- Link to v1: https://lore.kernel.org/r/20251212-docs-camss-fixes-v1-1-5c011505ff59@ixit.cz

---
David Heidelberg (2):
      media: dt-bindings: Correct camss VDDA PLL supply description
      media: dt-bindings: Update camss VDDA PHY supply description

 Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml  | 4 ++--
 Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml   | 4 ++--
 Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml | 4 ++--
 Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml   | 4 ++--
 Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml   | 4 ++--
 Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml   | 4 ++--
 Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml   | 2 +-
 7 files changed, 13 insertions(+), 13 deletions(-)
---
base-commit: 563c8dd425b59e44470e28519107b1efc99f4c7b
change-id: 20251212-docs-camss-fixes-0fa525271951

Best regards,
-- 
David Heidelberg <david@ixit.cz>

[PATCH v3 1/2] media: dt-bindings: Correct camss VDDA PLL supply description

[David Heidelberg via B4 Relay]

From: David Heidelberg <david@ixit.cz>

Usually, the supply is around 1.2 V, not 1.8 V. Rather remove mention of
voltage from the description.

Fixes: 849139d46d09 ("media: dt-bindings: media: camss: Fixup vdda regulator descriptions sdm845")
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml  | 2 +-
 Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml   | 2 +-
 Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml | 2 +-
 Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml   | 2 +-
 Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml   | 2 +-
 Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml   | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
index 019caa2b09c32..4986d18d1a2da 100644
--- a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
@@ -130,7 +130,7 @@ properties:
 
   vdda-pll-supply:
     description:
-      Phandle to 1.8V regulator supply to PHY refclk pll block.
+      1.2V regulator supply to CSIPHY IP blocks.
 
   ports:
     $ref: /schemas/graph.yaml#/properties/ports
diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
index ee35e3bc97ffd..e4b0b7ffdc336 100644
--- a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
@@ -129,7 +129,7 @@ properties:
 
   vdda-pll-supply:
     description:
-      Phandle to 1.8V regulator supply to PHY refclk pll block.
+      1.2V regulator supply to CSIPHY IP blocks.
 
   ports:
     $ref: /schemas/graph.yaml#/properties/ports
diff --git a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
index c99fe4106eee9..9cba6e0819fb1 100644
--- a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
@@ -268,7 +268,7 @@ properties:
 
   vdda-pll-supply:
     description:
-      Phandle to 1.8V regulator supply to PHY refclk pll block.
+      1.2V regulator supply to CSIPHY IP blocks.
 
 required:
   - clock-names
diff --git a/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
index 35c40fe223767..61222839556bd 100644
--- a/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
@@ -95,7 +95,7 @@ properties:
 
   vdda-pll-supply:
     description:
-      Phandle to 1.8V regulator supply to PHY refclk pll block.
+      1.2V regulator supply to CSIPHY IP blocks.
 
   ports:
     $ref: /schemas/graph.yaml#/properties/ports
diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
index 82bf4689d3300..03b9b34460b0a 100644
--- a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
@@ -211,7 +211,7 @@ properties:
 
   vdda-pll-supply:
     description:
-      Phandle to 1.8V regulator supply to PHY refclk pll block.
+      1.2V regulator supply to CSIPHY IP blocks.
 
 required:
   - clock-names
diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
index ebf68ff4ab961..acf9c54682107 100644
--- a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
@@ -300,7 +300,7 @@ properties:
 
   vdda-pll-supply:
     description:
-      Phandle to 1.8V regulator supply to PHY refclk pll block.
+      1.2V regulator supply to CSIPHY IP blocks.
 
 required:
   - clock-names

-- 
2.51.0

[PATCH v3 2/2] media: dt-bindings: Update camss VDDA PHY supply description

[David Heidelberg via B4 Relay]

From: David Heidelberg <david@ixit.cz>

Usually, the supply is around 0.875 - 0.88 V. Include the information
same as is already done for more recent camss dt-bindings.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml  | 2 +-
 Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml   | 2 +-
 Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml | 2 +-
 Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml   | 2 +-
 Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml   | 2 +-
 Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml   | 2 +-
 Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml   | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
index 4986d18d1a2da..5c47a2cf220fb 100644
--- a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
@@ -126,7 +126,7 @@ properties:
 
   vdda-phy-supply:
     description:
-      Phandle to a regulator supply to PHY core block.
+      0.88V regulator supply to CSIPHY IP blocks.
 
   vdda-pll-supply:
     description:
diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
index e4b0b7ffdc336..7d180e9cb6fa9 100644
--- a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
@@ -125,7 +125,7 @@ properties:
 
   vdda-phy-supply:
     description:
-      Phandle to a regulator supply to PHY core block.
+      0.88V regulator supply to CSIPHY IP blocks.
 
   vdda-pll-supply:
     description:
diff --git a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
index 9cba6e0819fb1..cd5e4948b97fc 100644
--- a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
@@ -264,7 +264,7 @@ properties:
 
   vdda-phy-supply:
     description:
-      Phandle to a regulator supply to PHY core block.
+      0.88V regulator supply to CSIPHY IP blocks.
 
   vdda-pll-supply:
     description:
diff --git a/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
index 61222839556bd..56346b650d21e 100644
--- a/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
@@ -91,7 +91,7 @@ properties:
 
   vdda-phy-supply:
     description:
-      Phandle to a regulator supply to PHY core block.
+      0.88V regulator supply to CSIPHY IP blocks.
 
   vdda-pll-supply:
     description:
diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
index 03b9b34460b0a..008a739a0018a 100644
--- a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
@@ -207,7 +207,7 @@ properties:
 
   vdda-phy-supply:
     description:
-      Phandle to a regulator supply to PHY core block.
+      0.88V regulator supply to CSIPHY IP blocks.
 
   vdda-pll-supply:
     description:
diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
index acf9c54682107..db5029d521291 100644
--- a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
@@ -296,7 +296,7 @@ properties:
 
   vdda-phy-supply:
     description:
-      Phandle to a regulator supply to PHY core block.
+      0.88V regulator supply to CSIPHY IP blocks.
 
   vdda-pll-supply:
     description:
diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml
index cd34f14916b42..ebf82a8c423bc 100644
--- a/Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml
@@ -134,7 +134,7 @@ properties:
 
   vdda-phy-supply:
     description:
-      Phandle to a regulator supply to PHY core block.
+      0.88V regulator supply to CSIPHY IP blocks.
 
   vdda-pll-supply:
     description:

-- 
2.51.0

Re: [PATCH v3 1/2] media: dt-bindings: Correct camss VDDA PLL supply description

[Bryan O'Donoghue]

On 16/12/2025 12:24, David Heidelberg via B4 Relay wrote:
> Fixes: 849139d46d09 ("media: dt-bindings: media: camss: Fixup vdda regulator descriptions sdm845")

This Fixes tag pertains to just one commit, whereas your patch modifies 
files associated with ~ 6 commits.

Please drop the Fixes:

---
bod

Re: [PATCH v3 2/2] media: dt-bindings: Update camss VDDA PHY supply description

[Bryan O'Donoghue]

On 16/12/2025 12:24, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
> 
> Usually, the supply is around 0.875 - 0.88 V. Include the information
> same as is already done for more recent camss dt-bindings.
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>   Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml  | 2 +-
>   Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml   | 2 +-
>   Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml | 2 +-
>   Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml   | 2 +-
>   Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml   | 2 +-
>   Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml   | 2 +-
>   Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml   | 2 +-
>   7 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> index 4986d18d1a2da..5c47a2cf220fb 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> @@ -126,7 +126,7 @@ properties:
> 
>     vdda-phy-supply:
>       description:
> -      Phandle to a regulator supply to PHY core block.
> +      0.88V regulator supply to CSIPHY IP blocks.
> 
>     vdda-pll-supply:
>       description:
> diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
> index e4b0b7ffdc336..7d180e9cb6fa9 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
> @@ -125,7 +125,7 @@ properties:
> 
>     vdda-phy-supply:
>       description:
> -      Phandle to a regulator supply to PHY core block.
> +      0.88V regulator supply to CSIPHY IP blocks.
> 
>     vdda-pll-supply:
>       description:
> diff --git a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
> index 9cba6e0819fb1..cd5e4948b97fc 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
> @@ -264,7 +264,7 @@ properties:
> 
>     vdda-phy-supply:
>       description:
> -      Phandle to a regulator supply to PHY core block.
> +      0.88V regulator supply to CSIPHY IP blocks.
> 
>     vdda-pll-supply:
>       description:
> diff --git a/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
> index 61222839556bd..56346b650d21e 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml
> @@ -91,7 +91,7 @@ properties:
> 
>     vdda-phy-supply:
>       description:
> -      Phandle to a regulator supply to PHY core block.
> +      0.88V regulator supply to CSIPHY IP blocks.
> 
>     vdda-pll-supply:
>       description:
> diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
> index 03b9b34460b0a..008a739a0018a 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
> @@ -207,7 +207,7 @@ properties:
> 
>     vdda-phy-supply:
>       description:
> -      Phandle to a regulator supply to PHY core block.
> +      0.88V regulator supply to CSIPHY IP blocks.
> 
>     vdda-pll-supply:
>       description:
> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
> index acf9c54682107..db5029d521291 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
> @@ -296,7 +296,7 @@ properties:
> 
>     vdda-phy-supply:
>       description:
> -      Phandle to a regulator supply to PHY core block.
> +      0.88V regulator supply to CSIPHY IP blocks.
> 
>     vdda-pll-supply:
>       description:
> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml
> index cd34f14916b42..ebf82a8c423bc 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml
> @@ -134,7 +134,7 @@ properties:
> 
>     vdda-phy-supply:
>       description:
> -      Phandle to a regulator supply to PHY core block.
> +      0.88V regulator supply to CSIPHY IP blocks.
> 
>     vdda-pll-supply:
>       description:
> 
> --
> 2.51.0
> 
> 

Reviewed-by: Bryan O'Donoghue <bod@kernel.org>

Re: [PATCH v3 1/2] media: dt-bindings: Correct camss VDDA PLL supply description

[David Heidelberg]

On 16/12/2025 13:30, Bryan O'Donoghue wrote:
> On 16/12/2025 12:24, David Heidelberg via B4 Relay wrote:
>> Fixes: 849139d46d09 ("media: dt-bindings: media: camss: Fixup vdda 
>> regulator descriptions sdm845")
> 
> This Fixes tag pertains to just one commit, whereas your patch modifies 
> files associated with ~ 6 commits.
> 
> Please drop the Fixes:

Sure. If no additional changes will be requested, please drop the Fixes 
line for me.

Thank you

> 
> ---
> bod

-- 
David Heidelberg

Re: [PATCH v3 2/2] media: dt-bindings: Update camss VDDA PHY supply description

[Krzysztof Kozlowski]

On Tue, Dec 16, 2025 at 01:24:51PM +0100, David Heidelberg wrote:
> Usually, the supply is around 0.875 - 0.88 V. Include the information
> same as is already done for more recent camss dt-bindings.
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml  | 2 +-
>  Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml   | 2 +-
>  Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml | 2 +-
>  Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml   | 2 +-
>  Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml   | 2 +-
>  Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml   | 2 +-
>  Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml   | 2 +-
>  7 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> index 4986d18d1a2da..5c47a2cf220fb 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> @@ -126,7 +126,7 @@ properties:
>  
>    vdda-phy-supply:
>      description:
> -      Phandle to a regulator supply to PHY core block.
> +      0.88V regulator supply to CSIPHY IP blocks.

As I said, this is just a supply, not a "regulator supply". I gave you
justification for this. This is completely unimportant but I just wonder
why even that direct instruction has to be ignored.

Best regards,
Krzysztof

Re: [PATCH v3 1/2] media: dt-bindings: Correct camss VDDA PLL supply description

[Krzysztof Kozlowski]

On Tue, Dec 16, 2025 at 01:24:50PM +0100, David Heidelberg wrote:
> Usually, the supply is around 1.2 V, not 1.8 V. Rather remove mention of
> voltage from the description.

You did not remove the voltage. Anyway, both commits should be squashed.

> 
> Fixes: 849139d46d09 ("media: dt-bindings: media: camss: Fixup vdda regulator descriptions sdm845")
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml  | 2 +-
>  Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml   | 2 +-
>  Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml | 2 +-
>  Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml   | 2 +-
>  Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml   | 2 +-
>  Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml   | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> index 019caa2b09c32..4986d18d1a2da 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> @@ -130,7 +130,7 @@ properties:
>  
>    vdda-pll-supply:
>      description:
> -      Phandle to 1.8V regulator supply to PHY refclk pll block.
> +      1.2V regulator supply to CSIPHY IP blocks.

"...that supply is a regulator supply" so you still decided to go that
way. Why? I think I could not write this clearer.

Best regards,
Krzysztof

Re: [PATCH v3 1/2] media: dt-bindings: Correct camss VDDA PLL supply description

[David Heidelberg]

On 18/12/2025 09:12, Krzysztof Kozlowski wrote:
> On Tue, Dec 16, 2025 at 01:24:50PM +0100, David Heidelberg wrote:
>> Usually, the supply is around 1.2 V, not 1.8 V. Rather remove mention of
>> voltage from the description.
> 
> You did not remove the voltage. Anyway, both commits should be squashed.
> 
>>
>> Fixes: 849139d46d09 ("media: dt-bindings: media: camss: Fixup vdda regulator descriptions sdm845")
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>>   Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml  | 2 +-
>>   Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml   | 2 +-
>>   Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml | 2 +-
>>   Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml   | 2 +-
>>   Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml   | 2 +-
>>   Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml   | 2 +-
>>   6 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
>> index 019caa2b09c32..4986d18d1a2da 100644
>> --- a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
>> +++ b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
>> @@ -130,7 +130,7 @@ properties:
>>   
>>     vdda-pll-supply:
>>       description:
>> -      Phandle to 1.8V regulator supply to PHY refclk pll block.
>> +      1.2V regulator supply to CSIPHY IP blocks.
> 
> "...that supply is a regulator supply" so you still decided to go that
> way. Why? I think I could not write this clearer.

Oh! Vladimir mentioned the supplies should look like in

 > names like found in qcom,x1e80100-camss.yaml, qcom,qcm2290-camss.yaml 
and qcom,sm8650-camss.yaml

I blindly considered these to be "examples how it should look like" and 
used the more recent description without checking them.

I'll squash the commits in next version and rephrase all camss the 
supplies correctly, if it make sense to you.

Sorry for the inconvenience and thanks.
David

> 
> Best regards,
> Krzysztof
> 

-- 
David Heidelberg

Re: [PATCH v3 0/2] Improve older camss supply descriptions

[David Heidelberg]

btw. I looked at qcom,qcm2290-camss.yaml and if there isn't something 
very specific about qcm2290, the supply may have wrong voltrage.
I'll leave this for someone with datasheets (cc Loic):

   vdd-csiphy-1p8-supply:
     description:
       Phandle to 1.8V regulator supply to CSI PHYs pll block.

as see on the mailing list the 0.8V example was given and changed to 
1.8V, so maybe it has a reason, just making a note to be extra sure 
while touching the docs.

David
-- 
David Heidelberg