Re: [PATCH] dt-bindings: arm: bcm: document BCM4912 bindings

[Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>]

On 15/03/2022 19:44, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> BCM4912 is a successor family to the BCM4908. It includes BCM4912,
> BCM4915 and BCM49418. It's mostly used in home routers.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
>  .../bindings/arm/bcm/brcm,bcm4912.yaml        | 38 +++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/bcm/brcm,bcm4912.yaml
> 
> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4912.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4912.yaml
> new file mode 100644
> index 000000000000..438a6f20ca93
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4912.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/bcm/brcm,bcm4912.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom BCM4912 device tree bindings
> +
> +description:
> +  Broadcom BCM4912 / BCM4915 / BCM49418 Wi-Fi/network SoCs with Brahma CPUs.
> +
> +maintainers:
> +  - Rafał Miłecki <rafal@milecki.pl>
> +
> +properties:
> +  $nodename:
> +    const: '/'
> +  compatible:
> +    oneOf:
> +      - description: BCM4912 based boards
> +        items:
> +          - enum:
> +              - asus,gt-ax6000
> +          - const: brcm,bcm4912
> +
> +      - description: BCM4915 based boards
> +        items:
> +          - const: brcm,bcm4915
> +          - const: brcm,bcm4912
> +
> +      - description: BCM49418 based boards
> +        items:
> +          - const: brcm,bcm49418
> +          - const: brcm,bcm4908

The last two entries do not look correct currently. You don't have any
boards. Maybe just skip them? Unless you plan to use these compatibles
in DTSI?


Best regards,
Krzysztof