devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1 0/2] ASoC: codecs: add support for ES8375
@ 2025-05-22 10:35 Zhang Yi
  2025-05-22 10:35 ` [PATCH v1 1/2] ASoC: dt-bindings: Add Everest ES8375 audio CODEC Zhang Yi
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Zhang Yi @ 2025-05-22 10:35 UTC (permalink / raw)
  To: broonie, robh, tiwai, devicetree, conor+dt, lgirdwood,
	linux-kernel, linux-sound, perex, krzk+dt
  Cc: amadeuszx.slawinski, krzk, Zhang Yi

The driver is for codec ES8375 of everest-semi.

v1 -> v0:
          - Add the description of everest,mclk-src in the yaml file
          - Remove attribute es8375->dmic_pol which is not used
            in the codec driver
          - replace SOC_DAPM_ENUM_EXT with SOC_DAPM_ENUM which
            is used for ADC MUX
          - Modify some control-names
          - Replace a number with a specific variable
          - Delete obsolete terminology
          - Remove the default volume setting
          - Modify cache_type in regmap_config

Zhang Yi (2):
  ASoC: dt-bindings: Add Everest ES8375 audio CODEC
  ASoC: codecs: add support for ES8375

 .../bindings/sound/everest,es8375.yaml        |  71 ++
 sound/soc/codecs/Kconfig                      |   5 +
 sound/soc/codecs/Makefile                     |   2 +
 sound/soc/codecs/es8375.c                     | 797 ++++++++++++++++++
 sound/soc/codecs/es8375.h                     | 123 +++
 5 files changed, 998 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/everest,es8375.yaml
 create mode 100644 sound/soc/codecs/es8375.c
 create mode 100644 sound/soc/codecs/es8375.h

-- 
2.17.1


^ permalink raw reply	[flat|nested] 9+ messages in thread
* RE: [PATCH v1 2/2] ASoC: codecs: add support for ES8375
@ 2025-05-23  2:35 Zhang Yi
  0 siblings, 0 replies; 9+ messages in thread
From: Zhang Yi @ 2025-05-23  2:35 UTC (permalink / raw)
  To: broonie
  Cc: robh, tiwai, devicetree, conor+dt, lgirdwood, linux-kernel,
	linux-sound, perex, krzk+dt, amadeuszx.slawinski, krzk

> > +static const struct snd_kcontrol_new es8375_snd_controls[] = {
> > +	SOC_SINGLE_TLV("ADC OSR GAIN Volume", ES8375_ADC_OSR_GAIN,
> > +			ADC_OSR_GAIN_SHIFT_0, ES8375_ADC_OSR_GAIN_MAX, 0,
> > +			es8375_adc_osr_gain_tlv),
> 
> Probably just ADC OSR Volume.
> 
> > +	SOC_SINGLE_TLV("DMIC Gain Volume", ES8375_ADC1,
> > +		DMIC_GAIN_SHIFT_2, ES8375_DMIC_GAIN_MAX,
> > +		0, es8375_adc_dmic_volume_tlv),
> 
> Same here.
> 
> > +	SOC_SINGLE("ADC Automute Enable", ES8375_ADC_AUTOMUTE,
> > +			ADC_AUTOMUTE_SHIFT_7, 1, 0),
> > +
> > +	SOC_SINGLE("DAC DSM Mute", ES8375_DAC1, DAC_DSMMUTE_SHIFT_7, 1, 0),
> > +	SOC_SINGLE("DAC DEM Mute", ES8375_DAC1, DAC_DEMMUTE_SHIFT_6, 1, 0),
> 
> > +	SOC_SINGLE("DAC Automute Enable", ES8375_DAC_AUTOMUTE1,
> > +			DAC_AUTOMUTE_EN_SHIFT_7, 1, 0),
> 
> These are all on/off switches so should be Switch.
> 
> > +	SOC_SINGLE_TLV("DAC Automute Attenuation", ES8375_DAC_AUTOMUTE,
> > +			DAC_AUTOMUTE_ATTN_SHIFT_0, ES8375_DAC_AUTOMUTE_ATTN_MAX,
> > +			0, es8375_dac_automute_attn_tlv),
> 
> This is also a Volume ("DAC Automute Volume").

I'll modify these control-name.

> > +	if (es8375->mclk_src == ES8375_BCLK_PIN) {
> > +		if (es8375->mastermode) {
> > +			dev_err(component->dev, "no mclk, cannot as master\n");
> > +			return -EINVAL;
> > +		}
> 
> Still got the outdated clocking terminology here.

I'll delete it

^ permalink raw reply	[flat|nested] 9+ messages in thread
* RE: [PATCH v1 0/2] ASoC: codecs: add support for ES8375
@ 2025-05-23  2:36 Zhang Yi
  2025-05-23  2:36 ` [PATCH v1 2/2] " Zhang Yi
  0 siblings, 1 reply; 9+ messages in thread
From: Zhang Yi @ 2025-05-23  2:36 UTC (permalink / raw)
  To: krzk
  Cc: robh, tiwai, devicetree, conor+dt, lgirdwood, linux-kernel,
	linux-sound, perex, krzk+dt, amadeuszx.slawinski, broonie

> > The driver is for codec ES8375 of everest-semi.
> > 
> > v1 -> v0:
> >           - Add the description of everest,mclk-src in the yaml file
> 
> Version your patches correctly - that's v2. Or just start using b4.

ok, I'll change it to v3 for the next version

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2025-05-23  2:36 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-22 10:35 [PATCH v1 0/2] ASoC: codecs: add support for ES8375 Zhang Yi
2025-05-22 10:35 ` [PATCH v1 1/2] ASoC: dt-bindings: Add Everest ES8375 audio CODEC Zhang Yi
2025-05-22 11:14   ` Krzysztof Kozlowski
2025-05-22 10:35 ` [PATCH v1 2/2] ASoC: codecs: add support for ES8375 Zhang Yi
2025-05-22 10:43   ` Mark Brown
2025-05-22 11:15   ` Krzysztof Kozlowski
2025-05-22 11:13 ` [PATCH v1 0/2] " Krzysztof Kozlowski
  -- strict thread matches above, loose matches on Subject: below --
2025-05-23  2:35 [PATCH v1 2/2] " Zhang Yi
2025-05-23  2:36 [PATCH v1 0/2] " Zhang Yi
2025-05-23  2:36 ` [PATCH v1 2/2] " Zhang Yi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).