From: Matthias Brugger <matthias.bgg@gmail.com>
To: Ryder Lee <ryder.lee@mediatek.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH 2/2] crypto: mediatek - update DT binding documentation
Date: Fri, 26 May 2017 16:15:23 +0200 [thread overview]
Message-ID: <a16ecc4c-2d82-1239-ec57-94dd3b24efb0@gmail.com> (raw)
In-Reply-To: <1495791789-19230-2-git-send-email-ryder.lee@mediatek.com>
On 26/05/17 11:43, Ryder Lee wrote:
> This patch removes unnecessary clock in binding file.
>
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> ---
In the driver clocks are get by name, so this change does not break
backwards compatibility.
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> Documentation/devicetree/bindings/crypto/mediatek-crypto.txt | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt b/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
> index c204725..450da36 100644
> --- a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
> +++ b/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
> @@ -6,8 +6,7 @@ Required properties:
> - interrupts: Should contain the five crypto engines interrupts in numeric
> order. These are global system and four descriptor rings.
> - clocks: the clock used by the core
> -- clock-names: the names of the clock listed in the clocks property. These are
> - "ethif", "cryp"
> +- clock-names: Must contain "cryp".
> - power-domains: Must contain a reference to the PM domain.
>
>
> @@ -20,8 +19,7 @@ Example:
> <GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>,
> <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>,
> <GIC_SPI 97 IRQ_TYPE_LEVEL_LOW>;
> - clocks = <&topckgen CLK_TOP_ETHIF_SEL>,
> - <ðsys CLK_ETHSYS_CRYPTO>;
> - clock-names = "ethif","cryp";
> + clocks = <ðsys CLK_ETHSYS_CRYPTO>;
> + clock-names = "cryp";
> power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
> };
>
next prev parent reply other threads:[~2017-05-26 14:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 9:43 [PATCH 1/2] crypto: mediatek - remove redundant clock setting Ryder Lee
[not found] ` <1495791789-19230-1-git-send-email-ryder.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-05-26 9:43 ` [PATCH 2/2] crypto: mediatek - update DT binding documentation Ryder Lee
2017-05-26 14:15 ` Matthias Brugger [this message]
[not found] ` <1495791789-19230-2-git-send-email-ryder.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-05-31 18:46 ` Rob Herring
2017-06-01 1:04 ` Ryder Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a16ecc4c-2d82-1239-ec57-94dd3b24efb0@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).