From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDC6C7F for ; Thu, 5 Oct 2023 08:02:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SMQJlUBE" Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC8C683FA for ; Thu, 5 Oct 2023 01:02:01 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-99bdeae1d0aso128874166b.1 for ; Thu, 05 Oct 2023 01:02:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696492920; x=1697097720; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ITJaETj86MvBmNPLQnRFV5zNuPgDsMaOtt+0yTL/6Fk=; b=SMQJlUBEIiPdZO9wv2lDTS6xU09++XM8jJlS06HItansTVgtRF1U/pU18O/+w2TdGi DYw3qxwMKgLZO2uU578D4F837+yXKafueZmBpxj2CYaI2D0N613sMCBbKNjnB2RdHf3F W+BvI5XFGXRwh85Hcs9gmNmAzBKbIHAVbtd8Tb4lBBP2i8H2PLqrgzlB7rh6fTokVINB 9EVYp5G8wigXyQva/PDG1pa08BBgHeqPFVQkZGYvl02rdwsSp2AnZ67SDLeUqqShIh88 SH3K7GZzCHamRbAvs3IxlFDZjxnipyPn2208z20dBcGD18ONgnXH086XRt5FsY5XOD3f Nzzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696492920; x=1697097720; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ITJaETj86MvBmNPLQnRFV5zNuPgDsMaOtt+0yTL/6Fk=; b=WXAnjOrcllkAU0KHcPtxrnQnI+TBfWa/h19Zofn0D8fxwSBPYA+23pVXsqcX15+cJz aQbyzzQNnYrzcPM0X6ge/CdCuAJVEYHltiPw3lPHIPLIGbs0B8qC1N/Ww9wct3CmQ2WX 4g28rx6Ktcc3zFWD7SDIa8/iG3VyY0kp2f16CXL7YCMe0FvBpStABjCNz6J45ojdZfZX os6chjjoWJOTqiEvnwFwmPtmmdebC3c9O4M4dFjXMQtewQqkhvedRF2/5Xh80xNy5pGt SdjSBr23sCMQO7n0AYKclOtYrIpG9NJtyyP74dFT7IRMek7ub/8Xpn1gYIXQ0pDXBMHc xTIw== X-Gm-Message-State: AOJu0YyhaTMYq4niEHseH4Lpu0QnGU1ZqPk4SB1yaXZ/BD8019nJZ1fB IHglhSl6sBnR1gXzNLbVHwXDbW9W0uexfkRbdETL+Q== X-Google-Smtp-Source: AGHT+IFvPb65/Gce4lL/Evfr7E6lBGEBeyYx9p1UBu0WvTN+KbWHzjpLeIb01bUIbvto/4WuTvV0IQ== X-Received: by 2002:a17:907:724b:b0:9a1:fcd7:b825 with SMTP id ds11-20020a170907724b00b009a1fcd7b825mr3956463ejc.71.1696492920200; Thu, 05 Oct 2023 01:02:00 -0700 (PDT) Received: from [192.168.1.197] (5-157-101-10.dyn.eolo.it. [5.157.101.10]) by smtp.gmail.com with ESMTPSA id e12-20020a17090681cc00b009a9fbeb15f2sm740695ejx.62.2023.10.05.01.01.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Oct 2023 01:01:59 -0700 (PDT) Message-ID: Date: Thu, 5 Oct 2023 10:01:57 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/3] dt-bindings: net: Add ti,cc1352p7 Content-Language: en-US To: Ayush Singh , greybus-dev@lists.linaro.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, vaishnav@beagleboard.org, jkridner@beagleboard.org, nm@ti.com, krzysztof.kozlowski+dt@linaro.org, vigneshr@ti.com, kristo@kernel.org, robh+dt@kernel.org, conor+dt@kernel.org, linux-arm-kernel@lists.infradead.org References: <20231004184639.462510-1-ayushdevel1325@gmail.com> <20231004184639.462510-2-ayushdevel1325@gmail.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20231004184639.462510-2-ayushdevel1325@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 04/10/2023 20:46, Ayush Singh wrote: > Add DT bindings for Texas Instruments Simplelink CC1352P7 wireless MCU > > BeaglePlay has CC1352P7 co-processor connected to the main AM62 (running > Linux) over UART. In the BeagleConnect Technology, CC1352 is responsible > for handling 6LoWPAN communication with beagleconnect freedom nodes as > well as their discovery. > > It is used by gb-beagleplay greybus driver. "Instead drop both sentences" > > Signed-off-by: Ayush Singh > --- > .../devicetree/bindings/net/ti,cc1352p7.yaml | 51 +++++++++++++++++++ > MAINTAINERS | 6 +++ > 2 files changed, 57 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/ti,cc1352p7.yaml > > diff --git a/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml > new file mode 100644 > index 000000000000..291ba34c389b > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/ti,cc1352p7.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments Simplelink CC1352P7 wireless MCU > + > +description: > + The cc1352p7 mcu can be connected via SPI or UART. > + > +maintainers: > + - Ayush Singh > + > +properties: > + compatible: > + const: ti,cc1352p7 > + > + clocks: > + maxItems: 2 > + > + clock-names: > + description: > + sclk_hf is the main system (mcu and peripherals) clock > + sclk_lf is low-frequency system clock This does no go here, but to clocks. I wrote how it should be done. Don't ignore the feedback. > + items: > + - const: sclk_hf > + - const: sclk_lf > + > + reset-gpios: true No, really, why do you change correct code into incorrect one? Who asked you to drop maxItems? > + > + vdds-supply: true Best regards, Krzysztof