From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dinh Nguyen Subject: Re: [PATCH 12/25] arm: socfpga: dts: Remove leading 0x and 0s from bindings notation Date: Thu, 11 Jan 2018 08:38:42 -0600 Message-ID: References: <20171214165350.27850-1-malat@debian.org> <20171215111620.20379-1-malat@debian.org> <20171215111620.20379-12-malat@debian.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171215111620.20379-12-malat@debian.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Mathieu Malaterre , Rob Herring Cc: Mark Rutland , Andrew Lunn , Heiko Stuebner , Tony Lindgren , Sekhar Nori , linux-kernel@vger.kernel.org, Matthias Brugger , Alexandre Belloni , linux-arm-kernel@axis.com, Baoyou Xie , Jason Cooper , Jesper Nilsson , Florian Fainelli , Kevin Hilman , Viresh Kumar , Russell King , Krzysztof Kozlowski , linux-rockchip@lists.infradead.org, Alexandre Torgue , Kukjin Kim , bcm-kernel-feedback-list@broadcom.com, Niklas Cassel , Sebastian Hesselbarth , devicetree List-Id: devicetree@vger.kernel.org On 12/15/2017 05:16 AM, Mathieu Malaterre wrote: > Improve the DTS files by removing all the leading "0x" and zeros to fix the > following dtc warnings: > > Warning (unit_address_format): Node /XXX unit name should not have leading "0x" > > and > > Warning (unit_address_format): Node /XXX unit name should not have leading 0s > > Converted using the following command: > > find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0+\(.*\) {/@\1 {/g" {} +^C > > For simplicity, two sed expressions were used to solve each warnings separately. > > To make the regex expression more robust a few other issues were resolved, > namely setting unit-address to lower case, and adding a whitespace before the > the opening curly brace: > > https://elinux.org/Device_Tree_Linux#Linux_conventions > > This will solve as a side effect warning: > > Warning (simple_bus_reg): Node /XXX@ simple-bus unit address format error, expected "" > > This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation") > > Reported-by: David Daney > Suggested-by: Rob Herring > Signed-off-by: Mathieu Malaterre > --- > arch/arm/boot/dts/socfpga.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Dinh Nguyen Dinh