From: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
To: Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"alexandre.torgue@foss.st.com" <alexandre.torgue@foss.st.com>
Cc: "balbi@kernel.org" <balbi@kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"amelie.delaunay@foss.st.com" <amelie.delaunay@foss.st.com>
Subject: Re: [PATCH 1/3] usb: dwc2: add otg_rev and otg_caps information for gadget driver
Date: Fri, 1 Oct 2021 11:10:19 +0000 [thread overview]
Message-ID: <a183ddf9-c578-0b45-1aa2-4fcd1fbf17eb@synopsys.com> (raw)
In-Reply-To: <1631692473-8732-2-git-send-email-fabrice.gasnier@foss.st.com>
On 9/15/2021 11:54 AM, Fabrice Gasnier wrote:
> Currently the dwc2 doesn't fill in the 'otg_caps' of usb_gadget structure.
> When registering a gadget device (e.g. via configfs), the
> usb_otg_descriptor_init() checks the 'otg_caps' and 'otg_rev'. It defaults
> to HNP and SRP bmAttributes if unspecified. There may be a mismatch with
> what's being set in dwc2 params structure. This result in the descriptors
> to be miss-configured in this case.
>
> So add an option to setup 'otg_caps' and 'otg_rev' in the params. It's
> then provided to the gadget struct. These parameters can then be tuned
> for each platform. In case it's not set, it will default to current
> behavior.
> Also add option to setup these from the device tree by calling
> of_usb_update_otg_caps(). This provides support for standard properties
> such as "otg-rev", "hnp-disable" and "srp-disable" (see usb-drd.yaml).
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Acked-by: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
next prev parent reply other threads:[~2021-10-01 11:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 7:54 [PATCH 0/3] usb: dwc2: fill in gadget caps, configure it for stm32mp15 Fabrice Gasnier
2021-09-15 7:54 ` [PATCH 1/3] usb: dwc2: add otg_rev and otg_caps information for gadget driver Fabrice Gasnier
2021-10-01 11:10 ` Minas Harutyunyan [this message]
2021-10-06 6:27 ` gregkh
2021-09-15 7:54 ` [PATCH 2/3] usb: dwc2: stm32mp15: set otg_rev Fabrice Gasnier
2021-10-01 11:10 ` Minas Harutyunyan
2021-09-15 7:54 ` [PATCH 3/3] ARM: dts: stm32: set otg-rev on stm32mp151 Fabrice Gasnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a183ddf9-c578-0b45-1aa2-4fcd1fbf17eb@synopsys.com \
--to=minas.harutyunyan@synopsys.com \
--cc=alexandre.torgue@foss.st.com \
--cc=amelie.delaunay@foss.st.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@foss.st.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).