[PATCH v1 0/2] Yosemite4: Add devices on I2C buses to server boards

[PATCH v1 0/2] Yosemite4: Add devices on I2C buses to server boards

[Delphine CC Chiu]

Changelog:
  - v1
    - Revise to use adm1281 on Medusa board.
    - Add gpio pca9506 for CPLD I/O expander.

Ricky CX Wu (2):
  ARM: dts: aspeed: yosemite4: Revise to use adm1281 on Medusa board
  ARM: dts: aspeed: yosemite4: Add gpio pca9506 for CPLD IOE

 .../aspeed/aspeed-bmc-facebook-yosemite4.dts  | 276 +++++++++++++++++-
 1 file changed, 268 insertions(+), 8 deletions(-)

-- 
2.25.1

[PATCH v1 1/2] ARM: dts: aspeed: yosemite4: Revise to use adm1281 on Medusa board

[Delphine CC Chiu]

From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>

Revise to use adm1281 for HSC according to the hardware design change.

Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
---
 .../aspeed/aspeed-bmc-facebook-yosemite4.dts  | 24 ++++++++++++-------
 1 file changed, 16 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
index 98477792aa00..08d32e42286e 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
@@ -130,8 +130,9 @@ mctp@10 {
 	};
 
 	power-sensor@40 {
-		compatible = "adi,adm1278";
+		compatible = "adi,adm1281";
 		reg = <0x40>;
+		shunt-resistor-micro-ohms = <500>;
 	};
 };
 
@@ -147,8 +148,9 @@ mctp@10 {
 	};
 
 	power-sensor@40 {
-		compatible = "adi,adm1278";
+		compatible = "adi,adm1281";
 		reg = <0x40>;
+		shunt-resistor-micro-ohms = <500>;
 	};
 };
 
@@ -164,8 +166,9 @@ mctp@10 {
 	};
 
 	power-sensor@40 {
-		compatible = "adi,adm1278";
+		compatible = "adi,adm1281";
 		reg = <0x40>;
+		shunt-resistor-micro-ohms = <500>;
 	};
 };
 
@@ -181,8 +184,9 @@ mctp@10 {
 	};
 
 	power-sensor@40 {
-		compatible = "adi,adm1278";
+		compatible = "adi,adm1281";
 		reg = <0x40>;
+		shunt-resistor-micro-ohms = <500>;
 	};
 };
 
@@ -198,8 +202,9 @@ mctp@10 {
 	};
 
 	power-sensor@40 {
-		compatible = "adi,adm1278";
+		compatible = "adi,adm1281";
 		reg = <0x40>;
+		shunt-resistor-micro-ohms = <500>;
 	};
 };
 
@@ -215,8 +220,9 @@ mctp@10 {
 	};
 
 	power-sensor@40 {
-		compatible = "adi,adm1278";
+		compatible = "adi,adm1281";
 		reg = <0x40>;
+		shunt-resistor-micro-ohms = <500>;
 	};
 };
 
@@ -232,8 +238,9 @@ mctp@10 {
 	};
 
 	power-sensor@40 {
-		compatible = "adi,adm1278";
+		compatible = "adi,adm1281";
 		reg = <0x40>;
+		shunt-resistor-micro-ohms = <500>;
 	};
 };
 
@@ -249,8 +256,9 @@ mctp@10 {
 	};
 
 	power-sensor@40 {
-		compatible = "adi,adm1278";
+		compatible = "adi,adm1281";
 		reg = <0x40>;
+		shunt-resistor-micro-ohms = <500>;
 	};
 };
 
-- 
2.25.1

[PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio pca9506 for CPLD IOE

[Delphine CC Chiu]

From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>

We use CPLD to emulate gpio pca9506 I/O expander on each server
boards.
Therefore, add pca9506 to probe driver for the CPLD I/O expander.

Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
---
 .../aspeed/aspeed-bmc-facebook-yosemite4.dts  | 252 ++++++++++++++++++
 1 file changed, 252 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
index 08d32e42286e..9d2efb5f2f67 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
@@ -129,6 +129,34 @@ mctp@10 {
 		reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
 	};
 
+	gpio@21 {
+		compatible = "nxp,pca9506";
+		reg = <0x21>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@22 {
+		compatible = "nxp,pca9506";
+		reg = <0x22>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@23 {
+		compatible = "nxp,pca9506";
+		reg = <0x23>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@24 {
+		compatible = "nxp,pca9506";
+		reg = <0x24>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
 	power-sensor@40 {
 		compatible = "adi,adm1281";
 		reg = <0x40>;
@@ -147,6 +175,34 @@ mctp@10 {
 		reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
 	};
 
+	gpio@21 {
+		compatible = "nxp,pca9506";
+		reg = <0x21>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@22 {
+		compatible = "nxp,pca9506";
+		reg = <0x22>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@23 {
+		compatible = "nxp,pca9506";
+		reg = <0x23>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@24 {
+		compatible = "nxp,pca9506";
+		reg = <0x24>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
 	power-sensor@40 {
 		compatible = "adi,adm1281";
 		reg = <0x40>;
@@ -165,6 +221,34 @@ mctp@10 {
 		reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
 	};
 
+	gpio@21 {
+		compatible = "nxp,pca9506";
+		reg = <0x21>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@22 {
+		compatible = "nxp,pca9506";
+		reg = <0x22>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@23 {
+		compatible = "nxp,pca9506";
+		reg = <0x23>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@24 {
+		compatible = "nxp,pca9506";
+		reg = <0x24>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
 	power-sensor@40 {
 		compatible = "adi,adm1281";
 		reg = <0x40>;
@@ -183,6 +267,34 @@ mctp@10 {
 		reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
 	};
 
+	gpio@21 {
+		compatible = "nxp,pca9506";
+		reg = <0x21>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@22 {
+		compatible = "nxp,pca9506";
+		reg = <0x22>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@23 {
+		compatible = "nxp,pca9506";
+		reg = <0x23>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@24 {
+		compatible = "nxp,pca9506";
+		reg = <0x24>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
 	power-sensor@40 {
 		compatible = "adi,adm1281";
 		reg = <0x40>;
@@ -201,6 +313,34 @@ mctp@10 {
 		reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
 	};
 
+	gpio@21 {
+		compatible = "nxp,pca9506";
+		reg = <0x21>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@22 {
+		compatible = "nxp,pca9506";
+		reg = <0x22>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@23 {
+		compatible = "nxp,pca9506";
+		reg = <0x23>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@24 {
+		compatible = "nxp,pca9506";
+		reg = <0x24>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
 	power-sensor@40 {
 		compatible = "adi,adm1281";
 		reg = <0x40>;
@@ -219,6 +359,34 @@ mctp@10 {
 		reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
 	};
 
+	gpio@21 {
+		compatible = "nxp,pca9506";
+		reg = <0x21>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@22 {
+		compatible = "nxp,pca9506";
+		reg = <0x22>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@23 {
+		compatible = "nxp,pca9506";
+		reg = <0x23>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@24 {
+		compatible = "nxp,pca9506";
+		reg = <0x24>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
 	power-sensor@40 {
 		compatible = "adi,adm1281";
 		reg = <0x40>;
@@ -237,6 +405,34 @@ mctp@10 {
 		reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
 	};
 
+	gpio@21 {
+		compatible = "nxp,pca9506";
+		reg = <0x21>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@22 {
+		compatible = "nxp,pca9506";
+		reg = <0x22>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@23 {
+		compatible = "nxp,pca9506";
+		reg = <0x23>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@24 {
+		compatible = "nxp,pca9506";
+		reg = <0x24>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
 	power-sensor@40 {
 		compatible = "adi,adm1281";
 		reg = <0x40>;
@@ -255,6 +451,34 @@ mctp@10 {
 		reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
 	};
 
+	gpio@21 {
+		compatible = "nxp,pca9506";
+		reg = <0x21>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@22 {
+		compatible = "nxp,pca9506";
+		reg = <0x22>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@23 {
+		compatible = "nxp,pca9506";
+		reg = <0x23>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@24 {
+		compatible = "nxp,pca9506";
+		reg = <0x24>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
 	power-sensor@40 {
 		compatible = "adi,adm1281";
 		reg = <0x40>;
@@ -385,6 +609,34 @@ ipmb@10 {
 		reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
 		i2c-protocol;
 	};
+
+	gpio@20 {
+		compatible = "nxp,pca9506";
+		reg = <0x20>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@21 {
+		compatible = "nxp,pca9506";
+		reg = <0x21>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@22 {
+		compatible = "nxp,pca9506";
+		reg = <0x22>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpio@23 {
+		compatible = "nxp,pca9506";
+		reg = <0x23>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
 };
 
 &i2c14 {
-- 
2.25.1

Re: [PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio pca9506 for CPLD IOE

[Andrew Jeffery]

On Tue, 2024-09-10 at 13:47 +0800, Delphine CC Chiu wrote:
> From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
> 
> We use CPLD to emulate gpio pca9506 I/O expander on each server
> boards.
> Therefore, add pca9506 to probe driver for the CPLD I/O expander.

I think it might be best if you add your own compatible to the list in
the gpio-pca95xx binding just in case there are some behavioural quirks
of your CPLD implementation? Not sure if this should be
"facebook,pca9506" or "wywinn,pca9506", but assuming facebook, from
there you can specify

    compatible = "facebook,pca9506", "nxp,pca9506";

This allows you to add the quirks to the driver as required in the
future through the more-specific compatible.

Andrew

RE: [PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio pca9506 for CPLD IOE

[Delphine_CC_Chiu/WYHQ/Wiwynn]

> -----Original Message-----
> From: Andrew Jeffery <andrew@codeconstruct.com.au>
> Sent: Thursday, September 12, 2024 10:11 AM
> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>;
> patrick@stwcx.xyz; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
> <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Joel Stanley
> <joel@jms.id.au>
> Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio pca9506
> for CPLD IOE
> 
>  [External Sender]
> 
>  [External Sender]
> 
> On Tue, 2024-09-10 at 13:47 +0800, Delphine CC Chiu wrote:
> > From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
> >
> > We use CPLD to emulate gpio pca9506 I/O expander on each server
> > boards.
> > Therefore, add pca9506 to probe driver for the CPLD I/O expander.
> 
> I think it might be best if you add your own compatible to the list in the
> gpio-pca95xx binding just in case there are some behavioural quirks of your
> CPLD implementation? Not sure if this should be "facebook,pca9506" or
> "wywinn,pca9506", but assuming facebook, from there you can specify
> 
>     compatible = "facebook,pca9506", "nxp,pca9506";
> 
> This allows you to add the quirks to the driver as required in the future through
> the more-specific compatible.
> 
> Andrew

Hi Andrew,

Thanks for the review.
I'll add the "facebook,pca9506" in gpio-pca95xx binding in next version of patches.

RE: [PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio pca9506 for CPLD IOE

[Delphine_CC_Chiu/WYHQ/Wiwynn]

> -----Original Message-----
> From: Delphine_CC_Chiu/WYHQ/Wiwynn
> Sent: Friday, September 13, 2024 10:08 AM
> To: Andrew Jeffery <andrew@codeconstruct.com.au>;
> Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>;
> patrick@stwcx.xyz; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
> <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Joel Stanley
> <joel@jms.id.au>
> Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org
> Subject: RE: [PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio pca9506
> for CPLD IOE
> 
> 
> 
> > -----Original Message-----
> > From: Andrew Jeffery <andrew@codeconstruct.com.au>
> > Sent: Thursday, September 12, 2024 10:11 AM
> > To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>;
> > patrick@stwcx.xyz; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
> > <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Joel Stanley
> > <joel@jms.id.au>
> > Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>;
> > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio
> > pca9506 for CPLD IOE
> >
> >  [External Sender]
> >
> >  [External Sender]
> >
> > On Tue, 2024-09-10 at 13:47 +0800, Delphine CC Chiu wrote:
> > > From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
> > >
> > > We use CPLD to emulate gpio pca9506 I/O expander on each server
> > > boards.
> > > Therefore, add pca9506 to probe driver for the CPLD I/O expander.
> >
> > I think it might be best if you add your own compatible to the list in
> > the gpio-pca95xx binding just in case there are some behavioural
> > quirks of your CPLD implementation? Not sure if this should be
> > "facebook,pca9506" or "wywinn,pca9506", but assuming facebook, from
> > there you can specify
> >
> >     compatible = "facebook,pca9506", "nxp,pca9506";
> >
> > This allows you to add the quirks to the driver as required in the
> > future through the more-specific compatible.
> >
> > Andrew
> 
> Hi Andrew,
> 
> Thanks for the review.
> I'll add the "facebook,pca9506" in gpio-pca95xx binding in next version of
> patches.

Hi Andrew,

I tried to add "facebook,pca9506" in the compatible list of gpio-pca95xx binding
and add compatible = "facebook,pca9506", "nxp,pca9506" but got following failed
messages:
    gpio@21: compatible: 'oneOf' conditional failed, one must be fixed:
        ['facebook,pca9506', 'nxp,pca9506'] is too long
        'diodes,pi4ioe5v6534q' was expected
        'nxp,pcal6534' was expected
        from schema $id: http://devicetree.org/schemas/gpio/gpio-pca95xx.yaml#
Would like to ask do you have any suggestions? Thanks.

Re: [PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio pca9506 for CPLD IOE

[Andrew Jeffery]

On Fri, 2024-09-13 at 03:26 +0000, Delphine_CC_Chiu/WYHQ/Wiwynn wrote:
> 
> > -----Original Message-----
> > From: Delphine_CC_Chiu/WYHQ/Wiwynn
> > Sent: Friday, September 13, 2024 10:08 AM
> > To: Andrew Jeffery <andrew@codeconstruct.com.au>;
> > Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>;
> > patrick@stwcx.xyz; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
> > <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Joel Stanley
> > <joel@jms.id.au>
> > Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>;
> > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org
> > Subject: RE: [PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio pca9506
> > for CPLD IOE
> > 
> > 
> > 
> > > -----Original Message-----
> > > From: Andrew Jeffery <andrew@codeconstruct.com.au>
> > > Sent: Thursday, September 12, 2024 10:11 AM
> > > To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>;
> > > patrick@stwcx.xyz; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
> > > <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Joel Stanley
> > > <joel@jms.id.au>
> > > Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>;
> > > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> > > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org
> > > Subject: Re: [PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio
> > > pca9506 for CPLD IOE
> > > 
> > >  [External Sender]
> > > 
> > >  [External Sender]
> > > 
> > > On Tue, 2024-09-10 at 13:47 +0800, Delphine CC Chiu wrote:
> > > > From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
> > > > 
> > > > We use CPLD to emulate gpio pca9506 I/O expander on each server
> > > > boards.
> > > > Therefore, add pca9506 to probe driver for the CPLD I/O expander.
> > > 
> > > I think it might be best if you add your own compatible to the list in
> > > the gpio-pca95xx binding just in case there are some behavioural
> > > quirks of your CPLD implementation? Not sure if this should be
> > > "facebook,pca9506" or "wywinn,pca9506", but assuming facebook, from
> > > there you can specify
> > > 
> > >     compatible = "facebook,pca9506", "nxp,pca9506";
> > > 
> > > This allows you to add the quirks to the driver as required in the
> > > future through the more-specific compatible.
> > > 
> > > Andrew
> > 
> > Hi Andrew,
> > 
> > Thanks for the review.
> > I'll add the "facebook,pca9506" in gpio-pca95xx binding in next version of
> > patches.
> 
> Hi Andrew,
> 
> I tried to add "facebook,pca9506" in the compatible list of gpio-pca95xx binding
> and add compatible = "facebook,pca9506", "nxp,pca9506" but got following failed
> messages:
>     gpio@21: compatible: 'oneOf' conditional failed, one must be fixed:
>         ['facebook,pca9506', 'nxp,pca9506'] is too long
>         'diodes,pi4ioe5v6534q' was expected
>         'nxp,pcal6534' was expected
>         from schema $id: http://devicetree.org/schemas/gpio/gpio-pca95xx.yaml#
> Would like to ask do you have any suggestions? Thanks.

Mmm, maybe it's best if we leave the compatible as just 'nxp,pca9506'
for now, but if you do discover quirks then we can consider this again.

Andrew

RE: [PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio pca9506 for CPLD IOE

[Ricky CX Wu/WYHQ/Wiwynn]

> -----Original Message-----
> From: Andrew Jeffery <andrew@codeconstruct.com.au>
> Sent: Monday, September 16, 2024 11:05 AM
> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>;
> patrick@stwcx.xyz; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
> <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Joel Stanley
> <joel@jms.id.au>
> Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio pca9506
> for CPLD IOE
>
>  [External Sender]
>
>  [External Sender]
>
> On Fri, 2024-09-13 at 03:26 +0000, Delphine_CC_Chiu/WYHQ/Wiwynn wrote:
> >
> > > -----Original Message-----
> > > From: Delphine_CC_Chiu/WYHQ/Wiwynn
> > > Sent: Friday, September 13, 2024 10:08 AM
> > > To: Andrew Jeffery <andrew@codeconstruct.com.au>;
> > > Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>;
> > > patrick@stwcx.xyz; Rob Herring <robh@kernel.org>; Krzysztof
> > > Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>;
> > > Joel Stanley <joel@jms.id.au>
> > > Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>;
> > > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> > > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org
> > > Subject: RE: [PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio
> > > pca9506 for CPLD IOE
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Andrew Jeffery <andrew@codeconstruct.com.au>
> > > > Sent: Thursday, September 12, 2024 10:11 AM
> > > > To: Delphine_CC_Chiu/WYHQ/Wiwynn
> <Delphine_CC_Chiu@wiwynn.com>;
> > > > patrick@stwcx.xyz; Rob Herring <robh@kernel.org>; Krzysztof
> > > > Kozlowski <krzk+dt@kernel.org>; Conor Dooley
> > > > <conor+dt@kernel.org>; Joel Stanley <joel@jms.id.au>
> > > > Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>;
> > > > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> > > > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org
> > > > Subject: Re: [PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio
> > > > pca9506 for CPLD IOE
> > > >
> > > >  [External Sender]
> > > >
> > > >  [External Sender]
> > > >
> > > > On Tue, 2024-09-10 at 13:47 +0800, Delphine CC Chiu wrote:
> > > > > From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
> > > > >
> > > > > We use CPLD to emulate gpio pca9506 I/O expander on each server
> > > > > boards.
> > > > > Therefore, add pca9506 to probe driver for the CPLD I/O expander.
> > > >
> > > > I think it might be best if you add your own compatible to the
> > > > list in the gpio-pca95xx binding just in case there are some
> > > > behavioural quirks of your CPLD implementation? Not sure if this
> > > > should be "facebook,pca9506" or "wywinn,pca9506", but assuming
> > > > facebook, from there you can specify
> > > >
> > > >     compatible = "facebook,pca9506", "nxp,pca9506";
> > > >
> > > > This allows you to add the quirks to the driver as required in the
> > > > future through the more-specific compatible.
> > > >
> > > > Andrew
> > >
> > > Hi Andrew,
> > >
> > > Thanks for the review.
> > > I'll add the "facebook,pca9506" in gpio-pca95xx binding in next
> > > version of patches.
> >
> > Hi Andrew,
> >
> > I tried to add "facebook,pca9506" in the compatible list of
> > gpio-pca95xx binding and add compatible = "facebook,pca9506",
> > "nxp,pca9506" but got following failed
> > messages:
> >     gpio@21: compatible: 'oneOf' conditional failed, one must be fixed:
> >         ['facebook,pca9506', 'nxp,pca9506'] is too long
> >         'diodes,pi4ioe5v6534q' was expected
> >         'nxp,pcal6534' was expected
> >         from schema $id:
> > https://urldefense.com/v3/__http://devicetree.org/schemas/gpio/gpio-pc
> >
> a95xx.yaml*__;Iw!!J63qqgXj!Kl4qHs-c0EOBPmv3aoSPNoOI4ryQ07GHCiaFIZkn7
> dH
> > -aY_50bsOoS3ZmF1bQpVt0Z_pdKANopTut-o4CHzlWWR_ya0$
> > Would like to ask do you have any suggestions? Thanks.
>
> Mmm, maybe it's best if we leave the compatible as just 'nxp,pca9506'
> for now, but if you do discover quirks then we can consider this again.
>
> Andrew
Hi Andrew,
Thanks for your reply.
I'll keep these patches at v1. Thanks.
WIWYNN PROPRIETARY
This email (and any attachments) contains proprietary or confidential information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited. If you are not the intended recipient, please notify the sender and delete this email immediately.

RE: [PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio pca9506 for CPLD IOE

[Delphine_CC_Chiu/WYHQ/Wiwynn]

> -----Original Message-----
> From: Andrew Jeffery <andrew@codeconstruct.com.au>
> Sent: Monday, September 16, 2024 11:05 AM
> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>;
> patrick@stwcx.xyz; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
> <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Joel Stanley
> <joel@jms.id.au>
> Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio pca9506
> for CPLD IOE
> 
>  [External Sender]
> 
>  [External Sender]
> 
> On Fri, 2024-09-13 at 03:26 +0000, Delphine_CC_Chiu/WYHQ/Wiwynn wrote:
> >
> > > -----Original Message-----
> > > From: Delphine_CC_Chiu/WYHQ/Wiwynn
> > > Sent: Friday, September 13, 2024 10:08 AM
> > > To: Andrew Jeffery <andrew@codeconstruct.com.au>;
> > > Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>;
> > > patrick@stwcx.xyz; Rob Herring <robh@kernel.org>; Krzysztof
> > > Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>;
> > > Joel Stanley <joel@jms.id.au>
> > > Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>;
> > > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> > > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org
> > > Subject: RE: [PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio
> > > pca9506 for CPLD IOE
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Andrew Jeffery <andrew@codeconstruct.com.au>
> > > > Sent: Thursday, September 12, 2024 10:11 AM
> > > > To: Delphine_CC_Chiu/WYHQ/Wiwynn
> <Delphine_CC_Chiu@wiwynn.com>;
> > > > patrick@stwcx.xyz; Rob Herring <robh@kernel.org>; Krzysztof
> > > > Kozlowski <krzk+dt@kernel.org>; Conor Dooley
> > > > <conor+dt@kernel.org>; Joel Stanley <joel@jms.id.au>
> > > > Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>;
> > > > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> > > > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org
> > > > Subject: Re: [PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio
> > > > pca9506 for CPLD IOE
> > > >
> > > >  [External Sender]
> > > >
> > > >  [External Sender]
> > > >
> > > > On Tue, 2024-09-10 at 13:47 +0800, Delphine CC Chiu wrote:
> > > > > From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
> > > > >
> > > > > We use CPLD to emulate gpio pca9506 I/O expander on each server
> > > > > boards.
> > > > > Therefore, add pca9506 to probe driver for the CPLD I/O expander.
> > > >
> > > > I think it might be best if you add your own compatible to the
> > > > list in the gpio-pca95xx binding just in case there are some
> > > > behavioural quirks of your CPLD implementation? Not sure if this
> > > > should be "facebook,pca9506" or "wywinn,pca9506", but assuming
> > > > facebook, from there you can specify
> > > >
> > > >     compatible = "facebook,pca9506", "nxp,pca9506";
> > > >
> > > > This allows you to add the quirks to the driver as required in the
> > > > future through the more-specific compatible.
> > > >
> > > > Andrew
> > >
> > > Hi Andrew,
> > >
> > > Thanks for the review.
> > > I'll add the "facebook,pca9506" in gpio-pca95xx binding in next
> > > version of patches.
> >
> > Hi Andrew,
> >
> > I tried to add "facebook,pca9506" in the compatible list of
> > gpio-pca95xx binding and add compatible = "facebook,pca9506",
> > "nxp,pca9506" but got following failed
> > messages:
> >     gpio@21: compatible: 'oneOf' conditional failed, one must be fixed:
> >         ['facebook,pca9506', 'nxp,pca9506'] is too long
> >         'diodes,pi4ioe5v6534q' was expected
> >         'nxp,pcal6534' was expected
> >         from schema $id:
> > https://urldefense.com/v3/__http://devicetree.org/schemas/gpio/gpio-pc
> >
> a95xx.yaml*__;Iw!!J63qqgXj!Kl4qHs-c0EOBPmv3aoSPNoOI4ryQ07GHCiaFIZkn7
> dH
> > -aY_50bsOoS3ZmF1bQpVt0Z_pdKANopTut-o4CHzlWWR_ya0$
> > Would like to ask do you have any suggestions? Thanks.
> 
> Mmm, maybe it's best if we leave the compatible as just 'nxp,pca9506'
> for now, but if you do discover quirks then we can consider this again.
> 
> Andrew
Hi Andrew,
Thanks for your reply.
I'll keep these patches at v1. Thanks.

Re: [PATCH v1 0/2] Yosemite4: Add devices on I2C buses to server boards

[Andrew Jeffery]

On Tue, 10 Sep 2024 13:47:49 +0800, Delphine CC Chiu wrote:
> Changelog:
>   - v1
>     - Revise to use adm1281 on Medusa board.
>     - Add gpio pca9506 for CPLD I/O expander.
> 
> Ricky CX Wu (2):
>   ARM: dts: aspeed: yosemite4: Revise to use adm1281 on Medusa board
>   ARM: dts: aspeed: yosemite4: Add gpio pca9506 for CPLD IOE
> 
> [...]

Thanks, I've applied this to be picked up through the BMC tree.

[1/2] ARM: dts: aspeed: yosemite4: Revise to use adm1281 on Medusa board
      commit: 4c417a6b31471da78b87f9e542f285e2225744e0
[2/2] ARM: dts: aspeed: yosemite4: Add gpio pca9506 for CPLD IOE
      commit: 00f897797acf562bcbda20d8ca93f279a0c6bb5b

--
Andrew Jeffery <andrew@codeconstruct.com.au>