From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44978C433EF for ; Tue, 21 Jun 2022 15:59:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352455AbiFUP6Q (ORCPT ); Tue, 21 Jun 2022 11:58:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351950AbiFUP6N (ORCPT ); Tue, 21 Jun 2022 11:58:13 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61340B96 for ; Tue, 21 Jun 2022 08:58:08 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id e5so7764559wma.0 for ; Tue, 21 Jun 2022 08:58:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=8bGIi/65SNf1gUCizJJAA/uyPpaT7iiHXEa0Yre3OLs=; b=qc78xzPKYmrdcuYQ1ne6Hu8H1BSHHtXY0kD3g+N7e0SwghvQN3cw/qoAboUgUrs+Ck +iwQJ1AJ10Btc0VTT9f6WHOgo8D1M44NtYEiybmDF8Qw1nuDngA9JskQuGCbrE3tO6nl eOC4eyyo/f5SFvf9KgmRv+CDRnTziQhvDBCEM5t7Y86dYYU5K3O1Rl6sZVi1kpPAVOvC Mm5VwD38GAGomFJPcHYSHlYRYekmhbWFD6Ok/DiaZrz5oqAr5y0B65kbUBRp1g5dzbcn hGDJpk81SwmFxFBSKHm447D3o18Ami9ckEnNWJFVwbBjwjxjpvgRktuW+I3Y1jnfs+DD k+ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=8bGIi/65SNf1gUCizJJAA/uyPpaT7iiHXEa0Yre3OLs=; b=I60sAWzBKHXEKuUVCG8zKMIDA9IenTzI4+anGXKQ2SBJzn9Ido95g824EoYD9Pia1E CHTRhD6MidAWoj3bBQlRHcaQa+hnPw7qdUJik9cbhzPZNzUb2dNFCfYPnM6b5fpa+Pmc 21Ok/gbGBhTKNeoi/+qA9wQZbP5S2zN4tc8BXAz1R3GzK7McIqfS/r2POg6FSegc+5HR zCRXp+p79RZy0qe7Od4gB5GnB6AlvmlW6BQY/KI7xuKmmRPHVMG4LoBcO72zi8vt+SCy ZOKwmPXsY/pgNWsolErgZTAZ5sdjbs+7Ip/fqXM3T9SIou0MnjWSKXbDnMWqfOaVqlYR MQ8Q== X-Gm-Message-State: AOAM532NyhnvLG7vThEs9sZbfFddEl5d6AReS+DINm33F/iufBF6bUwH qXcFpS/TC4XkBersDKZYIhJFwQ== X-Google-Smtp-Source: ABdhPJzfQtcmGS9lGGD/a74+uwozsMtxNFYclUUgKl5wNK5vG+XpP16pmsEjUM4CRShV7wvaWru3eQ== X-Received: by 2002:a05:600c:3b88:b0:39c:55b2:3d1 with SMTP id n8-20020a05600c3b8800b0039c55b203d1mr42734848wms.64.1655827086597; Tue, 21 Jun 2022 08:58:06 -0700 (PDT) Received: from [192.168.0.221] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id i187-20020a1c3bc4000000b0039ee52c1345sm12581252wma.4.2022.06.21.08.58.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jun 2022 08:58:06 -0700 (PDT) Message-ID: Date: Tue, 21 Jun 2022 17:58:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/2] dt-bindings: net: wireless: ath11k: add new DT entry for board ID Content-Language: en-US To: Robert Marko , kvalo@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220621135339.1269409-1-robimarko@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220621135339.1269409-1-robimarko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/06/2022 15:53, Robert Marko wrote: > bus + qmi-chip-id + qmi-board-id and optionally the variant are currently > used for identifying the correct board data file. > > This however is sometimes not enough as all of the IPQ8074 boards that I > have access to dont have the qmi-board-id properly fused and simply return > the default value of 0xFF. > > So, to provide the correct qmi-board-id add a new DT property that allows > the qmi-board-id to be overridden from DTS in cases where its not set. > This is what vendors have been doing in the stock firmwares that were > shipped on boards I have. > > Signed-off-by: Robert Marko Thank you for your patch. There is something to discuss/improve. > --- > .../devicetree/bindings/net/wireless/qcom,ath11k.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml > index a677b056f112..fe6aafdab9d4 100644 > --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml > @@ -41,6 +41,14 @@ properties: > * reg > * reg-names > > + qcom,ath11k-board-id: The "board" a bit confuses me because in the context of entire system it means the entire hardware running Qualcomm SoC. This is sometimes encoded as qcom,board-id property. Is your property exactly the same? > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Board ID to override the one returned by the firmware or the default > + 0xff if it was not set by the vendor at all. > + It is used along the ath11k-calibration-variant to mach the correct > + calibration data from board-2.bin. > + > qcom,ath11k-calibration-variant: > $ref: /schemas/types.yaml#/definitions/string > description: Best regards, Krzysztof