From: Jack Zhu <jack.zhu@starfivetech.com>
To: Conor Dooley <conor@kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
<bryan.odonoghue@linaro.org>, Rob Herring <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Eugen Hristev <eugen.hristev@collabora.com>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
<linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>, <changhuang.liang@starfivetech.com>
Subject: Re: [PATCH v5 1/6] media: dt-bindings: Add JH7110 Camera Subsystem
Date: Mon, 15 May 2023 13:33:38 +0800 [thread overview]
Message-ID: <a19da8fc-aba8-4d0f-0e31-a563439be75a@starfivetech.com> (raw)
In-Reply-To: <20230512-sasquatch-untracked-1587b55c2008@spud>
On 2023/5/13 4:13, Conor Dooley wrote:
> On Fri, May 12, 2023 at 06:28:39PM +0800, Jack Zhu wrote:
>
>> +description:
>> + The Starfive CAMSS ISP is a Camera interface for Starfive JH7110 SoC. It
>> + consists of a VIN controller (Video In Controller, a top-level control until)
>> + and an ISP.
>
> Just a minor comment here, "until" is a typo, right?
> I guess it should be "unit".
Yes, will modify it in next version. Thank you for your review.
next prev parent reply other threads:[~2023-05-15 5:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 10:28 [PATCH v5 0/6] Add StarFive Camera Subsystem driver Jack Zhu
2023-05-12 10:28 ` [PATCH v5 1/6] media: dt-bindings: Add JH7110 Camera Subsystem Jack Zhu
2023-05-12 11:26 ` Krzysztof Kozlowski
2023-05-15 5:32 ` Jack Zhu
2023-05-12 20:13 ` Conor Dooley
2023-05-15 5:33 ` Jack Zhu [this message]
2023-05-12 10:28 ` [PATCH v5 2/6] media: admin-guide: Add starfive_camss.rst for Starfive " Jack Zhu
2023-05-12 10:28 ` [PATCH v5 3/6] media: starfive: Add basic driver Jack Zhu
2023-05-12 12:50 ` Bryan O'Donoghue
2023-05-15 5:38 ` Jack Zhu
2023-05-12 10:28 ` [PATCH v5 4/6] media: starfive: Add video driver Jack Zhu
2023-05-12 10:28 ` [PATCH v5 5/6] media: starfive: Add ISP driver Jack Zhu
2023-05-12 10:28 ` [PATCH v5 6/6] media: starfive: Add VIN driver Jack Zhu
2023-05-12 13:01 ` [PATCH v5 0/6] Add StarFive Camera Subsystem driver Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a19da8fc-aba8-4d0f-0e31-a563439be75a@starfivetech.com \
--to=jack.zhu@starfivetech.com \
--cc=bryan.odonoghue@linaro.org \
--cc=changhuang.liang@starfivetech.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eugen.hristev@collabora.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=hverkuil-cisco@xs4all.nl \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rfoss@kernel.org \
--cc=robh+dt@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).