From: Florian Vaussard <florian.vaussard@gmail.com>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>
Cc: devicetree@vger.kernel.org, Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <j.anaszewski@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Florian Vaussard <florian.vaussard@heig-vd.ch>
Subject: Re: [PATCH v3 1/2] leds: ncp5623: Add device tree binding documentation
Date: Wed, 28 Sep 2016 12:04:34 +0200 [thread overview]
Message-ID: <a1bc95d5-a460-b4c7-5392-93fda0cc4f7a@gmail.com> (raw)
In-Reply-To: <bd220063-5c66-c428-738f-0eeb5f4f0bc7@gmail.com>
Hello Jacek,
Le 24. 09. 16 à 21:06, Jacek Anaszewski a écrit :
> On 09/24/2016 01:58 PM, Pavel Machek wrote:
>> Hi!
>>
>>> +Example
>>> +=======
>>> +
>>> +led1: ncp5623@38 {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + compatible = "onnn,ncp5623";
>>> + reg = <0x38>;
>>> + onnn,led-iref-microamp = <10>;
>>> +
>>> + led1r@0 {
>>> + label = "ncp:power:red";
>>> + linux,default-trigger = "default-on";
>> ...
>>> + led1b@1 {
>>> + label = "ncp:power:blue";
>>> + reg = <1>;
>>
>> Actually... the three LEDs are packaged such as this is one colorful
>> light to the user, right? Some day we'll need to group them, so that
>> kernel can automatically tell this is one led, and probably add extra
>> attributes, such as values that produce white light.
>
> We could try out the trigger approach we discussed few months ago.
> Unfortunately I currently don't have enough time to propose the
> implementation. Probably this work could be done on the occasion of
> addition of RGB LED class driver like this, if the author had free
> bandwidth for that.
>
Unfortunately my bandwidth is pretty well used at the moment :)
Best regards,
Florian
next prev parent reply other threads:[~2016-09-28 10:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 11:34 [PATCH v3 0/2] leds: Add driver for NCP5623 3-channel I2C LED driver Florian Vaussard
2016-09-16 11:34 ` [PATCH v3 1/2] leds: ncp5623: Add device tree binding documentation Florian Vaussard
[not found] ` <1474025672-5040-2-git-send-email-florian.vaussard-EWQkb/GNqlFyDzI6CaY1VQ@public.gmane.org>
2016-09-23 17:29 ` Rob Herring
2016-09-24 11:58 ` Pavel Machek
2016-09-24 19:06 ` Jacek Anaszewski
2016-09-28 10:04 ` Florian Vaussard [this message]
2016-09-28 10:02 ` Florian Vaussard
2016-09-28 10:58 ` Pavel Machek
[not found] ` <1474025672-5040-1-git-send-email-florian.vaussard-EWQkb/GNqlFyDzI6CaY1VQ@public.gmane.org>
2016-09-16 11:34 ` [PATCH v3 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver Florian Vaussard
[not found] ` <1474025672-5040-3-git-send-email-florian.vaussard-EWQkb/GNqlFyDzI6CaY1VQ@public.gmane.org>
2016-09-18 18:20 ` Jacek Anaszewski
[not found] ` <d6dfc1aa-941d-fdbb-5fda-74c85b571bc5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-09-24 12:00 ` Pavel Machek
2016-09-24 18:45 ` Jacek Anaszewski
2016-09-29 16:18 ` Florian Vaussard
[not found] ` <4990cd83-ae67-aec4-ae8b-4d0db3cbc9fe-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-09-29 17:13 ` Florian Vaussard
2016-09-30 21:00 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1bc95d5-a460-b4c7-5392-93fda0cc4f7a@gmail.com \
--to=florian.vaussard@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=florian.vaussard@heig-vd.ch \
--cc=j.anaszewski@samsung.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).