From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Hermes Zhang <chenhuiz@axis.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: kernel@axis.com, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mmc: Add cap-aggressive-pm property
Date: Tue, 31 Jan 2023 17:57:16 +0100 [thread overview]
Message-ID: <a1d2ac4c-0763-5c92-be21-22820c376438@linaro.org> (raw)
In-Reply-To: <b125f25d-94c7-dd5b-28d3-3948c36ef4e0@axis.com>
On 30/01/2023 07:54, Hermes Zhang wrote:
> On 2023/1/29 18:58, Krzysztof Kozlowski wrote:
>> On 29/01/2023 03:36, Hermes Zhang wrote:
>>> This commit add a new property: cap-aggressive-pm to enable the
>> Do not use "This commit/patch".
>> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
>
> Done
>
>>> MMC_CAP_AGGRESSIVE_PM feature for (e)MMC/SD power saving.
>> Why this is a property suitable for DT? IOW, why this isn't enabled always?
>
> This property will benfit for the power consumption, but it also may
> degradation in performance as it will prevent the
>
> the card from executing internal house-keeping operations in idle mode.
> So it's better to config it from DT.
Why? DT is not for policy. How you described it, this is policy or
system tuning choice thus the job for Linux (OS), not for DT. So I will
repeat - why this property fits the purpose of DT (describe the hardware).
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-31 16:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-29 2:36 [PATCH] dt-bindings: mmc: Add cap-aggressive-pm property Hermes Zhang
2023-01-29 10:58 ` Krzysztof Kozlowski
[not found] ` <b125f25d-94c7-dd5b-28d3-3948c36ef4e0@axis.com>
2023-01-31 16:57 ` Krzysztof Kozlowski [this message]
2023-02-02 14:59 ` Ulf Hansson
2023-02-02 16:25 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1d2ac4c-0763-5c92-be21-22820c376438@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=chenhuiz@axis.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@axis.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).