From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Christian Marangi <ansuelsmth@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v6 4/6] ARM: dts: qcom: fix various wrong definition for kpss-gcc node
Date: Thu, 12 Jan 2023 06:11:33 +0200 [thread overview]
Message-ID: <a1d3be86-d986-6f36-1f17-ab91e7b609c8@linaro.org> (raw)
In-Reply-To: <20230110183259.19142-5-ansuelsmth@gmail.com>
On 10/01/2023 20:32, Christian Marangi wrote:
> Fix dtbs_check warning now that we have a correct kpss-gcc yaml
> schema. Add additional qcom,kpss-gcc compatible to differentiate
> devices where kpss-gcc should provide a clk and where kpss-gcc should
> just provide the registers and the syscon phandle.
> Add missing #clock-cells and remove useless clock-output-names for
> ipq806x.
> Add missing bindings for msm8960 and apq8064 kpss-gcc node.
>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
> arch/arm/boot/dts/qcom-apq8064.dtsi | 5 ++++-
> arch/arm/boot/dts/qcom-ipq8064.dtsi | 4 ++--
> arch/arm/boot/dts/qcom-mdm9615.dtsi | 2 +-
> arch/arm/boot/dts/qcom-msm8660.dtsi | 2 +-
> arch/arm/boot/dts/qcom-msm8960.dtsi | 5 ++++-
> 5 files changed, 12 insertions(+), 6 deletions(-)
Please split this commit into two commits:
- one adding per-SoC compatibles. Mention that they are not (yet) used
by the driver, but can serve further customisation.
- another one adding and fixing clock configuration. My notes to patch
5/6 applies here too.
>
> diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
> index 1f3e0aa9ab0c..1e68b42acb91 100644
> --- a/arch/arm/boot/dts/qcom-apq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
> @@ -880,8 +880,11 @@ mmcc: clock-controller@4000000 {
> };
>
> l2cc: clock-controller@2011000 {
> - compatible = "qcom,kpss-gcc", "syscon";
> + compatible = "qcom,kpss-gcc-apq8064", "qcom,kpss-gcc", "syscon";
> reg = <0x2011000 0x1000>;
> + clocks = <&gcc PLL8_VOTE>, <&pxo_board>;
> + clock-names = "pll8_vote", "pxo";
> + #clock-cells = <0>;
> };
>
> rpm: rpm@108000 {
> diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> index 7e784b0995da..de87fcaaa836 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> @@ -570,11 +570,11 @@ IRQ_TYPE_EDGE_RISING)>,
> };
>
> l2cc: clock-controller@2011000 {
> - compatible = "qcom,kpss-gcc", "syscon";
> + compatible = "qcom,kpss-gcc-ipq8064", "qcom,kpss-gcc", "syscon";
> reg = <0x02011000 0x1000>;
> clocks = <&gcc PLL8_VOTE>, <&pxo_board>;
> clock-names = "pll8_vote", "pxo";
> - clock-output-names = "acpu_l2_aux";
> + #clock-cells = <0>;
> };
>
> acc0: clock-controller@2088000 {
> diff --git a/arch/arm/boot/dts/qcom-mdm9615.dtsi b/arch/arm/boot/dts/qcom-mdm9615.dtsi
> index b0fe1d95d88f..61dfec3b9037 100644
> --- a/arch/arm/boot/dts/qcom-mdm9615.dtsi
> +++ b/arch/arm/boot/dts/qcom-mdm9615.dtsi
> @@ -116,7 +116,7 @@ lcc: clock-controller@28000000 {
> };
>
> l2cc: clock-controller@2011000 {
> - compatible = "qcom,kpss-gcc", "syscon";
> + compatible = "qcom,kpss-gcc-mdm9615", "qcom,kpss-gcc", "syscon";
> reg = <0x02011000 0x1000>;
> };
>
> diff --git a/arch/arm/boot/dts/qcom-msm8660.dtsi b/arch/arm/boot/dts/qcom-msm8660.dtsi
> index 86f76d0feff4..f601b40ebcf4 100644
> --- a/arch/arm/boot/dts/qcom-msm8660.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8660.dtsi
> @@ -473,7 +473,7 @@ pm8058_led133: led@133 {
> };
>
> l2cc: clock-controller@2082000 {
> - compatible = "qcom,kpss-gcc", "syscon";
> + compatible = "qcom,kpss-gcc-msm8660", "qcom,kpss-gcc", "syscon";
> reg = <0x02082000 0x1000>;
> };
>
> diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi
> index 7debf9db7cb1..3bd07cac315b 100644
> --- a/arch/arm/boot/dts/qcom-msm8960.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8960.dtsi
> @@ -183,8 +183,11 @@ clock-controller@4000000 {
> };
>
> l2cc: clock-controller@2011000 {
> - compatible = "qcom,kpss-gcc", "syscon";
> + compatible = "qcom,kpss-gcc-msm8960", "qcom,kpss-gcc", "syscon";
> reg = <0x2011000 0x1000>;
> + clocks = <&gcc PLL8_VOTE>, <&pxo_board>;
> + clock-names = "pll8_vote", "pxo";
> + #clock-cells = <0>;
> };
>
> rpm: rpm@108000 {
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-01-12 4:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 18:32 [PATCH v6 0/6] Krait Documentation conversion Christian Marangi
2023-01-10 18:32 ` [PATCH v6 1/6] dt-bindings: clock: Convert qcom,krait-cc to yaml Christian Marangi
2023-01-10 18:32 ` [PATCH v6 2/6] dt-bindings: arm: msm: Convert and split kpss-acc driver Documentation " Christian Marangi
2023-01-12 4:00 ` Dmitry Baryshkov
2023-01-13 13:18 ` Christian Marangi
2023-01-10 18:32 ` [PATCH v6 3/6] dt-bindings: arm: msm: Rework kpss-gcc " Christian Marangi
2023-01-13 1:30 ` Rob Herring
2023-01-10 18:32 ` [PATCH v6 4/6] ARM: dts: qcom: fix various wrong definition for kpss-gcc node Christian Marangi
2023-01-12 4:11 ` Dmitry Baryshkov [this message]
2023-01-10 18:32 ` [PATCH v6 5/6] ARM: dts: qcom: fix various wrong definition for kpss-acc-v1 Christian Marangi
2023-01-12 4:08 ` Dmitry Baryshkov
2023-01-10 18:32 ` [PATCH v6 6/6] ARM: dts: qcom: fix various wrong definition for kpss-acc-v2 Christian Marangi
2023-01-12 4:12 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1d3be86-d986-6f36-1f17-ab91e7b609c8@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).