From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mauri Sandberg <maukka@ext.kapsi.fi>,
soc@kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org
Cc: arnd@arndb.de, olof@lixom.net, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, andrew@lunn.ch,
sebastian.hesselbarth@gmail.com
Subject: Re: [RFC RFT PATCH v1 1/1] ARM: orion5x: convert D-Link DNS-323 to the Device Tree
Date: Thu, 28 Apr 2022 09:13:25 +0200 [thread overview]
Message-ID: <a1d5cec3-b883-319c-c413-b09cca1fa518@linaro.org> (raw)
In-Reply-To: <20220427162123.110458-2-maukka@ext.kapsi.fi>
On 27/04/2022 18:21, Mauri Sandberg wrote:
> Convert D-Link DNS-323 to use the device tree and remove associated
> mach file.
>
Thank you for your patch. There is something to discuss/improve.
> Signed-off-by: Mauri Sandberg <maukka@ext.kapsi.fi>
> ---
> arch/arm/boot/dts/Makefile | 3 +
> arch/arm/boot/dts/orion5x-dlink-dns323.dtsi | 217 ++++++
> arch/arm/boot/dts/orion5x-dlink-dns323a1.dts | 59 ++
> arch/arm/boot/dts/orion5x-dlink-dns323b1.dts | 38 +
> arch/arm/boot/dts/orion5x-dlink-dns323c1.dts | 80 ++
> arch/arm/mach-orion5x/Kconfig | 6 +-
> arch/arm/mach-orion5x/Makefile | 2 +-
> arch/arm/mach-orion5x/board-dns323.c | 118 +++
> arch/arm/mach-orion5x/board-dt.c | 3 +
> arch/arm/mach-orion5x/common.h | 6 +
> arch/arm/mach-orion5x/dns323-setup.c | 724 -------------------
> 11 files changed, 528 insertions(+), 728 deletions(-)
> create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323.dtsi
> create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323a1.dts
> create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323b1.dts
> create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323c1.dts
> create mode 100644 arch/arm/mach-orion5x/board-dns323.c
> delete mode 100644 arch/arm/mach-orion5x/dns323-setup.c
DTS goes separately.
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 7c16f8a2b738..c7c5c0b6c843 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -949,6 +949,9 @@ dtb-$(CONFIG_SOC_DRA7XX) += \
> dra71-evm.dtb \
> dra76-evm.dtb
> dtb-$(CONFIG_ARCH_ORION5X) += \
> + orion5x-dlink-dns323a1.dtb \
> + orion5x-dlink-dns323b1.dtb \
> + orion5x-dlink-dns323c1.dtb \
> orion5x-kuroboxpro.dtb \
> orion5x-lacie-d2-network.dtb \
> orion5x-lacie-ethernet-disk-mini-v2.dtb \
> diff --git a/arch/arm/boot/dts/orion5x-dlink-dns323.dtsi b/arch/arm/boot/dts/orion5x-dlink-dns323.dtsi
> new file mode 100644
> index 000000000000..2b033d37cbf8
> --- /dev/null
> +++ b/arch/arm/boot/dts/orion5x-dlink-dns323.dtsi
> @@ -0,0 +1,217 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (C) 2022 Mauri Sandberg <maukka@ext.kapsi.fi>
> + *
> + */
> +
> +/ {
> + model = "D-Link DNS-323";
> + compatible = "dlink,dns323", "marvell,orion5x";
>
You need to also document the compatibles in bindings file for boards.
It would be nice to convert
Documentation/devicetree/bindings/arm/marvell/marvell,orion5x.txt to DT
Schema (see armada-7k-8k.yaml for example), but it is not a requirement.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-28 7:13 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 16:21 [RFC RFT PATCH v1 0/1] ARM: orion5x: convert D-Link DNS-323 to the Device Tree Mauri Sandberg
2022-04-27 16:21 ` [RFC RFT PATCH v1 1/1] " Mauri Sandberg
2022-04-27 18:12 ` Arnd Bergmann
2022-04-28 20:06 ` Mauri Sandberg
2022-04-28 20:47 ` Arnd Bergmann
2022-04-28 7:13 ` Krzysztof Kozlowski [this message]
2022-04-28 20:09 ` Mauri Sandberg
2022-04-27 18:10 ` [RFC RFT PATCH v1 0/1] " Arnd Bergmann
2022-04-28 0:18 ` Andrew Lunn
2022-04-28 20:25 ` Mauri Sandberg
2022-04-28 23:26 ` Andrew Lunn
2022-05-03 8:20 ` Mauri Sandberg
2022-04-28 20:01 ` Mauri Sandberg
2022-04-28 20:56 ` Arnd Bergmann
2022-05-08 14:06 ` Mauri Sandberg
2022-05-08 15:02 ` Arnd Bergmann
[not found] ` <20220508152237.3hw657gcba2fvheq@pali>
2022-05-08 19:34 ` Mauri Sandberg
[not found] ` <20220508201044.qyh75mb4x64uuhfc@pali>
2022-05-09 10:52 ` Mauri Sandberg
[not found] ` <20220508154126.3wubyyunpuxetswm@pali>
2022-05-09 7:21 ` Arnd Bergmann
2022-05-09 10:48 ` Mauri Sandberg
2022-04-28 0:29 ` Andrew Lunn
2022-09-22 20:24 ` [PATCH v2 0/3] ARM: orion5x: add D-Link DNS323 based on device treee Mauri Sandberg
2022-09-22 20:24 ` [PATCH v2 1/3] dt-bindings: arm: add DT binding for D-Link DNS-323 Mauri Sandberg
2022-09-22 20:36 ` Andrew Lunn
2022-09-23 9:18 ` Krzysztof Kozlowski
2022-09-22 20:24 ` [PATCH v2 2/3] ARM: dts: orion5x: Add D-Link DNS-323 Device Tree Mauri Sandberg
2022-09-22 20:45 ` Andrew Lunn
2022-09-22 21:14 ` Pali Rohár
2022-09-22 21:32 ` Andrew Lunn
2022-09-23 9:19 ` Krzysztof Kozlowski
2022-09-27 11:26 ` kernel test robot
2022-09-27 22:56 ` kernel test robot
2022-09-22 20:24 ` [PATCH v2 3/3] ARM: orion5x: Add D-Link DNS-323 based on " Mauri Sandberg
2022-09-22 21:10 ` Andrew Lunn
2022-09-23 9:03 ` maukka
2022-09-23 12:12 ` Andrew Lunn
2022-09-23 18:02 ` Pali Rohár
2022-09-26 11:56 ` maukka
2022-09-26 12:23 ` Pali Rohár
2022-09-28 13:32 ` [EXT] " Elad Nachman
2022-09-30 15:40 ` Pali Rohár
2022-09-22 21:39 ` Arnd Bergmann
2022-09-23 9:13 ` maukka
2022-09-23 9:24 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1d5cec3-b883-319c-c413-b09cca1fa518@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maukka@ext.kapsi.fi \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).